From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C11C433E0 for ; Tue, 26 May 2020 09:00:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6FB620776 for ; Tue, 26 May 2020 09:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590483623; bh=STAm2RC3mfBdgq2YxbuI9GIS/umeg4tqG1qVVqpD+Qc=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=BIjJZ7f6EZRPnwklJHIVCAQM1fszme0iJOWz1+Q/Xtba7j0rPwVtj+mSy60auZgyt TuvcDX7SmBGt3eMvEtHNONtbXdQVPaYKT+eGyXlVFp3I/Skbo53fYZSQJb5hoGGaTT 8L7idyABdo5MAVd0B0xbtmMwFvEwcb1AC3hJDGfE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731645AbgEZJAW (ORCPT ); Tue, 26 May 2020 05:00:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:47786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731428AbgEZJAV (ORCPT ); Tue, 26 May 2020 05:00:21 -0400 Received: from pobox.suse.cz (nat1.prg.suse.com [195.250.132.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A8FF205CB; Tue, 26 May 2020 09:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590483621; bh=STAm2RC3mfBdgq2YxbuI9GIS/umeg4tqG1qVVqpD+Qc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rFtS0fkfRy69LGOWRVQpHK8QF6CywMnRxb8BNmzOD7oO+D2sFnZx26Yv4LLE26WHg XH1oC2r08o8SNr4a6CP2Cu9VwBGjPb2A3/HVXr3dxXq1y6XLx4UQxS+zBVBNBkubum Gb2VT0WizmOl+rRE1I2herp8JjPa+t/n3TfmROfw= Date: Tue, 26 May 2020 11:00:18 +0200 (CEST) From: Jiri Kosina To: Scott Shumate cc: "Colenbrander, Roderick" , Benjamin Tissoires , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] HID: sony: Fix for broken buttons on DS3 USB dongles In-Reply-To: Message-ID: References: <46c1ab66-62d7-5dae-2f4d-7e722f1aff3a@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 May 2020, Scott Shumate wrote: > Hi Roderick, > > The official DS3 has a Report Count(19) instead of Report Count(13) in the > exact same offset. I have no idea what the silicon vendor for these dongles > was thinking but it's suspicious that the official count of 19 (0x13) turned > into 13 (0xd) in the knock-off. It makes you wonder if the engineers confused > the decimal/hex numbers. > > As buggy as all of these third-party devices are, I'm afraid relying on the > HID parser to get it right is only going to worse over time. I do like your > idea of having each device register themselves. It would be nice to have each > device provide a callback to decode its own report rather than handle a bunch > of special conditions and quirks in a unified report decoding function. The > drawback of course is that its going to be a little more effort to maintain. I've added Cc: stable and Fixes: tag, and applied. Thanks, -- Jiri Kosina SUSE Labs