From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774A1C43331 for ; Wed, 3 Mar 2021 21:21:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C40264ECF for ; Wed, 3 Mar 2021 21:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387870AbhCCTee (ORCPT ); Wed, 3 Mar 2021 14:34:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:43458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241393AbhCCTUy (ORCPT ); Wed, 3 Mar 2021 14:20:54 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id ABDCA64EF3; Wed, 3 Mar 2021 19:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614799177; bh=foliZiz3rI2vyKLIHWNgT7LIMdi0MA4Hbv+MqoW7wR0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=petoCf703nrmUXLuxW+FbHQpB4MLYYSf85UQvamRzAs5gkulHW/6iIeiGZ+pAdnJk +QjhfFawL7p9U1FL+Z3lPZ46Jx7BzEZeWQD3Uwcogl0zGmlEiukicpwQBjsNXTwJMZ lsuP1P7EcG7/ddHpwmZoRfiinFyXnOypinWjomf5d3PfLMzL63xW6HSHySsfz2KQpp q/hMpUFn+TtID2YeAM8b3F7GKhPqr3M19V0FKAX30QPlMdzkdwK3jw1lL0HazT6z+o YZjYXebeSb1dhB4l4RGQGCIF15QlayyAQ3gAvfjEXdeSAyS3EFY2p3Mbj6T855mHXK CYzFQQ2V4xwIg== Date: Wed, 3 Mar 2021 20:19:33 +0100 (CET) From: Jiri Kosina To: Kalle Valo cc: Johannes Berg , Luca Coelho , Heiner Kallweit , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iwlwifi: don't call netif_napi_add() with rxq->lock held (was Re: Lockdep warning in iwl_pcie_rx_handle()) In-Reply-To: <87y2f46qai.fsf@codeaurora.org> Message-ID: References: <20210303155941.25521C43463@smtp.codeaurora.org> <87y2f46qai.fsf@codeaurora.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Mar 2021, Kalle Valo wrote: > > ... i believe you want to drop the "(was ...") part from the patch > > subject. > > Too late now, it's already applied and pull request sent. Why was it > there in the first place? Yeah, it was, but I don't think it's a big issue :) So let it be. BTW, how about the other fix I sent? It's also fixing a real functional issue, so it IMHO is a -rc material https://lore.kernel.org/linux-wireless/nycvar.YFH.7.76.2103021125430.12405@cbobk.fhfr.pm/ Thanks, -- Jiri Kosina SUSE Labs