From: Jiri Kosina <jikos@kernel.org>
To: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Cc: benjamin.tissoires@redhat.com, rydberg@bitmath.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: wacom: Assign boolean values to a bool variable
Date: Mon, 8 Mar 2021 14:57:27 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2103081457220.12405@cbobk.fhfr.pm> (raw)
In-Reply-To: <1611128070-59752-1-git-send-email-abaci-bugfix@linux.alibaba.com>
On Wed, 20 Jan 2021, Jiapeng Zhong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/hid/wacom_wac.c:2536:2-6: WARNING: Assignment of
> 0/1 to bool variable.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/hid/wacom_wac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
> index 1bd0eb7..62b0f71 100644
> --- a/drivers/hid/wacom_wac.c
> +++ b/drivers/hid/wacom_wac.c
> @@ -2533,7 +2533,7 @@ static void wacom_wac_finger_slot(struct wacom_wac *wacom_wac,
> !wacom_wac->shared->is_touch_on) {
> if (!wacom_wac->shared->touch_down)
> return;
> - prox = 0;
> + prox = false;
> }
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-03-08 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 7:34 [PATCH] HID: wacom: Assign boolean values to a bool variable Jiapeng Zhong
2021-03-08 13:57 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2103081457220.12405@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).