From: Jiri Kosina <jikos@kernel.org>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Anssi Hannula <anssi.hannula@gmail.com>,
Dmitry Torokhov <dtor@mail.ru>,
linux-usb <linux-usb@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] HID: pidff: fix error return code in hid_pidff_init()
Date: Wed, 26 May 2021 12:40:38 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2105261240280.28378@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210508024737.1927-1-thunder.leizhen@huawei.com>
On Sat, 8 May 2021, Zhen Lei wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 224ee88fe395 ("Input: add force feedback driver for PID devices")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/hid/usbhid/hid-pidff.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
> index ea126c50acc3..3b4ee21cd811 100644
> --- a/drivers/hid/usbhid/hid-pidff.c
> +++ b/drivers/hid/usbhid/hid-pidff.c
> @@ -1292,6 +1292,7 @@ int hid_pidff_init(struct hid_device *hid)
>
> if (pidff->pool[PID_DEVICE_MANAGED_POOL].value &&
> pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) {
> + error = -EPERM;
> hid_notice(hid,
> "device does not support device managed pool\n");
> goto fail;
Good catch, applied, thank you.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-05-26 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 2:47 [PATCH 1/1] HID: pidff: fix error return code in hid_pidff_init() Zhen Lei
2021-05-26 10:40 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2105261240280.28378@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=anssi.hannula@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dtor@mail.ru \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).