From: Jiri Kosina <jikos@kernel.org>
To: "José Expósito" <jose.exposito89@gmail.com>
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: magicmouse: fix crash when disconnecting Magic Trackpad 2
Date: Wed, 26 May 2021 12:44:37 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2105261244270.28378@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210510062237.319457-1-jose.exposito89@gmail.com>
On Mon, 10 May 2021, José Expósito wrote:
> When the Apple Magic Trackpad 2 is connected over USB it registers four
> hid_device report descriptors, however, the driver only handles the one
> with type HID_TYPE_USBMOUSE and ignores the other three, thus, no driver
> data is attached to them.
>
> When the device is disconnected, the remove callback is called for the
> four hid_device report descriptors, crashing when the driver data is
> NULL.
>
> Check that the driver data is not NULL before using it in the remove
> callback.
Applied, thank you.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-05-26 10:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 15:51 [PATCH] HID: magicmouse: fix crash when disconnecting Magic Trackpad 2 José Expósito
2021-05-10 6:22 ` [PATCH v2] " José Expósito
2021-05-26 10:44 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2105261244270.28378@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jose.exposito89@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).