From: Jiri Kosina <jikos@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+ee6f6e2e68886ca256a8@syzkaller.appspotmail.com,
stable@vger.kernel.org, Claudio Mettler <claudio@ponyfleisch.ch>,
Marek Wyborski <marek.wyborski@emwesoft.com>,
Sean O'Brien <seobrien@chromium.org>
Subject: Re: [PATCH] HID: magicmouse: fix NULL-deref on disconnect
Date: Wed, 26 May 2021 12:51:03 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2105261250560.28378@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210517100430.20509-1-johan@kernel.org>
On Mon, 17 May 2021, Johan Hovold wrote:
> Commit 9d7b18668956 ("HID: magicmouse: add support for Apple Magic
> Trackpad 2") added a sanity check for an Apple trackpad but returned
> success instead of -ENODEV when the check failed. This means that the
> remove callback will dereference the never-initialised driver data
> pointer when the driver is later unbound (e.g. on USB disconnect).
>
> Reported-by: syzbot+ee6f6e2e68886ca256a8@syzkaller.appspotmail.com
> Fixes: 9d7b18668956 ("HID: magicmouse: add support for Apple Magic Trackpad 2")
> Cc: stable@vger.kernel.org # 4.20
> Cc: Claudio Mettler <claudio@ponyfleisch.ch>
> Cc: Marek Wyborski <marek.wyborski@emwesoft.com>
> Cc: Sean O'Brien <seobrien@chromium.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Applied, thanks Johan.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-05-26 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 10:04 [PATCH] HID: magicmouse: fix NULL-deref on disconnect Johan Hovold
2021-05-26 10:51 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2105261250560.28378@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=claudio@ponyfleisch.ch \
--cc=johan@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.wyborski@emwesoft.com \
--cc=seobrien@chromium.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+ee6f6e2e68886ca256a8@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).