From: Jiri Kosina <jikos@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-input@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] HID: input: Add support for Programmable Buttons
Date: Thu, 24 Jun 2021 15:41:30 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2106241541190.18969@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210615214103.1031479-1-linux@weissschuh.net>
On Tue, 15 Jun 2021, Thomas Weißschuh wrote:
> Map them to KEY_MACRO# event codes.
>
> These buttons are defined by HID as follows:
> "The user defines the function of these buttons to control software applications or GUI objects."
>
> This matches the semantics of the KEY_MACRO# input event codes that Linux supports.
>
> Also add support for HID "Named Array" collections.
> Also add hid-debug support for KEY_MACRO#.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>
> ---
>
> v1: https://lore.kernel.org/linux-input/20210519160349.609690-1-linux@weissschuh.net/
>
> v1 -> v2: Only handle the 30 keys known
>
> v2: https://lore.kernel.org/linux-input/20210519174345.614467-1-linux@weissschuh.net/
>
> v2 -> v3:
> * Use hex constants for consistency
> * Validate that the button is part of a "Programmable Buttons" Named Array.
> Otherwise the condition would also apply to "Function Buttons".
> * Ignore non-"Programmable Buttons" buttons.
>
> v3: https://lore.kernel.org/linux-input/20210520084805.685486-1-linux@weissschuh.net/
>
> v3 -> v4:
> * Mention new support for HID "Named Array" collections in commit message.
> * Mention new support KEY_MACRO# in hid-debug.
Applied, thank you.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-06-24 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 21:41 [PATCH v4] HID: input: Add support for Programmable Buttons Thomas Weißschuh
2021-06-24 13:41 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2106241541190.18969@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).