From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3FFC4320A for ; Wed, 28 Jul 2021 09:47:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C838460F9E for ; Wed, 28 Jul 2021 09:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231854AbhG1Jrx (ORCPT ); Wed, 28 Jul 2021 05:47:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:54178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231443AbhG1Jrw (ORCPT ); Wed, 28 Jul 2021 05:47:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 426CE60F9C; Wed, 28 Jul 2021 09:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627465671; bh=6hpI4gRiWIN0fd0eWFY8c/aNxVDe6Fb04bV/5DieHMs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JgaXlVJV2SOl/SVyqvfOTu0cWCNbQrfGWwba3ODmZcza6w2FBsYKR8xlCwRWSymFj GJgz7B2Lcp5HGYOiWPmNc77VyyjkaeOXKKrw86tjUt9PbptZJKDqRnqtaBy0bhqmmB HwsHRYxJL0icYO1q5yXxVxWQrZUPsfLFrLTFH50hhTrx1pe5oGtcZL96IKS2QD8FeM WMON57/gMMQhxFRXYxCaxTM4cyMhACw2MgyOIbIn0QiYkXuAtaBY/YdqX0irVnxKYy 9STYGblZeWjZVL4/w86X0VUEOMjuTwnAUlwaDTOY3qs0HOvq12urkRr1IvDz0uTXWI m5DjaPuorxsQA== Date: Wed, 28 Jul 2021 11:47:48 +0200 (CEST) From: Jiri Kosina To: Michael Zaidman cc: benjamin.tissoires@redhat.com, aaron.jones@ftdichip.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v1] HID: ft260: fix device removal due to USB disconnect In-Reply-To: <20210720144954.5392-1-michael.zaidman@gmail.com> Message-ID: References: <20210720144954.5392-1-michael.zaidman@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jul 2021, Michael Zaidman wrote: > This commit fixes a regression introduced by the commit 82f09a637dd3 > ("HID: ft260: improve error handling of ft260_hid_feature_report_get()") > when upon USB disconnect, the ft260 i2c device is still available within > the /dev folder. Thanks for the fix. Could you please make the changelog a little bit more verbose though? Namely describe the issue in the code the patch is fixing (and how). Thanks, -- Jiri Kosina SUSE Labs