linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] HID fixes
@ 2021-07-30 12:06 Jiri Kosina
  2021-07-30 18:11 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2021-07-30 12:06 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes.

=====
- resume timing fix for intel-ish driver from Ye Xiang
- fix for using incorrect MMIO register in amd_sfh driver from Dylan 
  MacKenzie
- Cintiq 24HDT / 27QHDT regression fix and touch processing fix for Wacom 
  driver from Jason Gerecke
- device removal bugfix for ft260 driver from Michael Zaidman
- other small assorted fixes
=====

Thanks.

----------------------------------------------------------------
Christophe JAILLET (1):
      HID: fix typo in Kconfig

Colin Ian King (1):
      HID: Kconfig: Fix spelling mistake "Uninterruptable" -> "Uninterruptible"

Dylan MacKenzie (1):
      HID: amd_sfh: Use correct MMIO register for DMA address

Haochen Tong (1):
      HID: apple: Add support for Keychron K1 wireless keyboard

Jason Gerecke (2):
      HID: wacom: Re-enable touch by default for Cintiq 24HDT / 27QHDT
      HID: wacom: Skip processing of touches with negative slot values

Luke D. Jones (1):
      HID: asus: Remove check for same LED brightness on set

Michael Zaidman (2):
      HID: ft260: fix format type warning in ft260_word_show()
      HID: ft260: fix device removal due to USB disconnect

Ye Xiang (1):
      HID: intel-ish-hid: use async resume function

 drivers/hid/Kconfig                          |  2 +-
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c       |  2 +-
 drivers/hid/hid-apple.c                      |  2 ++
 drivers/hid/hid-asus.c                       |  3 ---
 drivers/hid/hid-ft260.c                      | 27 +++++++++-----------------
 drivers/hid/intel-ish-hid/ishtp-hid-client.c | 15 +++++++++++++-
 drivers/hid/intel-ish-hid/ishtp-hid.h        |  1 +
 drivers/hid/intel-ish-hid/ishtp/bus.c        | 29 +++++++++++++++++++++-------
 drivers/hid/usbhid/Kconfig                   |  2 +-
 drivers/hid/wacom_wac.c                      |  5 ++++-
 include/linux/intel-ish-client-if.h          |  2 ++
 11 files changed, 57 insertions(+), 33 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2021-07-30 12:06 [GIT PULL] HID fixes Jiri Kosina
@ 2021-07-30 18:11 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2021-07-30 18:11 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Fri, 30 Jul 2021 14:06:35 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8723bc8fb38cf4ff18e23ed31d424ba39e81a7cb

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2021-11-24  7:10 Jiri Kosina
@ 2021-11-24 18:31 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2021-11-24 18:31 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Wed, 24 Nov 2021 08:10:08 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/740bebf42104d2f082514b1545a14056f3b1b56c

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2021-11-24  7:10 Jiri Kosina
  2021-11-24 18:31 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2021-11-24  7:10 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive 5.16-rc fixes for HID subsystem.

=====
- fix for Intel-ISH driver to make sure it gets aoutoloaded only on 
  matching devices and not universally (Thomas Weißschuh)
- fix for Wacom driver reporting invalid contact under certain 
  circumstances (Jason Gerecke)
- probing fix for ft260 dirver (Michael Zaidman)
- fix for generic keycode remapping (Thomas Weißschuh)
- fix for division by zero in hid-magicmouse (Claudia Pellegrino)
- other tiny assorted fixes and new device IDs
=====

Thanks.

----------------------------------------------------------------
Arnd Bergmann (1):
      HID: intel-ish-hid: fix module device-id handling

Claudia Pellegrino (1):
      HID: magicmouse: prevent division by 0 on scroll

Dan Carpenter (1):
      HID: nintendo: unlock on error in joycon_leds_create()

Hans de Goede (1):
      HID: input: Fix parsing of HID_CP_CONSUMER_CONTROL fields

Jason Gerecke (1):
      HID: wacom: Use "Confidence" flag to prevent reporting invalid contacts

Jiri Kosina (1):
      HID: nintendo: eliminate dead datastructures in !CONFIG_NINTENDO_FF case

Michael Zaidman (1):
      HID: ft260: fix i2c probing for hwmon devices

Ondrej Zary (1):
      HID: multitouch: Fix Iiyama ProLite T1931SAW (0eef:0001 again!)

Thomas Weißschuh (8):
      HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()
      HID: intel-ish-hid: use constants for modaliases
      HID: intel-ish-hid: fw-loader: only load for matching devices
      HID: intel-ish-hid: hid-client: only load for matching devices
      platform/chrome: chros_ec_ishtp: only load for matching devices
      platform/x86: isthp_eclite: only load for matching devices
      mod_devicetable: fix kdocs for ishtp_device_id
      HID: input: set usage type to key on keycode remap

Trevor Davenport (1):
      HID: Ignore battery for Elan touchscreen on HP Envy X360 15-eu0xxx

Vihas Mak (1):
      HID: thrustmaster: fix sparse warnings

Vinícius Angiolucci Reis (1):
      Revert "HID: hid-asus.c: Maps key 0x35 (display off) to KEY_SCREENLOCK"

 drivers/hid/hid-asus.c                       |  2 +-
 drivers/hid/hid-ft260.c                      | 11 +++++------
 drivers/hid/hid-ids.h                        |  1 +
 drivers/hid/hid-input.c                      |  8 +++++---
 drivers/hid/hid-magicmouse.c                 |  7 +++++--
 drivers/hid/hid-multitouch.c                 |  5 +++++
 drivers/hid/hid-nintendo.c                   | 13 +++++++++----
 drivers/hid/hid-thrustmaster.c               |  6 +++---
 drivers/hid/intel-ish-hid/ishtp-fw-loader.c  | 14 ++++++++------
 drivers/hid/intel-ish-hid/ishtp-hid-client.c | 14 ++++++++------
 drivers/hid/intel-ish-hid/ishtp/bus.c        |  6 +++---
 drivers/hid/wacom_wac.c                      |  8 +++++++-
 drivers/hid/wacom_wac.h                      |  1 +
 drivers/platform/chrome/cros_ec_ishtp.c      | 14 ++++++++------
 drivers/platform/x86/intel/ishtp_eclite.c    | 14 ++++++++------
 include/linux/intel-ish-client-if.h          |  4 ++--
 include/linux/mod_devicetable.h              | 14 ++++++++++++++
 scripts/mod/devicetable-offsets.c            |  3 +++
 scripts/mod/file2alias.c                     | 24 ++++++++++++++++++++++++
 19 files changed, 120 insertions(+), 49 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2021-09-27 13:54 Jiri Kosina
@ 2021-09-27 17:25 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2021-09-27 17:25 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, Benjamin Tissoires, linux-kernel

The pull request you sent on Mon, 27 Sep 2021 15:54:34 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/42d43c92fc577dca59ed74aec7868abec8d6ca6e

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2021-09-27 13:54 Jiri Kosina
  2021-09-27 17:25 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2021-09-27 13:54 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Benjamin Tissoires, linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes.

=====
- NULL pointer dereference fixes in amd_sfh driver (Basavaraj Natikar, 
  Evgeny Novikov)
- data processing fix for hid-u2fzero (Andrej Shadura)
- fix for out-of-bounds write in hid-betop (F.A.Sulaiman)
- new device IDs / device-specific quirks
=====

Thanks.

----------------------------------------------------------------
Andrej Shadura (1):
      HID: u2fzero: ignore incomplete packets without data

Basavaraj Natikar (1):
      HID: amd_sfh: Fix potential NULL pointer dereference

Evgeny Novikov (1):
      HID: amd_sfh: Fix potential NULL pointer dereference

F.A.Sulaiman (1):
      HID: betop: fix slab-out-of-bounds Write in betop_probe

Joshua-Dickens (1):
      HID: wacom: Add new Intuos BT (CTL-4100WL/CTL-6100WL) device IDs

Mizuho Mori (1):
      HID: apple: Fix logical maximum and usage maximum of Magic Keyboard JIS

 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c |  8 ++++----
 drivers/hid/hid-apple.c                |  7 +++++++
 drivers/hid/hid-betopff.c              | 13 ++++++++++---
 drivers/hid/hid-u2fzero.c              |  4 +++-
 drivers/hid/wacom_wac.c                |  8 ++++++++
 5 files changed, 32 insertions(+), 8 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2021-06-01 21:58 Jiri Kosina
@ 2021-06-02  3:58 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2021-06-02  3:58 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, Benjamin Tissoires, linux-kernel

The pull request you sent on Tue, 1 Jun 2021 23:58:54 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/231bc539066760aaa44d46818c85b14ca2f56d9f

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2021-06-01 21:58 Jiri Kosina
  2021-06-02  3:58 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2021-06-01 21:58 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Benjamin Tissoires, linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive fixes for HID subsystem.

=====
- memory leak fix in usbhid from Anirudh Rayabharam
- additions for a few new recognized generic key IDs from Dmitry Torokhov
- Asus T101HA and Dell K15A quirks from Hans de Goede
- memory leak fix in amd_sfh from Basavaraj Natikar
- Win8 compatibility and Stylus fixes in multitouch driver from Ahelenia 
  Ziemiańska
- NULL pointer dereference fix in hid-magicmouse from Johan Hovold
- assorted other small fixes and device ID additions
=====

Thanks.

----------------------------------------------------------------
Ahelenia Ziemiańska (2):
      HID: multitouch: require Finger field to mark Win8 reports as MT
      HID: multitouch: set Stylus suffix for Stylus-application devices, too

Anirudh Rayabharam (1):
      HID: usbhid: fix info leak in hid_submit_ctrl

Arnd Bergmann (1):
      HID: i2c-hid: fix format string mismatch

Basavaraj Natikar (2):
      HID: amd_sfh: Use devm_kzalloc() instead of kzalloc()
      HID: amd_sfh: Fix memory leak in amd_sfh_work

Benjamin Moody (1):
      HID: semitek: new driver for GK6X series keyboards

Bixuan Cui (1):
      HID: gt683r: add missing MODULE_DEVICE_TABLE

Dmitry Torokhov (2):
      HID: hid-input: add mapping for emoji picker key
      HID: hid-debug: recognize KEY_ASSISTANT and KEY_KBD_LAYOUT_NEXT

Hamza Mahfooz (1):
      HID: remove the unnecessary redefinition of a macro

Hans de Goede (4):
      HID: quirks: Add HID_QUIRK_NO_INIT_REPORTS quirk for Dell K15A keyboard-dock
      HID: core: Remove extraneous empty line before EXPORT_SYMBOL_GPL(hid_check_keys_pressed)
      HID: multitouch: Disable event reporting on suspend on the Asus T101HA touchpad
      HID: asus: Cleanup Asus T101HA keyboard-dock handling

Johan Hovold (1):
      HID: magicmouse: fix NULL-deref on disconnect

Johnny Chuang (1):
      HID: i2c-hid: Skip ELAN power-on command after reset

José Expósito (1):
      HID: magicmouse: fix crash when disconnecting Magic Trackpad 2

Luke D Jones (2):
      HID: asus: Filter keyboard EC for old ROG keyboard
      HID: asus: filter G713/G733 key event to prevent shutdown

Mark Bolhuis (1):
      HID: Add BUS_VIRTUAL to hid_connect logging

Mateusz Jończyk (1):
      HID: a4tech: use A4_2WHEEL_MOUSE_HACK_B8 for A4TECH NB-95

Maximilian Luz (1):
      HID: surface-hid: Fix integer endian conversion

Michael Zaidman (2):
      HID: ft260: check data size in ft260_smbus_write()
      HID: ft260: improve error handling of ft260_hid_feature_report_get()

Nirenjan Krishnan (1):
      HID: quirks: Set INCREMENT_USAGE_ON_DUPLICATE for Saitek X65

Saeed Mirzamohammadi (1):
      HID: quirks: Add quirk for Lenovo optical mouse

Srinivas Pandruvada (2):
      HID: hid-sensor-hub: Return error for hid_set_field() failure
      HID: hid-sensor-custom: Process failure of sensor_hub_set_feature()

Tom Rix (1):
      HID: logitech-hidpp: initialize level variable

Wei Yongjun (1):
      HID: thrustmaster: fix return value check in thrustmaster_probe()

Ye Xiang (1):
      HID: intel-ish-hid: ipc: Add Alder Lake device IDs

Zhen Lei (1):
      HID: pidff: fix error return code in hid_pidff_init()

 drivers/hid/Kconfig                        | 19 ++++++++++--
 drivers/hid/Makefile                       |  1 +
 drivers/hid/amd-sfh-hid/amd_sfh_client.c   | 19 ++++++------
 drivers/hid/amd-sfh-hid/amd_sfh_hid.c      |  3 --
 drivers/hid/hid-a4tech.c                   |  2 ++
 drivers/hid/hid-asus.c                     | 32 +++++++++++++--------
 drivers/hid/hid-core.c                     |  4 ++-
 drivers/hid/hid-debug.c                    |  3 ++
 drivers/hid/hid-ft260.c                    | 29 ++++++++++---------
 drivers/hid/hid-gt683r.c                   |  1 +
 drivers/hid/hid-ids.h                      |  9 ++++--
 drivers/hid/hid-input.c                    |  3 ++
 drivers/hid/hid-logitech-hidpp.c           |  1 +
 drivers/hid/hid-magicmouse.c               |  7 +++--
 drivers/hid/hid-multitouch.c               | 46 ++++++++++++++++++++++++------
 drivers/hid/hid-quirks.c                   |  4 +++
 drivers/hid/hid-semitek.c                  | 40 ++++++++++++++++++++++++++
 drivers/hid/hid-sensor-custom.c            |  8 ++++--
 drivers/hid/hid-sensor-hub.c               | 13 ++++++---
 drivers/hid/hid-thrustmaster.c             |  2 +-
 drivers/hid/i2c-hid/i2c-hid-core.c         | 13 +++++++--
 drivers/hid/intel-ish-hid/ipc/hw-ish.h     |  2 ++
 drivers/hid/intel-ish-hid/ipc/pci-ish.c    |  2 ++
 drivers/hid/surface-hid/surface_hid_core.c |  6 ++--
 drivers/hid/usbhid/hid-core.c              |  2 +-
 drivers/hid/usbhid/hid-pidff.c             |  1 +
 include/linux/hid.h                        |  3 +-
 include/uapi/linux/input-event-codes.h     |  1 +
 28 files changed, 206 insertions(+), 70 deletions(-)
 create mode 100644 drivers/hid/hid-semitek.c

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2021-04-15 13:51 Jiri Kosina
@ 2021-04-15 18:15 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2021-04-15 18:15 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Thu, 15 Apr 2021 15:51:04 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e7e3a53b30d6e6f54eef81400ddfe8b32224b77f

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2021-04-15 13:51 Jiri Kosina
  2021-04-15 18:15 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2021-04-15 13:51 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID fixes. I wanted to send them earlier than for the last -rc, 
but then unfortunately many things interfered. The changes are all 
device/driver specific fixes.

=====
- EV_KEY and EV_ABS regression fix for Wacom from Ping Cheng
- BIOS-specific quirk to fix some of the AMD_SFH-based systems, from Hans 
  de Goede
- other small error handling fixes and device ID additions
=====

Thanks.

----------------------------------------------------------------
Douglas Gilbert (1):
      HID cp2112: fix support for multiple gpiochips

Hans de Goede (3):
      AMD_SFH: Removed unused activecontrolstatus member from the amd_mp2_dev struct
      AMD_SFH: Add sensor_mask module parameter
      AMD_SFH: Add DMI quirk table for BIOS-es which don't set the activestatus bits

Jia-Ju Bai (1):
      HID: alps: fix error return code in alps_input_configured()

Jiapeng Zhong (1):
      HID: wacom: Assign boolean values to a bool variable

Luke D Jones (1):
      HID: asus: Add support for 2021 ASUS N-Key keyboard

Ping Cheng (1):
      HID: wacom: set EV_KEY and EV_ABS only for non-HID_GENERIC type of devices

Shou-Chieh Hsu (1):
      HID: google: add don USB id

 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 40 +++++++++++++++++++++++++++++++---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.h |  1 -
 drivers/hid/hid-alps.c                 |  1 +
 drivers/hid/hid-asus.c                 |  3 +++
 drivers/hid/hid-cp2112.c               | 22 +++++++++----------
 drivers/hid/hid-google-hammer.c        |  2 ++
 drivers/hid/hid-ids.h                  |  2 ++
 drivers/hid/wacom_wac.c                |  8 +++----
 8 files changed, 59 insertions(+), 20 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2021-01-28  8:38 Jiri Kosina
@ 2021-01-28 18:16 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2021-01-28 18:16 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Thu, 28 Jan 2021 09:38:19 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/25221c99c593bf888bd8faa67ca25b40f046e9f8

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2021-01-28  8:38 Jiri Kosina
  2021-01-28 18:16 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2021-01-28  8:38 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receve the following fixes for HID subsystem:

=====
- NULL pointer dereference regression fix for Wacom driver (Jason Gerecke)
- functional regression fix for pam handling on some Elan and Synaptics  
  touchpads (Kai-Heng Feng)
=====

Thanks.

----------------------------------------------------------------
Jason Gerecke (1):
      HID: wacom: Correct NULL dereference on AES pen proximity

Kai-Heng Feng (1):
      HID: multitouch: Apply MT_QUIRK_CONFIDENCE quirk for multi-input devices

 drivers/hid/hid-multitouch.c | 3 ++-
 drivers/hid/wacom_sys.c      | 7 ++++---
 drivers/hid/wacom_wac.h      | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2021-01-14 12:33 Jiri Kosina
@ 2021-01-14 21:55 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2021-01-14 21:55 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Thu, 14 Jan 2021 13:33:57 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/2bbe17ae87938ca44756741ec77e3be76a4a0ea0

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2021-01-14 12:33 Jiri Kosina
  2021-01-14 21:55 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2021-01-14 12:33 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive fixes for HID subsystem;

=====
- memory leak fix for Wacom driver (Ping Cheng)
- various trivial small fixes, cleanups and device ID additions
=====

Thanks.

----------------------------------------------------------------
Arnd Bergmann (2):
      HID: sfh: fix address space confusion
      HID: sony: select CONFIG_CRC32

Filipe Laíns (1):
      HID: logitech-dj: add the G602 receiver

Kai-Heng Feng (1):
      HID: multitouch: Enable multi-input for Synaptics pointstick/touchpad device

Nicholas Miell (1):
      HID: logitech-hidpp: Add product ID for MX Ergo in Bluetooth mode

Ping Cheng (1):
      HID: wacom: Fix memory leakage caused by kfifo_alloc

Seth Miller (1):
      HID: Ignore battery for Elan touchscreen on ASUS UX550

Tom Rix (2):
      HID: uclogic: remove h from printk format specifier
      HID: wiimote: remove h from printk format specifier

 drivers/hid/Kconfig                      |  1 +
 drivers/hid/amd-sfh-hid/amd_sfh_client.c |  8 ++++----
 drivers/hid/amd-sfh-hid/amd_sfh_hid.h    |  2 +-
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c   |  2 +-
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.h   |  2 +-
 drivers/hid/hid-ids.h                    |  1 +
 drivers/hid/hid-input.c                  |  2 ++
 drivers/hid/hid-logitech-dj.c            |  4 ++++
 drivers/hid/hid-logitech-hidpp.c         |  2 ++
 drivers/hid/hid-multitouch.c             |  4 ++++
 drivers/hid/hid-uclogic-params.c         |  2 +-
 drivers/hid/hid-wiimote-core.c           |  2 +-
 drivers/hid/wacom_sys.c                  | 35 +++++++++++++++++++++++++++++---
 13 files changed, 55 insertions(+), 12 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-11-22 21:18 Jiri Kosina
@ 2020-11-22 22:40 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2020-11-22 22:40 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, Benjamin Tissoires, linux-kernel

The pull request you sent on Sun, 22 Nov 2020 22:18:19 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d5530d82efc8631beff20480b1168b1c44294fe1

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2020-11-22 21:18 Jiri Kosina
  2020-11-22 22:40 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2020-11-22 21:18 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Benjamin Tissoires, linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus


to receive HID subsystem fixes; namely:

=====
- Various functionality / regression fixes for Logitech devices from Hans 
  de Goede
- Fix for (recently added) GPIO support in mcp2221 driver from Lars 
  Povlsen
- Power management handling fix/quirk in i2c-hid driver for certain BIOSes 
  that have strange aproach to power-cycle from Hans de Goede
- a few device ID additions and device-specific quirks
=====

Thanks.

----------------------------------------------------------------
Chris Ye (1):
      HID: add HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE for Gamevice devices

Frank Yang (1):
      HID: cypress: Support Varmilo Keyboards' media hotkeys

Hans de Goede (7):
      HID: ite: Replace ABS_MISC 120/121 events with touchpad on/off keypresses
      HID: i2c-hid: Put ACPI enumerated devices in D3 on shutdown
      HID: logitech-dj: Handle quad/bluetooth keyboards with a builtin trackpad
      HID: logitech-hidpp: Add HIDPP_CONSUMER_VENDOR_KEYS quirk for the Dinovo Edge
      HID: Add Logitech Dinovo Edge battery quirk
      HID: logitech-dj: Fix an error in mse_bluetooth_descriptor
      HID: logitech-dj: Fix Dinovo Mini when paired with a MX5x00 receiver

Harry Cutts (1):
      HID: logitech-hidpp: Add PID for MX Anywhere 2

Jiri Kosina (1):
      HID: add support for Sega Saturn

Lars Povlsen (1):
      HID: mcp2221: Fix GPIO output handling

Martijn van de Streek (1):
      HID: uclogic: Add ID for Trust Flex Design Tablet

Pablo Ceballos (1):
      HID: hid-sensor-hub: Fix issue with devices with no report ID

 drivers/hid/hid-cypress.c          | 44 +++++++++++++++++++++++----
 drivers/hid/hid-ids.h              |  9 ++++++
 drivers/hid/hid-input.c            |  3 ++
 drivers/hid/hid-ite.c              | 61 +++++++++++++++++++++++++++++++++++++-
 drivers/hid/hid-logitech-dj.c      | 22 +++++++++++++-
 drivers/hid/hid-logitech-hidpp.c   | 32 ++++++++++++++++++++
 drivers/hid/hid-mcp2221.c          | 48 ++++++++++++++++++++++++------
 drivers/hid/hid-quirks.c           |  5 ++++
 drivers/hid/hid-sensor-hub.c       |  3 +-
 drivers/hid/hid-uclogic-core.c     |  2 ++
 drivers/hid/hid-uclogic-params.c   |  2 ++
 drivers/hid/i2c-hid/i2c-hid-core.c |  9 ++++++
 12 files changed, 223 insertions(+), 17 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-09-02 18:58 Jiri Kosina
@ 2020-09-02 20:08 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2020-09-02 20:08 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, Benjamin Tissoires, linux-kernel

The pull request you sent on Wed, 2 Sep 2020 20:58:13 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/fc3abb53250a90ba2150eebd182137c136f4d25a

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2020-09-02 18:58 Jiri Kosina
  2020-09-02 20:08 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2020-09-02 18:58 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Benjamin Tissoires, linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes. Most importantly:

=====
- Data sanitization and validtion fixes for report descriptor parser from 
  Marc Zyngier
- memory leak fix for hid-elan driver from Dinghao Liu
- two device-specific quirks
=====

Thanks.

----------------------------------------------------------------
Dinghao Liu (1):
      HID: elan: Fix memleak in elan_input_configured

Marc Zyngier (2):
      HID: core: Correctly handle ReportSize being zero
      HID: core: Sanitize event code and type when mapping input

Nicholas Miell (1):
      HID: microsoft: Add rumble support for the 8bitdo SN30 Pro+ controller

Nirenjan Krishnan (1):
      HID: quirks: Set INCREMENT_USAGE_ON_DUPLICATE for all Saitek X52 devices

 drivers/hid/hid-core.c       | 15 +++++++++++++--
 drivers/hid/hid-elan.c       |  2 ++
 drivers/hid/hid-ids.h        |  3 +++
 drivers/hid/hid-input.c      |  4 ++++
 drivers/hid/hid-microsoft.c  |  2 ++
 drivers/hid/hid-multitouch.c |  2 ++
 drivers/hid/hid-quirks.c     |  2 ++
 include/linux/hid.h          | 42 +++++++++++++++++++++++++++++-------------
 8 files changed, 57 insertions(+), 15 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-08-25  8:14 Jiri Kosina
@ 2020-08-25 19:16 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2020-08-25 19:16 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Tue, 25 Aug 2020 10:14:56 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b9aa527ae38ba0ee998ced376b040fc92b0a2c03

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2020-08-25  8:14 Jiri Kosina
  2020-08-25 19:16 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2020-08-25  8:14 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes. Highlights:

=====
- regression fix / revert of a commit that intended to reduce probing 
  delay by ~50ms, but introduced a race that causes quite a few devices
  not to enumerate, or get stuck on first IRQ
- buffer overflow fix in hiddev, from Peilin Ye
=====

Thanks.

----------------------------------------------------------------
Hans de Goede (1):
      HID: i2c-hid: Always sleep 60ms after I2C_HID_PWR_ON commands

Jiri Kosina (1):
      Revert "HID: usbhid: do not sleep when opening device"

Peilin Ye (1):
      HID: hiddev: Fix slab-out-of-bounds write in hiddev_ioctl_usage()

Rikard Falkeborn (2):
      HID: cougar: Constify cougar_id_table
      HID: macally: Constify macally_id_table

Sebastian Parschauer (1):
      HID: quirks: Always poll three more Lenovo PixArt mice

 drivers/hid/hid-cougar.c           |  2 +-
 drivers/hid/hid-ids.h              |  3 +++
 drivers/hid/hid-macally.c          |  2 +-
 drivers/hid/hid-quirks.c           |  3 +++
 drivers/hid/i2c-hid/i2c-hid-core.c | 22 +++++++++-------
 drivers/hid/usbhid/hid-core.c      | 53 +++++++++++++++++---------------------
 drivers/hid/usbhid/hiddev.c        |  4 +++
 drivers/hid/usbhid/usbhid.h        |  2 --
 8 files changed, 49 insertions(+), 42 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-07-17 12:01 Jiri Kosina
@ 2020-07-17 17:40 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2020-07-17 17:40 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Fri, 17 Jul 2020 14:01:54 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/60541fb62438c6abd821874cfc3a24d280d1cbbf

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2020-07-17 12:01 Jiri Kosina
  2020-07-17 17:40 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2020-07-17 12:01 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes.

=====
- linked list race condition fix in hid-steam driver from Rodrigo Rivas 
  Costa
- assorted deviceID-specific quirks and other small cosmetic cleanups
=====

Thanks.

----------------------------------------------------------------
Caiyuan Xie (1):
      HID: alps: support devices with report id 2

David Rheinsberg (1):
      MAINTAINERS: update uhid and hid-wiimote entry

Dmitry Torokhov (1):
      HID: magicmouse: do not set up autorepeat

Federico Ricchiuto (1):
      HID: i2c-hid: add Mediacom FlexBook edge13 to descriptor override

Hans de Goede (1):
      HID: apple: Disable Fn-key key-re-mapping on clone keyboards

James Hilliard (1):
      HID: quirks: Ignore Simply Automated UPB PIM

Maciej S. Szmigiero (1):
      HID: logitech-hidpp: avoid repeated "multiplier = " log messages

Mazin Rezk (1):
      HID: logitech: Use HIDPP_RECEIVER_INDEX instead of 0xff

Rodrigo Rivas Costa (1):
      HID: steam: fixes race in handling device list.

Sebastian Parschauer (1):
      HID: quirks: Always poll Obins Anne Pro 2 keyboard

 MAINTAINERS                              |  4 ++--
 drivers/hid/hid-alps.c                   |  2 ++
 drivers/hid/hid-apple.c                  | 18 ++++++++++++++++++
 drivers/hid/hid-ids.h                    |  3 +++
 drivers/hid/hid-logitech-dj.c            |  6 +++---
 drivers/hid/hid-logitech-hidpp.c         |  2 +-
 drivers/hid/hid-magicmouse.c             |  6 ++++++
 drivers/hid/hid-quirks.c                 |  2 ++
 drivers/hid/hid-steam.c                  |  6 ++++--
 drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c |  8 ++++++++
 10 files changed, 49 insertions(+), 8 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-03-17 13:41 Jiri Kosina
@ 2020-03-17 17:10 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2020-03-17 17:10 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Tue, 17 Mar 2020 14:41:37 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/ac309e7744bee222df6de0122facaf2d9706fa70

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2020-03-17 13:41 Jiri Kosina
  2020-03-17 17:10 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2020-03-17 13:41 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes.

=====
- string buffer formatting fixes in picolcd and sensor drivers, from 
  Takashi Iwai
- two new device IDs from Chen-Tsung Hsieh and Tony Fischetti
=====

Thanks.

----------------------------------------------------------------
Chen-Tsung Hsieh (1):
      HID: google: add moonball USB id

Takashi Iwai (2):
      HID: hid-picolcd_fb: Use scnprintf() for avoiding potential buffer overflow
      HID: hid-sensor-custom: Use scnprintf() for avoiding potential buffer overflow

Tony Fischetti (1):
      HID: add ALWAYS_POLL quirk to lenovo pixart mouse

 drivers/hid/hid-google-hammer.c | 2 ++
 drivers/hid/hid-ids.h           | 2 ++
 drivers/hid/hid-picolcd_fb.c    | 4 ++--
 drivers/hid/hid-quirks.c        | 1 +
 drivers/hid/hid-sensor-custom.c | 6 +++---
 5 files changed, 10 insertions(+), 5 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-02-27 14:46 Jiri Kosina
@ 2020-02-27 19:40 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2020-02-27 19:40 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, Benjamin Tissoires, linux-kernel

The pull request you sent on Thu, 27 Feb 2020 15:46:10 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/278de45e145bedff90072fb47bafdde8393f6a80

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2020-02-27 14:46 Jiri Kosina
  2020-02-27 19:40 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2020-02-27 14:46 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Benjamin Tissoires, linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes for 5.6.

=====
- syzkaller-reported error handling fixes in various drivers, from various 
  people
- increase of HID report buffer size to 8K, which is apparently needed
  by certain modern devices
- a few new device-ID-specific fixes / quirks
- battering charging status reporting fix in logitech-hidpp, from Filipe 
  Laíns
=====

Thanks.

----------------------------------------------------------------
Christophe JAILLET (1):
      HID: alps: Fix an error handling path in 'alps_input_configured()'

Filipe Laíns (1):
      HID: logitech-hidpp: BatteryVoltage: only read chargeStatus if extPower is active

Hanno Zulla (3):
      HID: hid-bigbenff: fix general protection fault caused by double kfree
      HID: hid-bigbenff: call hid_hw_stop() in case of error
      HID: hid-bigbenff: fix race condition for scheduled work during removal

Hans de Goede (1):
      HID: ite: Only bind to keyboard USB interface on Acer SW5-012 keyboard dock

Johan Korsnes (2):
      HID: core: fix off-by-one memset in hid_report_raw_event()
      HID: core: increase HID report buffer size to 8KiB

Kai-Heng Feng (1):
      HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override

Mansour Behabadi (1):
      HID: apple: Add support for recent firmware on Magic Keyboards

dan.carpenter@oracle.com (1):
      HID: hiddev: Fix race in in hiddev_disconnect()

 drivers/hid/hid-alps.c                   |  2 +-
 drivers/hid/hid-apple.c                  |  3 ++-
 drivers/hid/hid-bigbenff.c               | 31 +++++++++++++++++------
 drivers/hid/hid-core.c                   |  4 ++-
 drivers/hid/hid-ite.c                    |  5 ++--
 drivers/hid/hid-logitech-hidpp.c         | 43 ++++++++++++++++----------------
 drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c |  8 ++++++
 drivers/hid/usbhid/hiddev.c              |  2 +-
 include/linux/hid.h                      |  2 +-
 9 files changed, 64 insertions(+), 36 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-01-09 23:41         ` Linus Torvalds
@ 2020-01-10 14:31           ` Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2020-01-10 14:31 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Marcel Holtmann, Dmitry Torokhov, Linux Kernel Mailing List,
	Benjamin Tissoires

On Thu, 9 Jan 2020, Linus Torvalds wrote:

> > Now, good source code presumably notices EPOLLERR and handles it. So
> > it _shouldn't_ matter what the kernel does if an error occurs. I
> > haven't checked what people _actually_ do, tnough. I worry sometimes
> > that user space just looks at EPOLLIN sees it not being set, and gets
> > stuck in a busy loop polling in case of errors.
> 
> Googling around for it, I find this, for example:
> 
>     https://github.com/scylladb/seastar/issues/309
> 
> and yes, I think that's technically a user space bug, but it's very
> much an example of this: they expect to get errors through read() or
> write() calls, and get confused when poll() does not say that the fd
> is readable or writable.
> 
> I don't know how common this is, but it didn't take a _lot_ of
> googling for me to find that one..

Right, I think it's quite a convicing argument, and the issue is rather 
easy to avoid. I'll fix that up in the patch and send a fixup pull request 
to you later today.

Marcel, please speak up if you have other plans.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-01-09 23:36       ` Linus Torvalds
@ 2020-01-09 23:41         ` Linus Torvalds
  2020-01-10 14:31           ` Jiri Kosina
  0 siblings, 1 reply; 73+ messages in thread
From: Linus Torvalds @ 2020-01-09 23:41 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Marcel Holtmann, Dmitry Torokhov, Linux Kernel Mailing List,
	Benjamin Tissoires

On Thu, Jan 9, 2020 at 3:36 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Now, good source code presumably notices EPOLLERR and handles it. So
> it _shouldn't_ matter what the kernel does if an error occurs. I
> haven't checked what people _actually_ do, tnough. I worry sometimes
> that user space just looks at EPOLLIN sees it not being set, and gets
> stuck in a busy loop polling in case of errors.

Googling around for it, I find this, for example:

    https://github.com/scylladb/seastar/issues/309

and yes, I think that's technically a user space bug, but it's very
much an example of this: they expect to get errors through read() or
write() calls, and get confused when poll() does not say that the fd
is readable or writable.

I don't know how common this is, but it didn't take a _lot_ of
googling for me to find that one..

           Linus

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-01-09 20:38     ` Jiri Kosina
@ 2020-01-09 23:36       ` Linus Torvalds
  2020-01-09 23:41         ` Linus Torvalds
  0 siblings, 1 reply; 73+ messages in thread
From: Linus Torvalds @ 2020-01-09 23:36 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Marcel Holtmann, Dmitry Torokhov, Linux Kernel Mailing List,
	Benjamin Tissoires

On Thu, Jan 9, 2020 at 12:38 PM Jiri Kosina <jikos@kernel.org> wrote:
>
> From: Jiri Kosina <jkosina@suse.cz>
> Subject: [PATCH] HID: hidraw, uhid: Always report EPOLLOUT

This looks fine, and certainly fixes the immediate problem.

However, this part could still be maybe be improved on:

>  static __poll_t hidraw_poll(struct file *file, poll_table *wait)
>  {
>         struct hidraw_list *list = file->private_data;
> +       __poll_t mask = EPOLLOUT | EPOLLWRNORM; /* hidraw is always writable */
>
>         poll_wait(file, &list->hidraw->wait, wait);
>         if (list->head != list->tail)
> -               return EPOLLIN | EPOLLRDNORM;
> +               mask |= EPOLLIN | EPOLLRDNORM;
>         if (!list->hidraw->exist)
>                 return EPOLLERR | EPOLLHUP;
> -       return EPOLLOUT | EPOLLWRNORM;
> +       return mask;
>  }

Notice the error condition.

I didn't actually _check_ what happens for errors, but *usually* error
conditions mean that

 (a) if there is data to be read, that is done before the error anyway

 (b) that even if there isn't data, the thing is "readable" and
"writable" in the sense that the op will return immediately (with an
error)

 (c) and most importantly - people may not be actually waiting for
EPOLLERR / EPOLLHUP at all.

Now, for "select()" we actually always turn EPOLLERR into "it's
readable _and_ writable". So if a user program uses "select()" to poll
for something, it will see it as being ready for IO in the error
condition.

But if somebody actually uses poll(), and asks for "let me know when
it is either readable or writable", look at what  happens above if
there is a pending error.

You'll basically tell the user that it's neither readable nor
writable, even if you otherwise would have set "EPOLLIN" in the mask.

So at a minimum, please do

          if (!list->hidraw->exist)
                  mask |= EPOLLERR | EPOLLHUP;

but quite possibly it may be a good idea to consider error conditions
to also mean EPOLLIN | EPOLLOUT, since _presumably_ that error will
also cause read/write to return immediately.

But again, I didn't actually verify that last part.

The exact semantics of EPOLLERR and EPOLLHUP really aren't 100% clear.
Should they set EPOLLIN and EPOLLOUT too - there may not be any data,
but at least a read or write won't block? Maybe? So that last
suggestion is questionable, but doing the "mask |=" part really is
unquestionably a better idea, since at least you don't want an error
to _hide_ existing data that is readable.

Now, good source code presumably notices EPOLLERR and handles it. So
it _shouldn't_ matter what the kernel does if an error occurs. I
haven't checked what people _actually_ do, tnough. I worry sometimes
that user space just looks at EPOLLIN sees it not being set, and gets
stuck in a busy loop polling in case of errors.

And since errors presumably don't actually happen much in real life,
it might not get a lot of coverage.

                 Linus

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-01-09 19:37   ` Jiri Kosina
@ 2020-01-09 20:38     ` Jiri Kosina
  2020-01-09 23:36       ` Linus Torvalds
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2020-01-09 20:38 UTC (permalink / raw)
  To: Linus Torvalds, Marcel Holtmann
  Cc: Dmitry Torokhov, Linux Kernel Mailing List, Benjamin Tissoires

On Thu, 9 Jan 2020, Jiri Kosina wrote:

> Marcel, will you please send me fixup ASAP? 

Marcel, if you don't insist on fixing this in some other way, I'll push 
something along the lines of patch below to Linus shortly.




From: Jiri Kosina <jkosina@suse.cz>
Subject: [PATCH] HID: hidraw, uhid: Always report EPOLLOUT

hidraw and uhid device nodes are always available for writing so we should 
always report EPOLLOUT and EPOLLWRNORM bits, not only in the cases when 
there is nothing to read.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Fixes: be54e7461ffdc ("HID: uhid: Fix returning EPOLLOUT from uhid_char_poll")
Fixes: 9f3b61dc1dd7b ("HID: hidraw: Fix returning EPOLLOUT from hidraw_poll")
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 drivers/hid/hidraw.c | 5 +++--
 drivers/hid/uhid.c   | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index f61f2123a755..90265c9fa8eb 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -249,13 +249,14 @@ static ssize_t hidraw_get_report(struct file *file, char __user *buffer, size_t
 static __poll_t hidraw_poll(struct file *file, poll_table *wait)
 {
 	struct hidraw_list *list = file->private_data;
+	__poll_t mask = EPOLLOUT | EPOLLWRNORM; /* hidraw is always writable */
 
 	poll_wait(file, &list->hidraw->wait, wait);
 	if (list->head != list->tail)
-		return EPOLLIN | EPOLLRDNORM;
+		mask |= EPOLLIN | EPOLLRDNORM;
 	if (!list->hidraw->exist)
 		return EPOLLERR | EPOLLHUP;
-	return EPOLLOUT | EPOLLWRNORM;
+	return mask;
 }
 
 static int hidraw_open(struct inode *inode, struct file *file)
diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
index 935c3d0a3b63..8fe3efcb8327 100644
--- a/drivers/hid/uhid.c
+++ b/drivers/hid/uhid.c
@@ -766,13 +766,14 @@ static ssize_t uhid_char_write(struct file *file, const char __user *buffer,
 static __poll_t uhid_char_poll(struct file *file, poll_table *wait)
 {
 	struct uhid_device *uhid = file->private_data;
+	__poll_t mask = EPOLLOUT | EPOLLWRNORM; /* uhid is always writable */
 
 	poll_wait(file, &uhid->waitq, wait);
 
 	if (uhid->head != uhid->tail)
-		return EPOLLIN | EPOLLRDNORM;
+		mask |= EPOLLIN | EPOLLRDNORM;
 
-	return EPOLLOUT | EPOLLWRNORM;
+	return mask;
 }
 
 static const struct file_operations uhid_fops = {

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-01-09 19:14 ` Linus Torvalds
  2020-01-09 19:25   ` Dmitry Torokhov
@ 2020-01-09 19:37   ` Jiri Kosina
  2020-01-09 20:38     ` Jiri Kosina
  1 sibling, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2020-01-09 19:37 UTC (permalink / raw)
  To: Linus Torvalds, Marcel Holtmann
  Cc: Dmitry Torokhov, Linux Kernel Mailing List, Benjamin Tissoires

On Thu, 9 Jan 2020, Linus Torvalds wrote:

> I expect to see a fix, and I expect people to start thinking about it.
> And Marcel, since you were told it was buggy once, why didn't you then
> inform Jiri that you had sent *him* the same buggy code? How many
> other people have you sent that buggy patch to without then informing
> them that it was completely bogus?

Hm, right, the bug in this patch indeed escaped my attention (also I have 
not been aware of this being buggy in uinput before either), thanks for 
spotting this.

Marcel, will you please send me fixup ASAP? 

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-01-09 19:14 ` Linus Torvalds
@ 2020-01-09 19:25   ` Dmitry Torokhov
  2020-01-09 19:37   ` Jiri Kosina
  1 sibling, 0 replies; 73+ messages in thread
From: Dmitry Torokhov @ 2020-01-09 19:25 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Jiri Kosina, Marcel Holtmann, Linux Kernel Mailing List,
	Benjamin Tissoires

Hi Linus,

On Thu, Jan 09, 2020 at 11:14:22AM -0800, Linus Torvalds wrote:
> See
> 
>     https://lore.kernel.org/lkml/20191209202254.GA107567@dtor-ws/
> 
> for details, even if I haven't gotten a pull request from Dmitry since.

Sorry, I really disconnected over the holidays. I just sent you a small
pull request with this (and couple other) fixes.

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-01-09 14:23 Jiri Kosina
  2020-01-09 19:14 ` Linus Torvalds
@ 2020-01-09 19:15 ` pr-tracker-bot
  1 sibling, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2020-01-09 19:15 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Thu, 9 Jan 2020 15:23:09 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e69ec487b2c7c82ef99b4b15122f58a2a99289a3

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2020-01-09 14:23 Jiri Kosina
@ 2020-01-09 19:14 ` Linus Torvalds
  2020-01-09 19:25   ` Dmitry Torokhov
  2020-01-09 19:37   ` Jiri Kosina
  2020-01-09 19:15 ` pr-tracker-bot
  1 sibling, 2 replies; 73+ messages in thread
From: Linus Torvalds @ 2020-01-09 19:14 UTC (permalink / raw)
  To: Jiri Kosina, Dmitry Torokhov, Marcel Holtmann
  Cc: Linux Kernel Mailing List, Benjamin Tissoires

On Thu, Jan 9, 2020 at 6:23 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> - _poll API fixes for hidraw, from Marcel Holtmann

Why is this bogus thing sent to me as a "fix"?

It's breaking things AGAIN.

Guys, doing this is *WRONG*:

   if (readable)
       return "it's readable";
  if (error)
       return "there's some error";
  return "it's writable";

Seriously. Think about _why_ the above is wrong for five seconds please (*).

That "fix" actually introduces a bug, and the code is complete
garbage. It wasn't pretty before, but it was _less_ garbage before.

We had the exact same thing in the uinput layer recently, and it was
buggy then too.

That was Marcel that time too. And he was Cc'd on the fix back then
too, but still THIS SAME BUG gets introduced a month later in the HID
layer.

See

    https://lore.kernel.org/lkml/20191209202254.GA107567@dtor-ws/

for details, even if I haven't gotten a pull request from Dmitry since.

I've merged this HID code, BUT IT IS WRONG. Stop doing this mistake
over and over again, even when told otherwise.

I expect to see a fix, and I expect people to start thinking about it.
And Marcel, since you were told it was buggy once, why didn't you then
inform Jiri that you had sent *him* the same buggy code? How many
other people have you sent that buggy patch to without then informing
them that it was completely bogus?

            Linus

(*) If thinking about it for five seconds didn't help, then let me
just give a big clue-bat: "what if it's both readable and writable,
but the user only cares about the writable part"?

Poll is a *set* of conditions. Not just one.

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2020-01-09 14:23 Jiri Kosina
  2020-01-09 19:14 ` Linus Torvalds
  2020-01-09 19:15 ` pr-tracker-bot
  0 siblings, 2 replies; 73+ messages in thread
From: Jiri Kosina @ 2020-01-09 14:23 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to get fixes for HID subsystem:

=====
- fix for OOB in hiddev, from Dmitry Torokhov
- _poll API fixes for hidraw, from Marcel Holtmann
- functional fix for Steam driver, from Rodrigo Rivas Costa
- a few new device IDs / device-specific quirks and other assorted
  smaller fixes
=====

Thanks.

----------------------------------------------------------------
Aaron Ma (1):
      HID: multitouch: Add LG MELF0410 I2C touchscreen support

Alan Stern (1):
      HID: Fix slab-out-of-bounds read in hid_field_extract

Dmitry Torokhov (2):
      HID: hid-input: clear unmapped usages
      HID: hiddev: fix mess in hiddev_open()

Even Xu (1):
      HID: intel-ish-hid: ipc: add CMP device id

Hans de Goede (2):
      HID: ite: Add USB id match for Acer SW5-012 keyboard dock
      HID: asus: Ignore Asus vendor-page usage-code 0xff events

Jason Gerecke (1):
      HID: wacom: Recognize new MobileStudio Pro PID

Marcel Holtmann (2):
      HID: hidraw: Fix returning EPOLLOUT from hidraw_poll
      HID: uhid: Fix returning EPOLLOUT from uhid_char_poll

Pan Zhang (1):
      drivers/hid/hid-multitouch.c: fix a possible null pointer access.

Pavel Balan (1):
      HID: Add quirk for incorrect input length on Lenovo Y720

Priit Laes (1):
      HID: Add quirk for Xin-Mo Dual Controller

Rodrigo Rivas Costa (1):
      HID: steam: Fix input device disappearing

Srinivas Pandruvada (1):
      HID: intel-ish-hid: ipc: Add Tiger Lake PCI device ID

 drivers/hid/hid-asus.c                  |  3 +-
 drivers/hid/hid-core.c                  |  6 ++
 drivers/hid/hid-ids.h                   |  3 +
 drivers/hid/hid-input.c                 | 16 ++++--
 drivers/hid/hid-ite.c                   |  3 +
 drivers/hid/hid-multitouch.c            |  5 +-
 drivers/hid/hid-quirks.c                |  1 +
 drivers/hid/hid-steam.c                 |  4 ++
 drivers/hid/hidraw.c                    |  4 +-
 drivers/hid/i2c-hid/i2c-hid-core.c      | 16 +++++-
 drivers/hid/intel-ish-hid/ipc/hw-ish.h  |  2 +
 drivers/hid/intel-ish-hid/ipc/pci-ish.c |  2 +
 drivers/hid/uhid.c                      |  2 +-
 drivers/hid/usbhid/hiddev.c             | 97 ++++++++++++++-------------------
 drivers/hid/wacom_wac.c                 |  6 +-
 15 files changed, 101 insertions(+), 69 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2019-11-07 19:32 Jiri Kosina
@ 2019-11-07 20:00 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2019-11-07 20:00 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Thu, 7 Nov 2019 20:32:00 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/847120f859cc45e074204f4cf33c8df069306eb2

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2019-11-07 19:32 Jiri Kosina
  2019-11-07 20:00 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2019-11-07 19:32 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive two fixes for HID subsystem:

=====
- regression fix for i2c-hid power management, from Hans de Goede
- signed vs unsigned API fix for Wacom driver, from Jason Gerecke
=====

Thanks.

----------------------------------------------------------------
Hans de Goede (1):
      HID: i2c-hid: Send power-on command after reset

Jason Gerecke (1):
      HID: wacom: generic: Treat serial number and related fields as unsigned

 drivers/hid/i2c-hid/i2c-hid-core.c |  4 ++++
 drivers/hid/wacom.h                | 15 +++++++++++++++
 drivers/hid/wacom_wac.c            | 10 ++++++----
 3 files changed, 25 insertions(+), 4 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2019-08-20 12:53 Jiri Kosina
@ 2019-08-20 18:55 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2019-08-20 18:55 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Tue, 20 Aug 2019 14:53:48 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/15d90b242290f228166ea79ee1cc2db6b31a2143

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2019-08-20 12:53 Jiri Kosina
  2019-08-20 18:55 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2019-08-20 12:53 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes:

=====
- a few regression fixes for wacom driver (including fix for my earlier 
  mismerge) from Aaron Armstrong Skomra and Jason Gerecke
- revert of a few Logitech device ID additions which turn out to not work 
  perfectly with the hidpp driver at the moment; proper support is now 
  scheduled for 5.4. Fixes from Benjamin Tissoires
- scheduling-in-atomic fix for cp2112 driver, from Benjamin Tissoires
- new device ID to intel-ish, from Even Xu
=====

Thanks.

----------------------------------------------------------------
Aaron Armstrong Skomra (2):
      HID: wacom: add back changes dropped in merge commit
      HID: wacom: correct misreported EKR ring values

Benjamin Tissoires (3):
      Revert "HID: logitech-hidpp: add USB PID for a few more supported mice"
      HID: logitech-hidpp: remove support for the G700 over USB
      HID: cp2112: prevent sleeping function called from invalid context

Even Xu (1):
      HID: intel-ish-hid: ipc: add EHL device id

Jason Gerecke (1):
      HID: wacom: Correct distance scale for 2nd-gen Intuos devices

 drivers/hid/hid-cp2112.c                |  8 ++++++--
 drivers/hid/hid-logitech-hidpp.c        | 22 ----------------------
 drivers/hid/intel-ish-hid/ipc/hw-ish.h  |  1 +
 drivers/hid/intel-ish-hid/ipc/pci-ish.c |  1 +
 drivers/hid/wacom_wac.c                 |  7 +++++--
 5 files changed, 13 insertions(+), 26 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2019-08-06 10:59 Jiri Kosina
@ 2019-08-06 18:55 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2019-08-06 18:55 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Tue, 6 Aug 2019 12:59:39 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f4eb1423e43376bec578c5696635b074c8bd2035

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2019-08-06 10:59 Jiri Kosina
  2019-08-06 18:55 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2019-08-06 10:59 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes:

=====
- functional regression fix for some of the Logitech unifying devices, 
  from Hans de Goede
- race condition fix in hid-sony for bug severely affecting Valve/Android 
  deployments, from Roderick Colenbrander
- several fixes for issues found by syzbot/kasan, from Oliver Neukum and 
  Hillf Danton
- functional regression fix for Wacom Cintiq device, from Aaron Armstrong 
  Skomra
- a few other assorted device-specific quirks
=====

Thanks.

----------------------------------------------------------------
Aaron Armstrong Skomra (1):
      HID: wacom: fix bit shift for Cintiq Companion 2

Filipe Laíns (3):
      HID: logitech-dj: rename "gaming" receiver to "lightspeed"
      HID: logitech-hidpp: add USB PID for a few more supported mice
      HID: logitech-dj: add the Powerplay receiver

Hans de Goede (1):
      HID: logitech-dj: Really fix return value of logi_dj_recv_query_hidpp_devices

Hillf Danton (2):
      HID: hiddev: avoid opening a disconnected device
      HID: hiddev: do cleanup in failure of opening a device

Ilya Trukhanov (1):
      HID: Add 044f:b320 ThrustMaster, Inc. 2 in 1 DT

István Váradi (1):
      HID: quirks: Set the INCREMENT_USAGE_ON_DUPLICATE quirk on Saitek X52

Nicolas Saenz Julienne (1):
      HID: input: fix a4tech horizontal wheel custom usage

Oliver Neukum (1):
      HID: holtek: test for sanity of intfdata

Roderick Colenbrander (1):
      HID: sony: Fix race condition between rumble and device remove.

Sebastian Parschauer (1):
      HID: Add quirk for HP X1200 PIXART OEM mouse

 drivers/hid/hid-a4tech.c         | 30 +++++++++++++++++++++++++++---
 drivers/hid/hid-holtek-kbd.c     |  9 +++++++--
 drivers/hid/hid-ids.h            |  5 ++++-
 drivers/hid/hid-logitech-dj.c    | 10 +++++++---
 drivers/hid/hid-logitech-hidpp.c | 32 +++++++++++++++++++++++++++++++-
 drivers/hid/hid-quirks.c         |  2 ++
 drivers/hid/hid-sony.c           | 15 ++++++++++++---
 drivers/hid/hid-tmff.c           | 12 ++++++++++++
 drivers/hid/usbhid/hiddev.c      | 12 ++++++++++++
 drivers/hid/wacom_wac.c          | 12 ++++++------
 10 files changed, 120 insertions(+), 19 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2019-06-27  9:37 Jiri Kosina
@ 2019-06-28  0:45 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2019-06-28  0:45 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Thu, 27 Jun 2019 11:37:47 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/763cf1f2d9bfc8349c5791689074c8c17edf660d

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2019-06-27  9:37 Jiri Kosina
  2019-06-28  0:45 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2019-06-27  9:37 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive the following fixes for HID subsystem:

=====
- fix for one corner case in HID++ protocol with respect to handling very 
  long reports, from Hans de Goede
- power management fix in Intel-ISH driver, from Hyungwoo Yang
- use-after-free fix in Intel-ISH driver, from Dan Carpenter
- a couple of new device IDs/quirks from Kai-Heng Feng, Kyle Godbey and 
  Oleksandr Natalenko
=====

Thanks.

----------------------------------------------------------------
Dan Carpenter (1):
      HID: intel-ish-hid: Fix a use after free in load_fw_from_host()

Hans de Goede (1):
      HID: logitech-dj: Fix forwarding of very long HID++ reports

Hyungwoo Yang (1):
      HID: intel-ish-hid: fix wrong driver_data usage

Kai-Heng Feng (1):
      HID: multitouch: Add pointstick support for ALPS Touchpad

Kyle Godbey (1):
      HID: uclogic: Add support for Huion HS64 tablet

Oleksandr Natalenko (1):
      HID: chicony: add another quirk for PixArt mouse

 drivers/hid/hid-ids.h                        |  3 +++
 drivers/hid/hid-logitech-dj.c                |  4 +++-
 drivers/hid/hid-multitouch.c                 |  4 ++++
 drivers/hid/hid-quirks.c                     |  1 +
 drivers/hid/hid-uclogic-core.c               |  2 ++
 drivers/hid/hid-uclogic-params.c             |  2 ++
 drivers/hid/intel-ish-hid/ishtp-fw-loader.c  |  2 +-
 drivers/hid/intel-ish-hid/ishtp-hid-client.c |  4 ++--
 drivers/hid/intel-ish-hid/ishtp/bus.c        | 15 ++++++++++++++-
 include/linux/intel-ish-client-if.h          |  1 +
 10 files changed, 33 insertions(+), 5 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2019-04-03 13:39 Jiri Kosina
@ 2019-04-03 16:25 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2019-04-03 16:25 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, Benjamin Tissoires, linux-kernel

The pull request you sent on Wed, 3 Apr 2019 15:39:18 +0200 (CEST):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/8ed86627f715eacbd6db6862f9499d6d96ea4ad6

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2019-04-03 13:39 Jiri Kosina
  2019-04-03 16:25 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2019-04-03 13:39 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Benjamin Tissoires, linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID fixes:

=====
- build dependency fix for hid-asus from Arnd Bergmann
- addition of omitted mapping of _ASSISTANT key from Dmitry Torokhov
- race condition fix in hid-debug inftastructure from He, Bo
- fixed support for devices with big maximum report size from Kai-Heng 
  Feng
- deadlock fix in hid-steam from Rodrigo Rivas Costa
- quite a few device-specific quirks
=====

Thanks.

----------------------------------------------------------------
Andy Shevchenko (1):
      HID: quirks: Drop misused kernel-doc annotation

Arnd Bergmann (1):
      HID: hid-asus: select CONFIG_POWER_SUPPLY

Colin Ian King (1):
      HID: uclogic: remove redudant duplicated null check on ver_ptr

Dmitry Torokhov (1):
      HID: input: add mapping for Assistant key

He, Bo (1):
      HID: debug: fix race condition with between rdesc_show() and device removal

Hui Wang (1):
      HID: i2c-hid: Disable runtime PM on Synaptics touchpad

Jeffrey Hugo (1):
      HID: quirks: Fix keyboard + touchpad on Lenovo Miix 630

Kai-Heng Feng (1):
      HID: Increase maximum report size allowed by hid_field_extract()

Kangjie Lu (1):
      HID: logitech: check the return value of create_singlethread_workqueue

Louis Taylor (1):
      HID: quirks: use correct format chars in dbg_hid

Peter Hutterer (1):
      HID: logitech: Handle 0 scroll events for the m560

Rodrigo Rivas Costa (1):
      HID: steam: fix deadlock with input devices.

 drivers/hid/Kconfig                |  1 +
 drivers/hid/hid-core.c             |  6 +++---
 drivers/hid/hid-debug.c            |  5 +++++
 drivers/hid/hid-ids.h              |  1 +
 drivers/hid/hid-input.c            |  1 +
 drivers/hid/hid-logitech-hidpp.c   | 13 ++++++++++---
 drivers/hid/hid-quirks.c           | 11 +++++++----
 drivers/hid/hid-steam.c            | 26 +++++++++++++++++++-------
 drivers/hid/hid-uclogic-params.c   |  4 ----
 drivers/hid/i2c-hid/i2c-hid-core.c |  2 ++
 10 files changed, 49 insertions(+), 21 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2019-01-22  9:46 Jiri Kosina
@ 2019-01-22 18:55 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2019-01-22 18:55 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, Benjamin Tissoires, linux-kernel

The pull request you sent on Tue, 22 Jan 2019 10:46:24 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/787a3b4322763284a594a5dd3680508c0bfb20b0

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2019-01-22  9:46 Jiri Kosina
  2019-01-22 18:55 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2019-01-22  9:46 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Benjamin Tissoires, linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID fixes:

=====
- descriptor parsing regression fix for devices that have more than 16 
  collections, from Peter Hutterer (and followup cleanup from Philipp 
  Zabel)
- quirk for Goodix touchpad
=====

Thanks.

----------------------------------------------------------------
Kai-Heng Feng (1):
      HID: i2c-hid: Disable runtime PM on Goodix touchpad

Peter Hutterer (1):
      HID: core: replace the collection tree pointers with indices

Philipp Zabel (1):
      HID: core: simplify active collection tracking

 drivers/hid/hid-core.c             | 23 ++++++++++++-----------
 drivers/hid/hid-ids.h              |  3 +++
 drivers/hid/i2c-hid/i2c-hid-core.c |  2 ++
 include/linux/hid.h                |  3 +--
 4 files changed, 18 insertions(+), 13 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-12-10 16:05 Jiri Kosina
@ 2018-12-10 20:20 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2018-12-10 20:20 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, Benjamin Tissoires, linux-kernel

The pull request you sent on Mon, 10 Dec 2018 17:05:06 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/f5d582777bcb1c7ff19a5a2343f66ea01de401c6

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2018-12-10 16:05 Jiri Kosina
  2018-12-10 20:20 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2018-12-10 16:05 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Benjamin Tissoires, linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes:

=====
- two device-specific quirks from Hans de Goede and Nic Soudée
- reintroduction of (mistakenly remocved) ABS_RESERVED from Peter Hutterer
=====

Thanks.

----------------------------------------------------------------
Hans de Goede (1):
      HID: ite: Add USB id match for another ITE based keyboard rfkill key quirk

Nic Soudée (1):
      HID: quirks: fix RetroUSB.com devices

Peter Hutterer (1):
      Input: restore EV_ABS ABS_RESERVED

 drivers/hid/hid-ids.h                  | 7 +++++++
 drivers/hid/hid-ite.c                  | 1 +
 drivers/hid/hid-quirks.c               | 2 ++
 include/uapi/linux/input-event-codes.h | 9 +++++++++
 4 files changed, 19 insertions(+)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-11-24 20:19 Jiri Kosina
@ 2018-11-24 23:15 ` pr-tracker-bot
  0 siblings, 0 replies; 73+ messages in thread
From: pr-tracker-bot @ 2018-11-24 23:15 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linus Torvalds, linux-kernel, Benjamin Tissoires

The pull request you sent on Sat, 24 Nov 2018 21:19:35 +0100 (CET):

> git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e195ca6cb6f21633e56322d5aa11ed59cdb22fb2

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2018-11-24 20:19 Jiri Kosina
  2018-11-24 23:15 ` pr-tracker-bot
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2018-11-24 20:19 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsystem fixes

=====
- revert of the high-resolution scrolling feature, as it breaks certain 
  hardware due to incompatibilities between Logitech and Microsoft worlds.
  Peter Hutterer is working on a fixed implementation. Until that is
  finished, revert by Benjamin Tissoires.

- revert of incorrect strncpy->strlcpy conversion in uhid, from David 
  Herrmann

- fix for buggy sendfile() implementation on uhid device node, from Eric 
  Biggers

- a few assorted device-ID specific quirks
=====

Thanks.

----------------------------------------------------------------
Benjamin Tissoires (7):
      Revert "HID: input: simplify/fix high-res scroll event handling"
      Revert "HID: logitech: fix a used uninitialized GCC warning"
      Revert "HID: logitech: Use LDJ_DEVICE macro for existing Logitech mice"
      Revert "HID: logitech: Enable high-resolution scrolling on Logitech mice"
      Revert "HID: logitech: Add function to enable HID++ 1.0 "scrolling acceleration""
      Revert "HID: input: Create a utility class for counting scroll events"
      Revert "Input: Add the `REL_WHEEL_HI_RES` event code"

Benson Leung (1):
      HID: input: Ignore battery reported by Symbol DS4308

David Herrmann (1):
      Revert "HID: uhid: use strlcpy() instead of strncpy()"

Eric Biggers (1):
      HID: uhid: forbid UHID_CREATE under KERNEL_DS or elevated privileges

Kai-Heng Feng (2):
      HID: multitouch: Add pointstick support for Cirque Touchpad
      HID: i2c-hid: Disable runtime PM for LG touchscreen

Rodrigo Rivas Costa (1):
      HID: steam: remove input device when a hid client is running.

Sebastian Parschauer (2):
      HID: Add quirk for Microsoft PIXART OEM mouse
      HID: Add quirk for Primax PIXART OEM mice

 Documentation/input/event-codes.rst    |  11 +-
 drivers/hid/hid-ids.h                  |   8 +
 drivers/hid/hid-input.c                |  47 +----
 drivers/hid/hid-logitech-hidpp.c       | 309 +++------------------------------
 drivers/hid/hid-multitouch.c           |   6 +
 drivers/hid/hid-quirks.c               |   3 +
 drivers/hid/hid-steam.c                | 154 +++++++++-------
 drivers/hid/i2c-hid/i2c-hid-core.c     |   2 +
 drivers/hid/uhid.c                     |  25 ++-
 include/linux/hid.h                    |  28 ---
 include/uapi/linux/input-event-codes.h |  10 --
 11 files changed, 159 insertions(+), 444 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-11-07 10:31 Jiri Kosina
@ 2018-11-07 17:07 ` Linus Torvalds
  0 siblings, 0 replies; 73+ messages in thread
From: Linus Torvalds @ 2018-11-07 17:07 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Linux List Kernel Mailing, Benjamin Tissoires

On Wed, Nov 7, 2018 at 2:31 AM Jiri Kosina <jikos@kernel.org> wrote:
>
> HID subsytem fixes

Pulled,

               Linus

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2018-11-07 10:31 Jiri Kosina
  2018-11-07 17:07 ` Linus Torvalds
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2018-11-07 10:31 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Benjamin Tissoires

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus

to receive HID subsytem fixes

=====
- hid.git is moving towards group maintainership (where group is myself 
  and Benjamin Tissoires), therefore this pull request updates MAINTAINERS
  accordingly
- fix for hid-asus config dependency from Arnd Bergmann
- two device-specific quirks for i2c-hid from Julian Sax and Kai-Heng Feng
- other few small assorted fixes
=====

Thanks.

----------------------------------------------------------------
Arnd Bergmann (1):
      HID: asus: fix build warning wiht CONFIG_ASUS_WMI disabled

Benjamin Tissoires (2):
      Revert "HID: add NOGET quirk for Eaton Ellipse MAX UPS"
      HID: alps: allow incoming reports when only the trackstick is opened

Breno Leitao (1):
      HID: hiddev: fix potential Spectre v1

Jiri Kosina (1):
      HID: moving to group maintainership model

Julian Sax (1):
      HID: i2c-hid: add Direkt-Tek DTLAPY133-1 to descriptor override

Kai-Heng Feng (1):
      HID: i2c-hid: Add a small delay after sleep command for Raydium touchpanel

Linus Walleij (1):
      HID: fix up .raw_event() documentation

 MAINTAINERS                              |  8 ++++----
 drivers/hid/hid-alps.c                   | 18 ++++++++++++++++++
 drivers/hid/hid-asus.c                   |  3 +++
 drivers/hid/hid-ids.h                    |  3 +++
 drivers/hid/hid-quirks.c                 |  1 -
 drivers/hid/i2c-hid/i2c-hid-core.c       | 19 +++++++++++++++++++
 drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c |  8 ++++++++
 drivers/hid/usbhid/hiddev.c              | 18 ++++++++++++++----
 include/linux/hid.h                      |  4 ++--
 9 files changed, 71 insertions(+), 11 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-10-03  8:55 Jiri Kosina
@ 2018-10-03 11:50 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 73+ messages in thread
From: Greg Kroah-Hartman @ 2018-10-03 11:50 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: linux-kernel, Benjamin Tissoires, Linus Torvalds

On Wed, Oct 03, 2018 at 10:55:19AM +0200, Jiri Kosina wrote:
> Greg,
> 
> please pull from
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus
> 
> to receive HID subsystem fixes


Now pulled, thanks.

greg k-h


^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2018-10-03  8:55 Jiri Kosina
  2018-10-03 11:50 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2018-10-03  8:55 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel, Benjamin Tissoires, Linus Torvalds

Greg,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive HID subsystem fixes

=====
- hantick touchpad fix from Anisse Astier
- device ID addition for Ice Lake mobile from Srinivas Pandruvada
- touchscreen resume fix for certain i2c-hid driven devices from Hans de 
  Goede
=====

Thanks.

----------------------------------------------------------------
Anisse Astier (1):
      HID: i2c-hid: disable runtime PM operations on hantick touchpad

Hans de Goede (1):
      HID: i2c-hid: Remove RESEND_REPORT_DESCR quirk and its handling

Srinivas Pandruvada (1):
      HID: intel-ish-hid: Enable Ice Lake mobile

 drivers/hid/hid-ids.h                   |  1 -
 drivers/hid/i2c-hid/i2c-hid.c           | 27 ++++++++++-----------------
 drivers/hid/intel-ish-hid/ipc/hw-ish.h  |  1 +
 drivers/hid/intel-ish-hid/ipc/pci-ish.c |  1 +
 4 files changed, 12 insertions(+), 18 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2018-09-11  7:49 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2018-09-11  7:49 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive fixes for HID subsystem; highlights:

=====
- functional regression fix for sensor-hub driver from Hans de Goede
- stop doing device reset for i2c-hid devices, which unbreaks some of them 
  (and is in line with the specification), from Kai-Heng Feng
- error handling fix for hid-core from Gustavo A. R. Silva
- functional regression fix for some Elan panels from Benjamin Tissoires
- a few new device ID additions and misc small fixes
=====

Thanks.

----------------------------------------------------------------
AceLan Kao (1):
      HID: i2c-hid: Fix flooded incomplete report after S3 on Rayd touchscreen

Andreas Bosch (1):
      HID: intel-ish-hid: Enable Sunrise Point-H ish driver

Benjamin Tissoires (2):
      HID: multitouch: fix Elan panels with 2 input modes declaration
      HID: core: fix grouping by application

Gustavo A. R. Silva (1):
      HID: core: fix NULL pointer dereference

Hans de Goede (1):
      HID: sensor-hub: Restore fixup for Lenovo ThinkPad Helix 2 sensor hub report

Harry Mallon (1):
      HID: hid-saitek: Add device ID for RAT 7 Contagion

Kai-Heng Feng (1):
      HID: i2c-hid: Don't reset device upon system resume

Sean O'Brien (1):
      HID: add support for Apple Magic Keyboards

Stefan Agner (2):
      HID: input: fix leaking custom input node name
      HID: core: fix memory leak on probe

 drivers/hid/hid-apple.c                 |  9 ++++++++-
 drivers/hid/hid-core.c                  |  5 ++++-
 drivers/hid/hid-ids.h                   |  6 +++---
 drivers/hid/hid-input.c                 |  5 +++--
 drivers/hid/hid-multitouch.c            | 19 +++++++++++++++++--
 drivers/hid/hid-saitek.c                |  2 ++
 drivers/hid/hid-sensor-hub.c            | 23 +++++++++++++++++++++++
 drivers/hid/i2c-hid/i2c-hid.c           | 11 +++++++----
 drivers/hid/intel-ish-hid/ipc/hw-ish.h  |  1 +
 drivers/hid/intel-ish-hid/ipc/pci-ish.c |  1 +
 include/linux/hid.h                     |  1 +
 11 files changed, 70 insertions(+), 13 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2018-07-09 12:54 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2018-07-09 12:54 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive HID subsystem fixes:

=====
- spectrev1 pattern fix in hiddev from Gustavo A. R. Silva
- Bounds check fix for hid-debug from Daniel Rosenberg
- Regression fix for HID autobinding from Benjamin Tissoires
- Removal of excessive logging from i2c-hid driver from Jason Andryuk
- fix specific to 2nd generation of Wacom Intuos devices from Jason 
  Gerecke
=====

Thanks.

----------------------------------------------------------------
Benjamin Tissoires (1):
      HID: core: allow concurrent registration of drivers

Daniel Rosenberg (1):
      HID: debug: check length before copy_to_user()

Gustavo A. R. Silva (1):
      HID: hiddev: fix potential Spectre v1

Jason Andryuk (1):
      HID: i2c-hid: Fix "incomplete report" noise

Jason Gerecke (1):
      HID: wacom: Correct touch maximum XY of 2nd-gen Intuos

 drivers/hid/hid-core.c        |  5 ++++-
 drivers/hid/hid-debug.c       |  8 +++++++-
 drivers/hid/i2c-hid/i2c-hid.c |  2 +-
 drivers/hid/usbhid/hiddev.c   | 11 +++++++++++
 drivers/hid/wacom_wac.c       | 10 ++++++++--
 include/linux/hid.h           |  3 ++-
 6 files changed, 33 insertions(+), 6 deletions(-)

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-06-20  7:15         ` Jiri Kosina
@ 2018-06-20  7:35           ` Benjamin Tissoires
  0 siblings, 0 replies; 73+ messages in thread
From: Benjamin Tissoires @ 2018-06-20  7:35 UTC (permalink / raw)
  To: Jiri Kosina
  Cc: Linus Torvalds, Hans de Goede, Julian Sax, Linux Kernel Mailing List

On Wed, Jun 20, 2018 at 9:15 AM, Jiri Kosina <jikos@kernel.org> wrote:
> On Wed, 20 Jun 2018, Linus Torvalds wrote:
>
>> But what is the *source* of this binary crud?
>>
>> Because no way in hell do we take binary crud from random places, and
>> then add it to the kernel.
>>
>> NOT EVEN IF IT WENT THROUGH SOME "hidrd-convert" PHASE!
>>
>> And yes, now that I google for that hidrd-convert pattern, I see that
>> we already have other broken chunks like this.
>>
>> Not ok. At least some of them seem to mention where the data comes from,
>> eg
>>
>>    "This is the original report descriptor as reported by lsusb -vd 046d:c294"
>>
>> but this one has no such information.
>>
>> So guys, you need to think about where things come from, and document
>> how some random garbage came to be. Not just add it to the kernel.
>
> Well, at least for the ones I've done myself in the past, those are
> hand-written from scratch.
>
> It's not really a firmware / code, it's just a description of the data in
> the reports, so that HID parser can interpret it properly.
>

In case it matters, I have an open-source python script that parses
those blobs and output the same level of human description here:
https://gitlab.freedesktop.org/libevdev/hid-tools/ (the script
parse_rdesc.py).

As Jiri said, this is all standardized and documented in the HID
protocol[1], and this 'just' describes the data that will be sent over
the transport layer.

In this particular case, the descriptors were extracted from the
Windows driver, not by looking at the binaries, but by looking at the
data that was transmitted from the "device". The thing is the data is
not stored on the device chip itself but on a third party driver from
the vendor. However, from a windows point of view, the third party
driver intercepts the I2C commands and supply the information when
needed. So it is as if the device answered. Blame the vendor here that
decided to reduce the costs and save a few KB on the chip :/

Cheers,
Benjamin

[1] http://www.usb.org/developers/hidpage/HID1_11.pdf

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-06-20  7:12       ` Linus Torvalds
@ 2018-06-20  7:15         ` Jiri Kosina
  2018-06-20  7:35           ` Benjamin Tissoires
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2018-06-20  7:15 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Hans de Goede, Julian Sax, Benjamin Tissoires, Linux Kernel Mailing List

On Wed, 20 Jun 2018, Linus Torvalds wrote:

> But what is the *source* of this binary crud?
> 
> Because no way in hell do we take binary crud from random places, and
> then add it to the kernel.
> 
> NOT EVEN IF IT WENT THROUGH SOME "hidrd-convert" PHASE!
> 
> And yes, now that I google for that hidrd-convert pattern, I see that
> we already have other broken chunks like this.
> 
> Not ok. At least some of them seem to mention where the data comes from, 
> eg
> 
>    "This is the original report descriptor as reported by lsusb -vd 046d:c294"
> 
> but this one has no such information.
> 
> So guys, you need to think about where things come from, and document
> how some random garbage came to be. Not just add it to the kernel.

Well, at least for the ones I've done myself in the past, those are 
hand-written from scratch.

It's not really a firmware / code, it's just a description of the data in 
the reports, so that HID parser can interpret it properly.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-06-20  7:06     ` Hans de Goede
@ 2018-06-20  7:12       ` Linus Torvalds
  2018-06-20  7:15         ` Jiri Kosina
  0 siblings, 1 reply; 73+ messages in thread
From: Linus Torvalds @ 2018-06-20  7:12 UTC (permalink / raw)
  To: Hans de Goede
  Cc: Julian Sax, Jiri Kosina, Benjamin Tissoires, Linux Kernel Mailing List

On Wed, Jun 20, 2018 at 4:06 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
>
> Julian let me know if you need any help with this,
> to format the HID descriptor take a file with
> the raw descriptor in binary format and do:
>
> cat descriptor.bin | hidrd-convert -o code

But what is the *source* of this binary crud?

Because no way in hell do we take binary crud from random places, and
then add it to the kernel.

NOT EVEN IF IT WENT THROUGH SOME "hidrd-convert" PHASE!

And yes, now that I google for that hidrd-convert pattern, I see that
we already have other broken chunks like this.

Not ok. At least some of them seem to mention where the data comes from, eg

   "This is the original report descriptor as reported by lsusb -vd 046d:c294"

but this one has no such information.

So guys, you need to think about where things come from, and document
how some random garbage came to be. Not just add it to the kernel.

                     Linus

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-06-20  4:19   ` Jiri Kosina
@ 2018-06-20  7:06     ` Hans de Goede
  2018-06-20  7:12       ` Linus Torvalds
  0 siblings, 1 reply; 73+ messages in thread
From: Hans de Goede @ 2018-06-20  7:06 UTC (permalink / raw)
  To: Julian Sax
  Cc: Jiri Kosina, Benjamin Tissoires, Linux Kernel Mailing List,
	Linus Torvalds

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

Hi all,

On 20-06-18 06:19, Jiri Kosina wrote:
> On Wed, 20 Jun 2018, Linus Torvalds wrote:
> 
>> What is that odd binary blob i2c_hid_desc_override, and where does the
>> data come from? Not explained anywhere.
> 
> Fair enough; it's a pretty standard HID descriptor override, but you're
> right that we're usually replacing it in a bit more verbose way. Julian,
> could you please run that descriptor through something like HID descriptor
> tool, and send me a patch that reformats it? (for the way we usually do
> this, look for example in hid-sony.c).

Julian let me know if you need any help with this,
to format the HID descriptor take a file with
the raw descriptor in binary format and do:

cat descriptor.bin | hidrd-convert -o code

I've just done that to make sure my instructions are
right, so to save you having to redo this I've
attached the result.

Regards,

Hans



[-- Attachment #2: desc.c --]
[-- Type: text/x-csrc, Size: 18091 bytes --]

0x05, 0x01,                     /*  Usage Page (Desktop),                   */
0x09, 0x02,                     /*  Usage (Mouse),                          */
0xA1, 0x01,                     /*  Collection (Application),               */
0x85, 0x01,                     /*      Report ID (1),                      */
0x09, 0x01,                     /*      Usage (Pointer),                    */
0xA1, 0x00,                     /*      Collection (Physical),              */
0x05, 0x09,                     /*          Usage Page (Button),            */
0x19, 0x01,                     /*          Usage Minimum (01h),            */
0x29, 0x02,                     /*          Usage Maximum (02h),            */
0x25, 0x01,                     /*          Logical Maximum (1),            */
0x75, 0x01,                     /*          Report Size (1),                */
0x95, 0x02,                     /*          Report Count (2),               */
0x81, 0x02,                     /*          Input (Variable),               */
0x95, 0x06,                     /*          Report Count (6),               */
0x81, 0x01,                     /*          Input (Constant),               */
0x05, 0x01,                     /*          Usage Page (Desktop),           */
0x09, 0x30,                     /*          Usage (X),                      */
0x09, 0x31,                     /*          Usage (Y),                      */
0x15, 0x81,                     /*          Logical Minimum (-127),         */
0x25, 0x7F,                     /*          Logical Maximum (127),          */
0x75, 0x08,                     /*          Report Size (8),                */
0x95, 0x02,                     /*          Report Count (2),               */
0x81, 0x06,                     /*          Input (Variable, Relative),     */
0xC0,                           /*      End Collection,                     */
0xC0,                           /*  End Collection,                         */
0x05, 0x0D,                     /*  Usage Page (Digitizer),                 */
0x09, 0x05,                     /*  Usage (Touchpad),                       */
0xA1, 0x01,                     /*  Collection (Application),               */
0x85, 0x04,                     /*      Report ID (4),                      */
0x05, 0x0D,                     /*      Usage Page (Digitizer),             */
0x09, 0x22,                     /*      Usage (Finger),                     */
0xA1, 0x02,                     /*      Collection (Logical),               */
0x15, 0x00,                     /*          Logical Minimum (0),            */
0x25, 0x01,                     /*          Logical Maximum (1),            */
0x09, 0x47,                     /*          Usage (Touch Valid),            */
0x09, 0x42,                     /*          Usage (Tip Switch),             */
0x95, 0x02,                     /*          Report Count (2),               */
0x75, 0x01,                     /*          Report Size (1),                */
0x81, 0x02,                     /*          Input (Variable),               */
0x95, 0x01,                     /*          Report Count (1),               */
0x75, 0x03,                     /*          Report Size (3),                */
0x25, 0x05,                     /*          Logical Maximum (5),            */
0x09, 0x51,                     /*          Usage (Contact Identifier),     */
0x81, 0x02,                     /*          Input (Variable),               */
0x75, 0x01,                     /*          Report Size (1),                */
0x95, 0x03,                     /*          Report Count (3),               */
0x81, 0x03,                     /*          Input (Constant, Variable),     */
0x05, 0x01,                     /*          Usage Page (Desktop),           */
0x26, 0x44, 0x0A,               /*          Logical Maximum (2628),         */
0x75, 0x10,                     /*          Report Size (16),               */
0x55, 0x0E,                     /*          Unit Exponent (14),             */
0x65, 0x11,                     /*          Unit (Centimeter),              */
0x09, 0x30,                     /*          Usage (X),                      */
0x46, 0x1A, 0x04,               /*          Physical Maximum (1050),        */
0x95, 0x01,                     /*          Report Count (1),               */
0x81, 0x02,                     /*          Input (Variable),               */
0x46, 0xBC, 0x02,               /*          Physical Maximum (700),         */
0x26, 0x34, 0x05,               /*          Logical Maximum (1332),         */
0x09, 0x31,                     /*          Usage (Y),                      */
0x81, 0x02,                     /*          Input (Variable),               */
0xC0,                           /*      End Collection,                     */
0x05, 0x0D,                     /*      Usage Page (Digitizer),             */
0x09, 0x22,                     /*      Usage (Finger),                     */
0xA1, 0x02,                     /*      Collection (Logical),               */
0x25, 0x01,                     /*          Logical Maximum (1),            */
0x09, 0x47,                     /*          Usage (Touch Valid),            */
0x09, 0x42,                     /*          Usage (Tip Switch),             */
0x95, 0x02,                     /*          Report Count (2),               */
0x75, 0x01,                     /*          Report Size (1),                */
0x81, 0x02,                     /*          Input (Variable),               */
0x95, 0x01,                     /*          Report Count (1),               */
0x75, 0x03,                     /*          Report Size (3),                */
0x25, 0x05,                     /*          Logical Maximum (5),            */
0x09, 0x51,                     /*          Usage (Contact Identifier),     */
0x81, 0x02,                     /*          Input (Variable),               */
0x75, 0x01,                     /*          Report Size (1),                */
0x95, 0x03,                     /*          Report Count (3),               */
0x81, 0x03,                     /*          Input (Constant, Variable),     */
0x05, 0x01,                     /*          Usage Page (Desktop),           */
0x26, 0x44, 0x0A,               /*          Logical Maximum (2628),         */
0x75, 0x10,                     /*          Report Size (16),               */
0x09, 0x30,                     /*          Usage (X),                      */
0x46, 0x1A, 0x04,               /*          Physical Maximum (1050),        */
0x95, 0x01,                     /*          Report Count (1),               */
0x81, 0x02,                     /*          Input (Variable),               */
0x46, 0xBC, 0x02,               /*          Physical Maximum (700),         */
0x26, 0x34, 0x05,               /*          Logical Maximum (1332),         */
0x09, 0x31,                     /*          Usage (Y),                      */
0x81, 0x02,                     /*          Input (Variable),               */
0xC0,                           /*      End Collection,                     */
0x05, 0x0D,                     /*      Usage Page (Digitizer),             */
0x09, 0x22,                     /*      Usage (Finger),                     */
0xA1, 0x02,                     /*      Collection (Logical),               */
0x25, 0x01,                     /*          Logical Maximum (1),            */
0x09, 0x47,                     /*          Usage (Touch Valid),            */
0x09, 0x42,                     /*          Usage (Tip Switch),             */
0x95, 0x02,                     /*          Report Count (2),               */
0x75, 0x01,                     /*          Report Size (1),                */
0x81, 0x02,                     /*          Input (Variable),               */
0x95, 0x01,                     /*          Report Count (1),               */
0x75, 0x03,                     /*          Report Size (3),                */
0x25, 0x05,                     /*          Logical Maximum (5),            */
0x09, 0x51,                     /*          Usage (Contact Identifier),     */
0x81, 0x02,                     /*          Input (Variable),               */
0x75, 0x01,                     /*          Report Size (1),                */
0x95, 0x03,                     /*          Report Count (3),               */
0x81, 0x03,                     /*          Input (Constant, Variable),     */
0x05, 0x01,                     /*          Usage Page (Desktop),           */
0x26, 0x44, 0x0A,               /*          Logical Maximum (2628),         */
0x75, 0x10,                     /*          Report Size (16),               */
0x09, 0x30,                     /*          Usage (X),                      */
0x46, 0x1A, 0x04,               /*          Physical Maximum (1050),        */
0x95, 0x01,                     /*          Report Count (1),               */
0x81, 0x02,                     /*          Input (Variable),               */
0x46, 0xBC, 0x02,               /*          Physical Maximum (700),         */
0x26, 0x34, 0x05,               /*          Logical Maximum (1332),         */
0x09, 0x31,                     /*          Usage (Y),                      */
0x81, 0x02,                     /*          Input (Variable),               */
0xC0,                           /*      End Collection,                     */
0x05, 0x0D,                     /*      Usage Page (Digitizer),             */
0x09, 0x22,                     /*      Usage (Finger),                     */
0xA1, 0x02,                     /*      Collection (Logical),               */
0x25, 0x01,                     /*          Logical Maximum (1),            */
0x09, 0x47,                     /*          Usage (Touch Valid),            */
0x09, 0x42,                     /*          Usage (Tip Switch),             */
0x95, 0x02,                     /*          Report Count (2),               */
0x75, 0x01,                     /*          Report Size (1),                */
0x81, 0x02,                     /*          Input (Variable),               */
0x95, 0x01,                     /*          Report Count (1),               */
0x75, 0x03,                     /*          Report Size (3),                */
0x25, 0x05,                     /*          Logical Maximum (5),            */
0x09, 0x51,                     /*          Usage (Contact Identifier),     */
0x81, 0x02,                     /*          Input (Variable),               */
0x75, 0x01,                     /*          Report Size (1),                */
0x95, 0x03,                     /*          Report Count (3),               */
0x81, 0x03,                     /*          Input (Constant, Variable),     */
0x05, 0x01,                     /*          Usage Page (Desktop),           */
0x26, 0x44, 0x0A,               /*          Logical Maximum (2628),         */
0x75, 0x10,                     /*          Report Size (16),               */
0x09, 0x30,                     /*          Usage (X),                      */
0x46, 0x1A, 0x04,               /*          Physical Maximum (1050),        */
0x95, 0x01,                     /*          Report Count (1),               */
0x81, 0x02,                     /*          Input (Variable),               */
0x46, 0xBC, 0x02,               /*          Physical Maximum (700),         */
0x26, 0x34, 0x05,               /*          Logical Maximum (1332),         */
0x09, 0x31,                     /*          Usage (Y),                      */
0x81, 0x02,                     /*          Input (Variable),               */
0xC0,                           /*      End Collection,                     */
0x05, 0x0D,                     /*      Usage Page (Digitizer),             */
0x55, 0x0C,                     /*      Unit Exponent (12),                 */
0x66, 0x01, 0x10,               /*      Unit (Seconds),                     */
0x47, 0xFF, 0xFF, 0x00, 0x00,   /*      Physical Maximum (65535),           */
0x27, 0xFF, 0xFF, 0x00, 0x00,   /*      Logical Maximum (65535),            */
0x75, 0x10,                     /*      Report Size (16),                   */
0x95, 0x01,                     /*      Report Count (1),                   */
0x09, 0x56,                     /*      Usage (Scan Time),                  */
0x81, 0x02,                     /*      Input (Variable),                   */
0x09, 0x54,                     /*      Usage (Contact Count),              */
0x25, 0x7F,                     /*      Logical Maximum (127),              */
0x75, 0x08,                     /*      Report Size (8),                    */
0x81, 0x02,                     /*      Input (Variable),                   */
0x05, 0x09,                     /*      Usage Page (Button),                */
0x09, 0x01,                     /*      Usage (01h),                        */
0x25, 0x01,                     /*      Logical Maximum (1),                */
0x75, 0x01,                     /*      Report Size (1),                    */
0x95, 0x01,                     /*      Report Count (1),                   */
0x81, 0x02,                     /*      Input (Variable),                   */
0x95, 0x07,                     /*      Report Count (7),                   */
0x81, 0x03,                     /*      Input (Constant, Variable),         */
0x05, 0x0D,                     /*      Usage Page (Digitizer),             */
0x85, 0x02,                     /*      Report ID (2),                      */
0x09, 0x55,                     /*      Usage (Contact Count Maximum),      */
0x09, 0x59,                     /*      Usage (59h),                        */
0x75, 0x04,                     /*      Report Size (4),                    */
0x95, 0x02,                     /*      Report Count (2),                   */
0x25, 0x0F,                     /*      Logical Maximum (15),               */
0xB1, 0x02,                     /*      Feature (Variable),                 */
0x05, 0x0D,                     /*      Usage Page (Digitizer),             */
0x85, 0x07,                     /*      Report ID (7),                      */
0x09, 0x60,                     /*      Usage (60h),                        */
0x75, 0x01,                     /*      Report Size (1),                    */
0x95, 0x01,                     /*      Report Count (1),                   */
0x25, 0x01,                     /*      Logical Maximum (1),                */
0xB1, 0x02,                     /*      Feature (Variable),                 */
0x95, 0x07,                     /*      Report Count (7),                   */
0xB1, 0x03,                     /*      Feature (Constant, Variable),       */
0x85, 0x06,                     /*      Report ID (6),                      */
0x06, 0x00, 0xFF,               /*      Usage Page (FF00h),                 */
0x09, 0xC5,                     /*      Usage (C5h),                        */
0x26, 0xFF, 0x00,               /*      Logical Maximum (255),              */
0x75, 0x08,                     /*      Report Size (8),                    */
0x96, 0x00, 0x01,               /*      Report Count (256),                 */
0xB1, 0x02,                     /*      Feature (Variable),                 */
0xC0,                           /*  End Collection,                         */
0x06, 0x00, 0xFF,               /*  Usage Page (FF00h),                     */
0x09, 0x01,                     /*  Usage (01h),                            */
0xA1, 0x01,                     /*  Collection (Application),               */
0x85, 0x0D,                     /*      Report ID (13),                     */
0x26, 0xFF, 0x00,               /*      Logical Maximum (255),              */
0x19, 0x01,                     /*      Usage Minimum (01h),                */
0x29, 0x02,                     /*      Usage Maximum (02h),                */
0x75, 0x08,                     /*      Report Size (8),                    */
0x95, 0x02,                     /*      Report Count (2),                   */
0xB1, 0x02,                     /*      Feature (Variable),                 */
0xC0,                           /*  End Collection,                         */
0x05, 0x0D,                     /*  Usage Page (Digitizer),                 */
0x09, 0x0E,                     /*  Usage (Configuration),                  */
0xA1, 0x01,                     /*  Collection (Application),               */
0x85, 0x03,                     /*      Report ID (3),                      */
0x09, 0x22,                     /*      Usage (Finger),                     */
0xA1, 0x02,                     /*      Collection (Logical),               */
0x09, 0x52,                     /*          Usage (Device Mode),            */
0x25, 0x0A,                     /*          Logical Maximum (10),           */
0x95, 0x01,                     /*          Report Count (1),               */
0xB1, 0x02,                     /*          Feature (Variable),             */
0xC0,                           /*      End Collection,                     */
0x09, 0x22,                     /*      Usage (Finger),                     */
0xA1, 0x00,                     /*      Collection (Physical),              */
0x85, 0x05,                     /*          Report ID (5),                  */
0x09, 0x57,                     /*          Usage (57h),                    */
0x09, 0x58,                     /*          Usage (58h),                    */
0x75, 0x01,                     /*          Report Size (1),                */
0x95, 0x02,                     /*          Report Count (2),               */
0x25, 0x01,                     /*          Logical Maximum (1),            */
0xB1, 0x02,                     /*          Feature (Variable),             */
0x95, 0x06,                     /*          Report Count (6),               */
0xB1, 0x03,                     /*          Feature (Constant, Variable),   */
0xC0,                           /*      End Collection,                     */
0xC0                            /*  End Collection                          */

^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-06-20  1:51 ` Linus Torvalds
@ 2018-06-20  4:19   ` Jiri Kosina
  2018-06-20  7:06     ` Hans de Goede
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2018-06-20  4:19 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Julian Sax, Hans de Goede, Benjamin Tissoires, Linux Kernel Mailing List

On Wed, 20 Jun 2018, Linus Torvalds wrote:

> What is that odd binary blob i2c_hid_desc_override, and where does the
> data come from? Not explained anywhere.

Fair enough; it's a pretty standard HID descriptor override, but you're 
right that we're usually replacing it in a bit more verbose way. Julian, 
could you please run that descriptor through something like HID descriptor 
tool, and send me a patch that reformats it? (for the way we usually do 
this, look for example in hid-sony.c).

I'll drop this commit and resend the pull request (as namely the steam fix 
really should go in).

The plan eventually is to offload all this crazy rdesc replacing to 
userspace, but that is still WIP.

Thanks,

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* Re: [GIT PULL] HID fixes
  2018-06-19 12:00 Jiri Kosina
@ 2018-06-20  1:51 ` Linus Torvalds
  2018-06-20  4:19   ` Jiri Kosina
  0 siblings, 1 reply; 73+ messages in thread
From: Linus Torvalds @ 2018-06-20  1:51 UTC (permalink / raw)
  To: Jiri Kosina, Julian Sax, Hans de Goede, Benjamin Tissoires
  Cc: Linux Kernel Mailing List

On Tue, Jun 19, 2018 at 9:00 PM Jiri Kosina <jikos@kernel.org> wrote:
>
> - i2c-hid fix for devices (such as SIPODEV SP1064) that fail to provide
>   their report descriptor, from Julian Sax

I'm not taking this crazy stuff after the merge window.

Even *during* the merge window this would probably have made me go
"WTF? Eww!" if I  had noticed.

What is that odd binary blob i2c_hid_desc_override, and where does the
data come from? Not explained anywhere.

We don't just add random binary data without explaining it.

                      Linus

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2018-06-19 12:00 Jiri Kosina
  2018-06-20  1:51 ` Linus Torvalds
  0 siblings, 1 reply; 73+ messages in thread
From: Jiri Kosina @ 2018-06-19 12:00 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive -rc HID fixes:

=====
- Wacom 2nd-gen Intuos Pro large Y axis handling fix from Jason Gerecke
- Fix for hibernation in Intel ISH driver, from Even Xu
- Crash fix for hid-steam driver, from Rodrigo Rivas Costa
- i2c-hid fix for devices (such as SIPODEV SP1064) that fail to provide
  their report descriptor, from Julian Sax
- new device ID addition to google-hammer driver
=====

Thanks.

----------------------------------------------------------------
Even Xu (1):
      HID: intel_ish-hid: ipc: register more pm callbacks to support hibernation

Jason Gerecke (1):
      HID: wacom: Correct logical maximum Y for 2nd-gen Intuos Pro large

Julian Sax (1):
      HID: i2c-hid: override HID descriptors for certain devices

Nicolas Boichat (1):
      HID: google: Add support for whiskers

Rodrigo Rivas Costa (1):
      HID: steam: use hid_device.driver_data instead of hid_set_drvdata()

 drivers/hid/hid-google-hammer.c                   |   2 +
 drivers/hid/hid-ids.h                             |   1 +
 drivers/hid/hid-steam.c                           |  10 +-
 drivers/hid/i2c-hid/Makefile                      |   3 +
 drivers/hid/i2c-hid/{i2c-hid.c => i2c-hid-core.c} |  58 ++++++---
 drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c          | 149 ++++++++++++++++++++++
 drivers/hid/i2c-hid/i2c-hid.h                     |  17 +++
 drivers/hid/intel-ish-hid/ipc/pci-ish.c           |  22 +---
 drivers/hid/wacom_sys.c                           |   8 ++
 9 files changed, 230 insertions(+), 40 deletions(-)
 rename drivers/hid/i2c-hid/{i2c-hid.c => i2c-hid-core.c} (96%)
 create mode 100644 drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c
 create mode 100644 drivers/hid/i2c-hid/i2c-hid.h

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2018-04-19  8:05 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2018-04-19  8:05 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive fixes for HID subsystem:

=====
- suspend/resume handling fix for Raydium I2C-connected touchscreen from 
  Aaron Ma
- protocol fixup for certain BT-connected Wacoms from Aaron Armstrong 
  Skomra 
- battery level reporting fix on BT-connected mice from Dmitry Torokhov
- hidraw race condition fix from Rodrigo Rivas Costa
=====

Thanks.

----------------------------------------------------------------
Aaron Armstrong Skomra (1):
      HID: wacom: bluetooth: send exit report for recent Bluetooth devices

Aaron Ma (1):
      HID: i2c-hid: Fix resume issue on Raydium touchscreen device

Dmitry Torokhov (1):
      HID: input: fix battery level reporting on BT mice

Jiri Kosina (1):
      HID: i2c-hid: fix inverted return value from i2c_hid_command()

Rodrigo Rivas Costa (1):
      HID: hidraw: Fix crash on HIDIOCGFEATURE with a destroyed device

 drivers/hid/hid-ids.h         |  3 ++
 drivers/hid/hid-input.c       | 24 ++++++++++----
 drivers/hid/hidraw.c          |  5 +++
 drivers/hid/i2c-hid/i2c-hid.c | 13 ++++++++
 drivers/hid/wacom_wac.c       | 76 ++++++++++++++++++++++++++-----------------
 include/linux/hid.h           |  9 ++++-
 6 files changed, 92 insertions(+), 38 deletions(-)

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2017-10-12 12:46 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2017-10-12 12:46 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive

=====
- fix for potential out-of-bounds memory access (found by fuzzing, likely 
  requires specially crafted device to trigger) by Jaejoong Kim
- two new device IDs for elecom driver from Alex Manoussakis
=====

Thank you.

----------------------------------------------------------------
Alex Manoussakis (1):
      HID: hid-elecom: extend to fix descriptor for HUGE trackball

Jaejoong Kim (1):
      HID: usbhid: fix out-of-bounds bug

 drivers/hid/Kconfig           |  1 +
 drivers/hid/hid-core.c        |  2 ++
 drivers/hid/hid-elecom.c      | 13 +++++++++----
 drivers/hid/hid-ids.h         |  2 ++
 drivers/hid/usbhid/hid-core.c | 12 +++++++++++-
 5 files changed, 25 insertions(+), 5 deletions(-)

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2017-10-05  8:58 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2017-10-05  8:58 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive HID subsystem fixes

=====
- buffer management size fix for i2c-hid driver, from Adrian Salido
- tool ID regression fixes for Wacom driver from Jason Gerecke
- a few small assorted fixes and a few device ID additions
=====

Thanks.

----------------------------------------------------------------
Aaron Armstrong Skomra (1):
      HID: wacom: leds: Don't try to control the EKR's read-only LEDs

Adrian Salido (1):
      HID: i2c-hid: allocate hid buffers for real worst case

Dmitry Torokhov (1):
      HID: hidraw: fix power sequence when closing device

Hans de Goede (1):
      HID: multitouch: Fix system-control buttons not working

Jason Gerecke (5):
      HID: wacom: Properly report negative values from Intuos Pro 2 Bluetooth
      HID: wacom: Correct coordinate system of touchring and pen twist
      HID: wacom: generic: Send MSC_SERIAL and ABS_MISC when leaving prox
      HID: wacom: generic: Clear ABS_MISC when tool leaves proximity
      HID: wacom: Always increment hdev refcount within wacom_get_hdev_data

Kai-Heng Feng (1):
      Revert "HID: multitouch: Support ALPS PTP stick with pid 0x120A"

Lyude (1):
      HID: rmi: Make sure the HID device is opened on resume

Nicholas Bishop (1):
      HID: add multi-input quirk for IDC6680 touchscreen

Pavel Tatashin (1):
      HID: multitouch: support buttons and trackpoint on Lenovo X1 Tab Gen2

Ping Cheng (1):
      HID: wacom: bits shifted too much for 9th and 10th buttons

Shrirang Bagul (1):
      HID: multitouch: Support ALPS PTP stick with pid 0x120A

 drivers/hid/hid-ids.h           |   2 +
 drivers/hid/hid-multitouch.c    |   7 +++
 drivers/hid/hid-rmi.c           |  13 +++--
 drivers/hid/hidraw.c            |   2 +-
 drivers/hid/i2c-hid/i2c-hid.c   |   3 +-
 drivers/hid/usbhid/hid-quirks.c |   1 +
 drivers/hid/wacom_sys.c         |   7 ++-
 drivers/hid/wacom_wac.c         | 110 ++++++++++++++++++++++++++++++++--------
 8 files changed, 118 insertions(+), 27 deletions(-)

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2017-06-20  9:01 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2017-06-20  9:01 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive two small HID subsystem fixes

=====
- revert of a commit to magicmouse driver that regressess certain devices, 
  from Daniel Stone
- quirk for a specific Dell mouse, from Sebastian Parschauer
=====

Thanks.

----------------------------------------------------------------
Daniel Stone (1):
      Revert "HID: magicmouse: Set multi-touch keybits for Magic Mouse"

Sebastian Parschauer (1):
      HID: Add quirk for Dell PIXART OEM mouse

 drivers/hid/hid-ids.h           |  3 +++
 drivers/hid/hid-magicmouse.c    | 15 +++++++--------
 drivers/hid/usbhid/hid-quirks.c |  1 +
 3 files changed, 11 insertions(+), 8 deletions(-)

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2017-03-31  8:01 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2017-03-31  8:01 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to get HID fixes:

- Wacom regression fixes, from Aaron Armstrong Skomra
- new device ID addition by Peter Stein

Thanks.

----------------------------------------------------------------
Aaron Armstrong Skomra (2):
      HID: wacom: Don't add ghost interface as shared data
      HID: wacom: call _query_tablet_data() for BAMBOO_TOUCH

Peter Stein (1):
      HID: xinmo: fix for out of range for THT 2P arcade controller.

 drivers/hid/hid-core.c  |  1 +
 drivers/hid/hid-ids.h   |  1 +
 drivers/hid/hid-xinmo.c |  1 +
 drivers/hid/wacom_sys.c | 18 ++++++++++--------
 4 files changed, 13 insertions(+), 8 deletions(-)

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2017-01-31 12:13 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2017-01-31 12:13 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive fixes for HID subsystem.

=====
- regression fix (sleeping while atomic) for cp2112, from Johan Hovold
- regression fix for proximity handling under certain circumstances in
  Wacom driver, from Jason Gerecke
- functional fix for Logitech Rumblepad 2, from Ardinartsev Nikita
=====

Thanks.

----------------------------------------------------------------
Ardinartsev Nikita (1):
      HID: hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

Colin Ian King (1):
      HID: usbhid: Quirk a AMI virtual mouse and keyboard with ALWAYS_POLL

Jason Gerecke (1):
      HID: wacom: Fix poor prox handling in 'wacom_pl_irq'

Johan Hovold (2):
      HID: cp2112: fix sleep-while-atomic
      HID: cp2112: fix gpio-callback error handling

 drivers/hid/hid-cp2112.c        | 28 ++++++++++++----------------
 drivers/hid/hid-ids.h           |  3 +++
 drivers/hid/hid-lg.c            |  2 +-
 drivers/hid/usbhid/hid-quirks.c |  1 +
 drivers/hid/wacom_wac.c         | 28 +++++++++++++++-------------
 5 files changed, 32 insertions(+), 30 deletions(-)

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2017-01-19 13:29 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2017-01-19 13:29 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive:

=====
- regression fix for generic Wacom devices, from Jason Gerecke
- DMA-on-stack fixes for hid-corsair driver, from Johan Hovold
=====

Thanks.

----------------------------------------------------------------
Jason Gerecke (1):
      HID: wacom: Fix sibling detection regression

Johan Hovold (2):
      HID: corsair: fix DMA buffers on stack
      HID: corsair: fix control-transfer error handling

 drivers/hid/hid-corsair.c | 60 +++++++++++++++++++++++++++++++++++------------
 drivers/hid/wacom_sys.c   | 16 ++++++-------
 drivers/hid/wacom_wac.c   | 10 ++++++++
 3 files changed, 63 insertions(+), 23 deletions(-)

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2016-11-07 10:01 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2016-11-07 10:01 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive -rc fixes for HID subsystem:

=====
- modprobe-after-rmmod load failure bugfix for intel-ish, from Even Xu
- IRQ probing bugfix for intel-ish, from Srinivas Pandruvada
- attribute parsing fix in hid-sensor, from Ooi, Joyce
- other small misc fixes / quirky device additions
=====

Thanks!

----------------------------------------------------------------
Borislav Petkov (1):
      HID: intel-ish-hid: Fix !CONFIG_PM build warning

Even Xu (3):
      HID: intel-ish-hid: consolidate ish wake up operation
      HID: intel-ish-hid: Move DMA disable code to new function
      HID: intel-ish-hid: Fix driver reinit failure

Oliver Neukum (1):
      HID: usbhid: add ATEN CS962 to list of quirky devices

Ooi, Joyce (1):
      HID: sensor: fix attributes in HID sensor interface

Srinivas Pandruvada (2):
      HID: sensor-hub: Fix packing of result buffer for feature report
      HID: intel-ish-hid: request_irq failure

 drivers/hid/hid-ids.h                   |   1 +
 drivers/hid/hid-sensor-custom.c         |   6 +-
 drivers/hid/hid-sensor-hub.c            |  15 ++++-
 drivers/hid/intel-ish-hid/ipc/ipc.c     | 102 +++++++++++++++++++++++---------
 drivers/hid/intel-ish-hid/ipc/pci-ish.c |   6 +-
 drivers/hid/usbhid/hid-quirks.c         |   1 +
 6 files changed, 95 insertions(+), 36 deletions(-)

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 73+ messages in thread

* [GIT PULL] HID fixes
@ 2015-02-23 22:37 Jiri Kosina
  0 siblings, 0 replies; 73+ messages in thread
From: Jiri Kosina @ 2015-02-23 22:37 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

Linus,

please pull from

  git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus

to receive fixes for HID code:

- a few fixes to Sony driver (rmmod breakage, spinlock initialization),
  by Antonio Ospite, Frank Praznik and Jiri Kosina
- fix for wMaxInputLength handling regression in i2c-hid, by Seth Forshee
- IRQ safety spinlock fix in sensor hub driver, by Srinivas Pandruvada
- IRQ level sensitivity fix to i2c-hid to be compliant with the spec, by 
  Mika Westerberg
- a couple device ID additions piggy-backing on top of that

Thanks!

----------------------------------------------------------------
Antonio Ospite (1):
      HID: sony: Fix a WARNING shown when rmmod-ing the driver

Darren Salt (1):
      HID: saitek: add USB ID for older R.A.T. 7

Frank Praznik (1):
      HID: sony: fix uninitialized per-controller spinlock

Jakub Sitnicki (1):
      HID: microsoft: Add ID for NE7K wireless keyboard

Jiri Kosina (1):
      HID: sony: initialize sony_dev_list_lock properly

Mika Westerberg (1):
      HID: i2c-hid: The interrupt should be level sensitive

Ping Cheng (1):
      HID: wacom: Add missing ABS_MISC event and feature declaration for 27QHD

Seth Forshee (1):
      HID: i2c-hid: Limit reads to wMaxInputLength bytes for input events

Srinivas Pandruvada (2):
      HID: hid-sensor-hub: Correct documentation
      HID: sensor-hub: correct dyn_callback_lock IRQ-safe change

 drivers/hid/hid-core.c         |  2 ++
 drivers/hid/hid-ids.h          |  2 ++
 drivers/hid/hid-microsoft.c    |  2 ++
 drivers/hid/hid-saitek.c       |  2 ++
 drivers/hid/hid-sensor-hub.c   |  8 +++++---
 drivers/hid/hid-sony.c         |  6 ++++--
 drivers/hid/i2c-hid/i2c-hid.c  |  7 +++++--
 drivers/hid/wacom_wac.c        | 11 ++++++++---
 include/linux/hid-sensor-hub.h |  5 +++++
 9 files changed, 35 insertions(+), 10 deletions(-)

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 73+ messages in thread

end of thread, other threads:[~2021-11-24 18:31 UTC | newest]

Thread overview: 73+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 12:06 [GIT PULL] HID fixes Jiri Kosina
2021-07-30 18:11 ` pr-tracker-bot
  -- strict thread matches above, loose matches on Subject: below --
2021-11-24  7:10 Jiri Kosina
2021-11-24 18:31 ` pr-tracker-bot
2021-09-27 13:54 Jiri Kosina
2021-09-27 17:25 ` pr-tracker-bot
2021-06-01 21:58 Jiri Kosina
2021-06-02  3:58 ` pr-tracker-bot
2021-04-15 13:51 Jiri Kosina
2021-04-15 18:15 ` pr-tracker-bot
2021-01-28  8:38 Jiri Kosina
2021-01-28 18:16 ` pr-tracker-bot
2021-01-14 12:33 Jiri Kosina
2021-01-14 21:55 ` pr-tracker-bot
2020-11-22 21:18 Jiri Kosina
2020-11-22 22:40 ` pr-tracker-bot
2020-09-02 18:58 Jiri Kosina
2020-09-02 20:08 ` pr-tracker-bot
2020-08-25  8:14 Jiri Kosina
2020-08-25 19:16 ` pr-tracker-bot
2020-07-17 12:01 Jiri Kosina
2020-07-17 17:40 ` pr-tracker-bot
2020-03-17 13:41 Jiri Kosina
2020-03-17 17:10 ` pr-tracker-bot
2020-02-27 14:46 Jiri Kosina
2020-02-27 19:40 ` pr-tracker-bot
2020-01-09 14:23 Jiri Kosina
2020-01-09 19:14 ` Linus Torvalds
2020-01-09 19:25   ` Dmitry Torokhov
2020-01-09 19:37   ` Jiri Kosina
2020-01-09 20:38     ` Jiri Kosina
2020-01-09 23:36       ` Linus Torvalds
2020-01-09 23:41         ` Linus Torvalds
2020-01-10 14:31           ` Jiri Kosina
2020-01-09 19:15 ` pr-tracker-bot
2019-11-07 19:32 Jiri Kosina
2019-11-07 20:00 ` pr-tracker-bot
2019-08-20 12:53 Jiri Kosina
2019-08-20 18:55 ` pr-tracker-bot
2019-08-06 10:59 Jiri Kosina
2019-08-06 18:55 ` pr-tracker-bot
2019-06-27  9:37 Jiri Kosina
2019-06-28  0:45 ` pr-tracker-bot
2019-04-03 13:39 Jiri Kosina
2019-04-03 16:25 ` pr-tracker-bot
2019-01-22  9:46 Jiri Kosina
2019-01-22 18:55 ` pr-tracker-bot
2018-12-10 16:05 Jiri Kosina
2018-12-10 20:20 ` pr-tracker-bot
2018-11-24 20:19 Jiri Kosina
2018-11-24 23:15 ` pr-tracker-bot
2018-11-07 10:31 Jiri Kosina
2018-11-07 17:07 ` Linus Torvalds
2018-10-03  8:55 Jiri Kosina
2018-10-03 11:50 ` Greg Kroah-Hartman
2018-09-11  7:49 Jiri Kosina
2018-07-09 12:54 Jiri Kosina
2018-06-19 12:00 Jiri Kosina
2018-06-20  1:51 ` Linus Torvalds
2018-06-20  4:19   ` Jiri Kosina
2018-06-20  7:06     ` Hans de Goede
2018-06-20  7:12       ` Linus Torvalds
2018-06-20  7:15         ` Jiri Kosina
2018-06-20  7:35           ` Benjamin Tissoires
2018-04-19  8:05 Jiri Kosina
2017-10-12 12:46 Jiri Kosina
2017-10-05  8:58 Jiri Kosina
2017-06-20  9:01 Jiri Kosina
2017-03-31  8:01 Jiri Kosina
2017-01-31 12:13 Jiri Kosina
2017-01-19 13:29 Jiri Kosina
2016-11-07 10:01 Jiri Kosina
2015-02-23 22:37 Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).