From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE30C4338F for ; Fri, 20 Aug 2021 13:01:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F62560F91 for ; Fri, 20 Aug 2021 13:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240622AbhHTNC1 (ORCPT ); Fri, 20 Aug 2021 09:02:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:42352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238220AbhHTNCZ (ORCPT ); Fri, 20 Aug 2021 09:02:25 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 240D760F91; Fri, 20 Aug 2021 13:01:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629464507; bh=hR9/dWKch9bWcZVekLGpeTN+QgH+wrPKEnQu7sKE6gE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=iL5B0OnfS09Z6jgzNGIvcQFyqKtx0MIgVwjS6nXRztExcUS2/6XSytizisvwUSaBH A0JSHcr9CVtXdkxzt+kWsv5yS6u1cwiRgw5/B3WFYCgaMIs4xP6ri3x92TnItlwdzH 6kLmpnpPgryp0SPPhYNqZh2RrqypcTQFBX9LbS6VjLhq+qXmPuGwzdRKiDm9GaBC0W Moy8HGrP/pCRHSH5Q0Qki/1eY7EPHmaczPRKJqimZYN33s08zrijFsE31SDeyowHxm E813jEqNaw7/Y6UHsN6VohsEPFQRSsv7+AeRbyiCVrSmxRUiseUY+uVSBXeikij8vf +8lrCMkrSIN7A== Date: Fri, 20 Aug 2021 15:01:43 +0200 (CEST) From: Jiri Kosina To: Kees Cook cc: linux-kernel@vger.kernel.org, Benjamin Tissoires , linux-input@vger.kernel.org, "Gustavo A. R. Silva" , Greg Kroah-Hartman , Andrew Morton , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-staging@lists.linux.dev, linux-block@vger.kernel.org, linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com, Rasmus Villemoes , linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 22/63] HID: cp2112: Use struct_group() for memcpy() region In-Reply-To: <20210818060533.3569517-23-keescook@chromium.org> Message-ID: References: <20210818060533.3569517-1-keescook@chromium.org> <20210818060533.3569517-23-keescook@chromium.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Aug 2021, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring fields. > > Use struct_group() in struct cp2112_string_report around members report, > length, type, and string, so they can be referenced together. This will > allow memcpy() and sizeof() to more easily reason about sizes, improve > readability, and avoid future warnings about writing beyond the end of > report. > > "pahole" shows no size nor member offset changes to struct > cp2112_string_report. "objdump -d" shows no meaningful object > code changes (i.e. only source line number induced differences.) > > Cc: Jiri Kosina > Cc: Benjamin Tissoires > Cc: linux-input@vger.kernel.org > Signed-off-by: Kees Cook Applied, thanks. -- Jiri Kosina SUSE Labs