From: Jiri Kosina <jikos@kernel.org>
To: "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, paskripkin@gmail.com
Subject: Re: [PATCH v3] HID: betop: fix slab-out-of-bounds Write in betop_probe
Date: Wed, 15 Sep 2021 16:31:48 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2109151631410.15944@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210824150730.9118-1-asha.16@itfac.mrt.ac.lk>
On Tue, 24 Aug 2021, F.A.Sulaiman wrote:
> Syzbot reported slab-out-of-bounds Write bug in hid-betopff driver.
> The problem is the driver assumes the device must have an input report but
> some malicious devices violate this assumption.
>
> So this patch checks hid_device's input is non empty before it's been used.
>
> Reported-by: syzbot+07efed3bc5a1407bd742@syzkaller.appspotmail.com
> Signed-off-by: F.A. SULAIMAN <asha.16@itfac.mrt.ac.lk>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-09-15 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 20:15 [PATCH] fix slab-out-of-bounds Write in betop_probe F.A.Sulaiman
2021-08-17 0:05 ` kernel test robot
2021-08-17 0:35 ` kernel test robot
2021-08-17 20:58 ` kernel test robot
2021-08-19 18:47 ` Jiri Kosina
2021-08-22 13:43 ` [PATCH v2] HID: betop: " F.A.Sulaiman
2021-08-22 16:01 ` Pavel Skripkin
2021-08-24 15:07 ` [PATCH v3] " F.A.Sulaiman
2021-08-24 15:12 ` Pavel Skripkin
2021-09-15 14:31 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2109151631410.15944@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=asha.16@itfac.mrt.ac.lk \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paskripkin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).