From: Jiri Kosina <jikos@kernel.org>
To: Aditya Garg <gargaditya08@live.com>
Cc: "alexhenrie24@gmail.com" <alexhenrie24@gmail.com>,
"benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"paul@mrarm.io" <paul@mrarm.io>, Aun-Ali Zaidi <admin@kodeit.net>,
Orlando Chamberlain <redecorating@protonmail.com>
Subject: Re: [PATCH v2 1/3] HID: apple: Add support for keyboard backlight on certain T2 Macs.
Date: Mon, 14 Feb 2022 10:55:51 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2202141054070.11721@cbobk.fhfr.pm> (raw)
In-Reply-To: <1088ECFE-B356-4731-AC8A-09A4421DD7D1@live.com>
On Thu, 3 Feb 2022, Aditya Garg wrote:
>
>
> > On 24-Jan-2022, at 8:38 PM, Aditya Garg <gargaditya08@live.com> wrote:
> >
> > From: Paul Pawlowski <paul@mrarm.io>
> >
> > This patch introduces the requisite plumbing for supporting keyboard
> > backlight on T2-attached, USB exposed models. The quirk mechanism was
> > used to reuse the existing hid-apple driver.
> >
> > Signed-off-by: Paul Pawlowski <paul@mrarm.io>
> > Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
> > Signed-off-by: Aditya Garg <gargaditya08@live.com>
> > ---
> > drivers/hid/hid-apple.c | 125 ++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 125 insertions(+)
> >
> > diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> > index 24802a4a6..c22d445a9 100644
> > --- a/drivers/hid/hid-apple.c
> > +++ b/drivers/hid/hid-apple.c
> > @@ -7,6 +7,7 @@
> > * Copyright (c) 2005 Michael Haboustak <mike-@cinci.rr.com> for Concept2, Inc
> > * Copyright (c) 2006-2007 Jiri Kosina
> > * Copyright (c) 2008 Jiri Slaby <jirislaby@gmail.com>
> > + * Copyright (c) 2019 Paul Pawlowski <paul@mrarm.io>
> > */
> >
> > /*
> > @@ -33,6 +34,7 @@
> > /* BIT(7) reserved, was: APPLE_IGNORE_HIDINPUT */
> > #define APPLE_NUMLOCK_EMULATION BIT(8)
> > #define APPLE_RDESC_BATTERY BIT(9)
> > +#define APPLE_BACKLIGHT_CTL 0x0200
> Jiri, should it be BIT(10)? 0x0200 is BIT(9) if I ain’t wrong.
Yes, please use BIT(10). Thanks,
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2022-02-14 10:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 15:08 [PATCH v2 1/3] HID: apple: Add support for keyboard backlight on certain T2 Macs Aditya Garg
2022-01-24 15:09 ` [PATCH v2 2/3] HID: apple: Add necessary IDs and configuration for " Aditya Garg
2022-01-24 15:10 ` [PATCH v2 3/3] HID: apple: Add fn mapping for MacBook Pros with Touch Bar Aditya Garg
2022-01-31 12:05 ` [PATCH v2 1/3] HID: apple: Add support for keyboard backlight on certain T2 Macs Aditya Garg
2022-02-02 13:40 ` Jiri Kosina
2022-02-02 14:18 ` Aditya Garg
2022-02-03 12:15 ` Aditya Garg
2022-02-03 12:21 ` [PATCH v3 " Aditya Garg
2022-02-03 12:22 ` [PATCH v3 2/3] HID: apple: Add necessary IDs and configuration for " Aditya Garg
2022-02-03 12:23 ` [PATCH v3 3/3] HID: apple: Add fn mapping for MacBook Pros with Touch Bar Aditya Garg
2022-02-16 15:57 ` Jiri Kosina
2022-02-14 9:55 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2202141054070.11721@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=admin@kodeit.net \
--cc=alexhenrie24@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=gargaditya08@live.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@mrarm.io \
--cc=redecorating@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).