From: Jiri Kosina <jikos@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Stephen Boyd <swboyd@chromium.org>,
Sean O'Brien <seobrien@chromium.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: vivaldi: fix sysfs attributes leak
Date: Tue, 1 Mar 2022 15:31:46 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2203011531370.11721@cbobk.fhfr.pm> (raw)
In-Reply-To: <YhmAAjNeTjiNoLlJ@google.com>
On Fri, 25 Feb 2022, Dmitry Torokhov wrote:
> The driver creates the top row map sysfs attribute in input_configured()
> method; unfortunately we do not have a callback that is executed when HID
> interface is unbound, thus we are leaking these sysfs attributes, for
> example when device is disconnected.
>
> To fix it let's switch to managed version of adding sysfs attributes which
> will ensure that they are destroyed when the driver is unbound.
>
> Fixes: 14c9c014babe ("HID: add vivaldi HID driver")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
>
> Compiled only.
>
> drivers/hid/hid-vivaldi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-vivaldi.c b/drivers/hid/hid-vivaldi.c
> index efa6140915f4..42ceb2058a09 100644
> --- a/drivers/hid/hid-vivaldi.c
> +++ b/drivers/hid/hid-vivaldi.c
> @@ -144,7 +144,7 @@ static void vivaldi_feature_mapping(struct hid_device *hdev,
> static int vivaldi_input_configured(struct hid_device *hdev,
> struct hid_input *hidinput)
> {
> - return sysfs_create_group(&hdev->dev.kobj, &input_attribute_group);
> + return devm_device_add_group(&hdev->dev, &input_attribute_group);
> }
>
> static const struct hid_device_id vivaldi_table[] = {
Applied, thanks Dmitry.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2022-03-01 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 1:18 [PATCH] HID: vivaldi: fix sysfs attributes leak Dmitry Torokhov
2022-02-26 4:55 ` Stephen Boyd
2022-02-26 6:00 ` Dmitry Torokhov
2022-03-01 14:31 ` Jiri Kosina [this message]
2022-03-08 21:13 ` Dmitry Torokhov
2022-03-09 10:42 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2203011531370.11721@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seobrien@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).