From: Jiri Kosina <jikos@kernel.org>
To: "José Expósito" <jose.exposito89@gmail.com>
Cc: benjamin.tissoires@redhat.com, spbnick@gmail.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] HID: uclogic: Add missing suffix for digitalizers
Date: Thu, 25 Aug 2022 10:25:08 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2208251025020.19850@cbobk.fhfr.pm> (raw)
In-Reply-To: <20220815142615.17965-1-jose.exposito89@gmail.com>
On Mon, 15 Aug 2022, José Expósito wrote:
> The Pen (0x02) application usage was changed to Digitalizer (0x01) in
> commit f7d8e387d9ae ("HID: uclogic: Switch to Digitizer usage for
> styluses"). However, a suffix was not selected for the new usage.
>
> Handle the digitalizer application usage in uclogic_input_configured()
> and add the required suffix.
>
> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
>
> ---
>
> Kindly resending this patch so it doesn't get lost after the merge
> window.
> ---
> drivers/hid/hid-uclogic-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-uclogic-core.c b/drivers/hid/hid-uclogic-core.c
> index 47a17375c7fc..ff46604ef1d8 100644
> --- a/drivers/hid/hid-uclogic-core.c
> +++ b/drivers/hid/hid-uclogic-core.c
> @@ -153,6 +153,7 @@ static int uclogic_input_configured(struct hid_device *hdev,
> suffix = "Pad";
> break;
> case HID_DG_PEN:
> + case HID_DG_DIGITIZER:
> suffix = "Pen";
> break;
> case HID_CP_CONSUMER_CONTROL:
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2022-08-25 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 14:26 [PATCH RESEND] HID: uclogic: Add missing suffix for digitalizers José Expósito
2022-08-25 8:25 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2208251025020.19850@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jose.exposito89@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spbnick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).