From: Jiri Kosina <jikos@kernel.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Florent Revest <revest@chromium.org>,
Jon Hunter <jonathanh@nvidia.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] HID: bpf: enforce HID_BPF dependencies
Date: Fri, 2 Dec 2022 01:40:04 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2212020135390.6045@cbobk.fhfr.pm> (raw)
In-Reply-To: <20221130101021.1868764-2-benjamin.tissoires@redhat.com>
On Wed, 30 Nov 2022, Benjamin Tissoires wrote:
> As mentioned in the link below, having JIT and BPF is not enough to
> have fmod_ret and error injection APIs. This resolves the error that
> happens on a system without tracing enabled when hid-bpf tries to
> load itself.
>
> Link: https://lore.kernel.org/r/CABRcYmKyRchQhabi1Vd9RcMQFCcb=EtWyEbFDFRTc-L-U8WhgA@mail.gmail.com
> Fixes: f5c27da4e3c8 ("HID: initial BPF implementation")
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
> drivers/hid/bpf/Kconfig | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/bpf/Kconfig b/drivers/hid/bpf/Kconfig
> index 298634fc3335..498232f9faa9 100644
> --- a/drivers/hid/bpf/Kconfig
> +++ b/drivers/hid/bpf/Kconfig
> @@ -4,7 +4,9 @@ menu "HID-BPF support"
> config HID_BPF
> bool "HID-BPF support"
> default HID_SUPPORT
> - depends on BPF && BPF_SYSCALL
> + depends on BPF && BPF_SYSCALL && \
> + DYNAMIC_FTRACE_WITH_DIRECT_CALLS && \
> + FUNCTION_ERROR_INJECTION
FUNCTION_ERROR_INJECTION is a purely debugging feature, and not something
we want to have enabled in production kernels (which is where HID-BPF
should, on the other hand, be enabled). I am afraid this needs to go back
to the drawing board.
JFTR, to make sure this gets properly discussed before 6.2 merge window
opens up
Nacked-by: Jiri Kosina <jkosina@suse.cz>
Which unfortunately means the whole hid-bpf implementation would need to
be revised and postponed for 6.3 at least.
Sorry,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2022-12-02 0:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 10:10 [PATCH 0/2] HID-BPF: Kconfig fix Benjamin Tissoires
2022-11-30 10:10 ` [PATCH 1/2] HID: bpf: enforce HID_BPF dependencies Benjamin Tissoires
2022-12-01 13:13 ` Jon Hunter
2022-12-02 0:40 ` Jiri Kosina [this message]
2022-11-30 10:10 ` [PATCH 2/2] selftests: hid: ensures we have the proper requirements in config Benjamin Tissoires
2022-11-30 11:19 ` [PATCH 0/2] HID-BPF: Kconfig fix Florent Revest
2022-12-01 10:08 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2212020135390.6045@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jonathanh@nvidia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=revest@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).