From: Jiri Kosina <jikos@kernel.org>
To: Takahiro Fujii <fujii@xaxxi.net>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: elecom: add support for TrackBall 056E:011C
Date: Fri, 20 Jan 2023 18:45:19 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2301201844460.1734@cbobk.fhfr.pm> (raw)
In-Reply-To: <20230119183002.352852-1-fujii@xaxxi.net>
On Fri, 20 Jan 2023, Takahiro Fujii wrote:
> Make function buttons on ELECOM M-HT1DRBK trackball mouse work. This model
> has two devices with different device IDs (010D and 011C). Both of
> them misreports the number of buttons as 5 in the report descriptor, even
> though they have 8 buttons. hid-elecom overwrites the report to fix them,
> but supports only on 010D and does not work on 011C. This patch fixes
> 011C in the similar way but with specialized position parameters.
> In fact, it is sufficient to rewrite only 17th byte (05 -> 08). However I
> followed the existing way.
Applied, thanks.
> Signed-off-by: Takahiro Fujii <fujii@xaxxi.net>
> ---
> drivers/hid/hid-elecom.c | 16 ++++++++++++++--
> drivers/hid/hid-ids.h | 3 ++-
> drivers/hid/hid-quirks.c | 3 ++-
> 3 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-elecom.c b/drivers/hid/hid-elecom.c
> index e59e9911fc37..4fa45ee77503 100644
> --- a/drivers/hid/hid-elecom.c
> +++ b/drivers/hid/hid-elecom.c
> @@ -12,6 +12,7 @@
> * Copyright (c) 2017 Alex Manoussakis <amanou@gnu.org>
> * Copyright (c) 2017 Tomasz Kramkowski <tk@the-tk.com>
> * Copyright (c) 2020 YOSHIOKA Takuma <lo48576@hard-wi.red>
> + * Copyright (c) 2022 Takahiro Fujii <fujii@xaxxi.net>
A minor nit: next time please consider not adding copyright notice just
for device ID additions, we usually don't do that.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2023-01-20 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 18:30 [PATCH] HID: elecom: add support for TrackBall 056E:011C Takahiro Fujii
2023-01-20 17:45 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2301201844460.1734@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=fujii@xaxxi.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).