From: Jan Engelhardt <jengelh@inai.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arch@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] linux++, this: rename "struct notifier_block *this"
Date: Fri, 19 Jun 2020 12:28:08 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.77.849.2006191217280.9730@n3.vanv.qr> (raw)
In-Reply-To: <20200619074631.GA1427@infradead.org>
On Friday 2020-06-19 09:46, Christoph Hellwig wrote:
>On Fri, Jun 19, 2020 at 12:06:45AM +0300, Alexey Dobriyan wrote:
>> Rename
>> struct notifier_block *this
>> to
>> struct notifier_block *nb
>>
>> "nb" is arguably a better name for notifier block.
>
>But not enough better to cause tons of pointless churn. Feel free
>to use better naming in new code you write or do significant changes
>to, but stop these pointless renames.
Well, judging from the mention of "linux++" in the subject, I figure
this is the old discussion of someone trying to make Linux code, or
parts thereof, work in a C++ environment. Since the patch does not just
touch headers but .c files, I deduce that there seems to be a project
trying to build Linux, or a subset thereof, as a C++ program for the fun
of it. UML could come to mind.
Is it a hot potato? Definitely. But so was IPv6 NAT, and now we have it
anyway.
next prev parent reply other threads:[~2020-06-19 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 21:06 [PATCH] linux++, this: rename "struct notifier_block *this" Alexey Dobriyan
2020-06-19 7:46 ` Christoph Hellwig
2020-06-19 10:28 ` Jan Engelhardt [this message]
2020-06-19 18:37 ` Linus Torvalds
2020-06-20 7:57 ` Alexey Dobriyan
2020-06-20 18:16 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.77.849.2006191217280.9730@n3.vanv.qr \
--to=jengelh@inai.de \
--cc=adobriyan@gmail.com \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).