From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Stefan Agner <stefan@agner.ch>, Arnd Bergmann <arnd@arndb.de>,
Roman Yeryomin <roman@advem.lv>,
Linus Walleij <linus.walleij@linaro.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Joel Stanley <joel@jms.id.au>,
Hans Ulli Kroll <ulli.kroll@googlemail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: copypage-fa: add kto and kfrom to input operands list
Date: Tue, 6 Nov 2018 08:25:12 -0500 (EST) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1811060823150.1498@knanqh.ubzr> (raw)
In-Reply-To: <6a59717f-8ae8-54f7-b948-b145171c82c3@arm.com>
On Tue, 6 Nov 2018, Robin Murphy wrote:
> On 06/11/2018 04:49, Nicolas Pitre wrote:
> [...]
> >> r3 and r5 are not used above, so no need to have them in the clobber
> >> list.
> >
> > They are used. ldrd and strd instructions always use a pair of
> > consecutive registers. So "ldrd r2, ..." loads into r2-r3 and "ldrd r4, ..."
> > loads into r4-r5.
>
> FWIW, since we should now be enabling unified syntax everywhere, I guess we
> could probably rewrite all those ldrd/strd to the UAL 3-operand form - i.e.
> "ldrd r2, r3, [...]" - if we really cared for the extra clarity.
Good idea. Worthy of a separate patch though.
Nicolas
next prev parent reply other threads:[~2018-11-06 13:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 22:16 [PATCH 1/2] ARM: copypage-fa: add kto and kfrom to input operands list Stefan Agner
2018-10-15 22:23 ` Russell King - ARM Linux
2018-10-15 22:39 ` Stefan Agner
2018-10-15 22:46 ` Russell King - ARM Linux
2018-10-15 22:52 ` Stefan Agner
2018-10-15 23:03 ` Russell King - ARM Linux
2018-10-16 8:00 ` Linus Walleij
2018-10-16 8:44 ` Russell King - ARM Linux
2018-10-16 11:35 ` Linus Walleij
2018-10-16 20:43 ` Nicolas Pitre
2018-10-16 21:59 ` Stefan Agner
2018-10-17 8:58 ` Arnd Bergmann
2018-10-17 9:04 ` [PATCH] [ALTERNATIVE] ARM: fix copypage functions for clang Arnd Bergmann
2018-10-17 9:35 ` Russell King - ARM Linux
2018-10-17 14:23 ` [PATCH 1/2] ARM: copypage-fa: add kto and kfrom to input operands list Nicolas Pitre
2018-11-05 23:00 ` Stefan Agner
2018-11-06 4:49 ` Nicolas Pitre
2018-11-06 13:16 ` Robin Murphy
2018-11-06 13:25 ` Nicolas Pitre [this message]
2018-11-07 16:27 ` Stefan Agner
2018-11-07 16:58 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1811060823150.1498@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=arnd@arndb.de \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robin.murphy@arm.com \
--cc=roman@advem.lv \
--cc=stefan@agner.ch \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).