From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stefan Agner <stefan@agner.ch>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH 1/2] ARM: Remove '-p' from LDFLAGS
Date: Wed, 5 Dec 2018 11:37:23 -0500 (EST) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1812051136470.3623@knanqh.ubzr> (raw)
In-Reply-To: <20181205014213.943-1-natechancellor@gmail.com>
On Tue, 4 Dec 2018, Nathan Chancellor wrote:
> This option is not supported by lld:
>
> ld.lld: error: unknown argument: -p
>
> This has been a no-op in binutils since 2004 (see commit dea514f51da1 in
> that tree). Given that the lowest officially supported of binutils for
> the kernel is 2.20, which was released in 2009, nobody needs this flag
> around so just remove it. Commit 1a381d4a0a9a ("arm64: remove no-op -p
> linker flag") did the same for arm64.
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Nicolas Pitre <nico@linaro.org>
> ---
> arch/arm/Makefile | 2 +-
> arch/arm/boot/compressed/Makefile | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 05a91d8b89f3..e2a0baf36766 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -10,7 +10,7 @@
> #
> # Copyright (C) 1995-2001 by Russell King
>
> -LDFLAGS_vmlinux :=-p --no-undefined -X --pic-veneer
> +LDFLAGS_vmlinux := --no-undefined -X --pic-veneer
> ifeq ($(CONFIG_CPU_ENDIAN_BE8),y)
> LDFLAGS_vmlinux += --be8
> KBUILD_LDFLAGS_MODULE += --be8
> diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
> index 1f5a5ffe7fcf..dcd07bd24b85 100644
> --- a/arch/arm/boot/compressed/Makefile
> +++ b/arch/arm/boot/compressed/Makefile
> @@ -131,8 +131,6 @@ endif
> ifeq ($(CONFIG_CPU_ENDIAN_BE8),y)
> LDFLAGS_vmlinux += --be8
> endif
> -# ?
> -LDFLAGS_vmlinux += -p
> # Report unresolved symbol references
> LDFLAGS_vmlinux += --no-undefined
> # Delete all temporary local symbols
> --
> 2.20.0.rc1
>
>
next prev parent reply other threads:[~2018-12-05 16:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 1:42 [PATCH 1/2] ARM: Remove '-p' from LDFLAGS Nathan Chancellor
2018-12-05 1:42 ` [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option Nathan Chancellor
2018-12-05 7:37 ` Ard Biesheuvel
2018-12-05 8:06 ` Nathan Chancellor
2018-12-05 8:09 ` Ard Biesheuvel
2018-12-05 18:21 ` Nick Desaulniers
2018-12-05 19:30 ` Peter Smith
2018-12-05 18:36 ` Nathan Chancellor
2018-12-05 18:39 ` Ard Biesheuvel
2018-12-05 18:41 ` Nick Desaulniers
2018-12-05 22:59 ` Stefan Agner
2018-12-05 23:19 ` Nick Desaulniers
2018-12-05 19:45 ` Nathan Chancellor
2018-12-05 21:03 ` Ard Biesheuvel
2018-12-29 12:27 ` Stefan Agner
2019-01-07 19:42 ` Nick Desaulniers
2018-12-05 18:40 ` Nick Desaulniers
2018-12-05 7:37 ` [PATCH 1/2] ARM: Remove '-p' from LDFLAGS Ard Biesheuvel
2018-12-05 16:37 ` Nicolas Pitre [this message]
2018-12-05 17:47 ` Nick Desaulniers
2018-12-29 12:49 ` Stefan Agner
2018-12-31 18:12 ` [PATCH v2] " Nathan Chancellor
2019-01-05 16:34 ` Nicolas Pitre
2019-01-07 19:19 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1812051136470.3623@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).