From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Stefan Agner <stefan@agner.ch>
Cc: linux@armlinux.org.uk, ndesaulniers@google.com,
natechancellor@gmail.com, arnd@arndb.de,
ard.biesheuvel@linaro.org, thierry.reding@gmail.com,
will.deacon@arm.com, julien.thierry@arm.com,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/5] ARM: convert to unified syntax
Date: Sun, 10 Feb 2019 16:24:45 -0500 (EST) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1902101620430.2213@knanqh.ubzr> (raw)
In-Reply-To: <cover.1549753425.git.stefan@agner.ch>
On Sun, 10 Feb 2019, Stefan Agner wrote:
> This patchset converts all assembly code to unified assembler
> language (UAL) compatible assembly code. From what I can tell,
> this mainly boils down to using conditional infixes instead of
> postfixes.
>
> Most of the conversion has been done using the following regular
> expression:
> find ./arch/arm/ -name "*.[hSc]" -exec sed -i -r \
> "s/^((\s*[._a-zA-Z0-9]*[\:\(])?\s*)([a-z]{3})(eq|ne|cs|hs|cc|lo|mi|pl|vs|vc|hi|ls|ge|lt|gt|le|al)([a-z]{1,2})(\s)/\1\3\5\4\6/"
> \
> {} \;
>
> The expression resulted in some false positives and missed some
> instances where infix conditionals have been used. With this
> changes applied, I compiled several kernel configurations
> successfully and without a warning.
>
> The file arch/arm/probes/kprobes/test-arm.c is still using some
> divided syntax assembler.
>
> This does not allow to use LLVM's integrated assembler just yet,
> there is still some assembler which the integrated assembler does
> not like (yet). But it is a big step towards that direction.
OK....
Please document why you added .syntax unified in the commit log of each
patch where this is added along with a link to the gcc PR. Then you may
add Acked-by: Nicolas Pitre <nico@linaro.org> to the whole series.
Nicolas
next prev parent reply other threads:[~2019-02-10 21:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 23:08 [PATCH v2 0/5] ARM: convert to unified syntax Stefan Agner
2019-02-09 23:08 ` [PATCH v2 1/5] ARM: use unified assembler in macros Stefan Agner
2019-02-09 23:08 ` [PATCH v2 2/5] ARM: use unified assembler in headers Stefan Agner
2019-02-09 23:09 ` [PATCH v2 3/5] ARM: use unified assembler in assembly files Stefan Agner
2019-02-09 23:09 ` [PATCH v2 4/5] ARM: use unified assembler in c files Stefan Agner
2019-02-09 23:09 ` [PATCH v2 5/5] ARM: warn if divided syntax assembler is used Stefan Agner
2019-02-11 18:03 ` Nick Desaulniers
2019-02-10 21:24 ` Nicolas Pitre [this message]
2019-02-12 19:31 ` [PATCH v2 0/5] ARM: convert to unified syntax Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1902101620430.2213@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).