From: Nicolas Pitre <npitre@baylibre.com>
To: Colin King <colin.king@canonical.com>
Cc: Boris Brezillon <bbrezillon@kernel.org>,
linux-i3c@lists.infradead.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] i3c/master: Fix uninitialized variable next_addr
Date: Tue, 24 Nov 2020 10:48:00 -0500 (EST) [thread overview]
Message-ID: <nycvar.YSQ.7.78.906.2011241046530.2184@knanqh.ubzr> (raw)
In-Reply-To: <20201124123504.396249-1-colin.king@canonical.com>
On Tue, 24 Nov 2020, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable next_addr is not initialized and is being used in a call
> to i3c_master_get_free_addr as a starting point to find the next address.
> Fix this by initializing next_addr to 0 to avoid an uninitialized garbage
> starting address from being used.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Nicolas Pitre <npitre@baylibre.com>
> ---
> drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> index 6dd234a82892..d97c3175e0e2 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> @@ -293,7 +293,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
> {
> struct hci_xfer *xfer;
> int ret, dat_idx = -1;
> - u8 next_addr;
> + u8 next_addr = 0;
> u64 pid;
> unsigned int dcr, bcr;
> DECLARE_COMPLETION_ONSTACK(done);
> --
> 2.29.2
>
>
prev parent reply other threads:[~2020-11-24 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 12:35 [PATCH][next] i3c/master: Fix uninitialized variable next_addr Colin King
2020-11-24 15:48 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.78.906.2011241046530.2184@knanqh.ubzr \
--to=npitre@baylibre.com \
--cc=bbrezillon@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).