From: "Michal Nazarewicz" <mina86@mina86.com>
To: "Marek Szyprowski" <m.szyprowski@samsung.com>,
"Mel Gorman" <mel@csn.ul.ie>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Andrew Morton" <akpm@linux-foundation.org>,
"KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
"Daniel Walker" <dwalker@codeaurora.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Jesse Barker" <jesse.barker@linaro.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Shariq Hasnain" <shariq.hasnain@linaro.org>,
"Chunsang Jeong" <chunsang.jeong@linaro.org>,
"Dave Hansen" <dave@linux.vnet.ibm.com>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>
Subject: Re: [PATCH 04/11] mm: page_alloc: introduce alloc_contig_range()
Date: Fri, 13 Jan 2012 21:04:31 +0100 [thread overview]
Message-ID: <op.v71gpt1b3l0zgt@mpn-glaptop> (raw)
In-Reply-To: <20120110141613.GB3910@csn.ul.ie>
> On Thu, Dec 29, 2011 at 01:39:05PM +0100, Marek Szyprowski wrote:
>> From: Michal Nazarewicz <mina86@mina86.com>
>> + /* Make sure all pages are isolated. */
>> + if (!ret) {
>> + lru_add_drain_all();
>> + drain_all_pages();
>> + if (WARN_ON(test_pages_isolated(start, end)))
>> + ret = -EBUSY;
>> + }
On Tue, 10 Jan 2012 15:16:13 +0100, Mel Gorman <mel@csn.ul.ie> wrote:
> Another global IPI seems overkill. Drain pages only from the local CPU
> (drain_pages(get_cpu()); put_cpu()) and test if the pages are isolated.
Is get_cpu() + put_cpu() required? Won't drain_local_pages() work?
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
next prev parent reply other threads:[~2012-01-13 20:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-29 12:39 [PATCHv18 0/11] Contiguous Memory Allocator Marek Szyprowski
2011-12-29 12:39 ` [PATCH 01/11] mm: page_alloc: set_migratetype_isolate: drain PCP prior to isolating Marek Szyprowski
2012-01-01 7:49 ` Gilad Ben-Yossef
2012-01-01 15:54 ` Michal Nazarewicz
2012-01-01 16:06 ` Gilad Ben-Yossef
2012-01-01 18:52 ` Michal Nazarewicz
2012-01-05 15:39 ` Michal Nazarewicz
2012-01-05 19:20 ` Marek Szyprowski
2011-12-29 12:39 ` [PATCH 02/11] mm: compaction: introduce isolate_{free,migrate}pages_range() Marek Szyprowski
2012-01-10 13:43 ` Mel Gorman
2012-01-10 15:04 ` Michal Nazarewicz
2011-12-29 12:39 ` [PATCH 03/11] mm: compaction: export some of the functions Marek Szyprowski
2011-12-29 12:39 ` [PATCH 04/11] mm: page_alloc: introduce alloc_contig_range() Marek Szyprowski
2012-01-10 14:16 ` Mel Gorman
2012-01-13 20:04 ` Michal Nazarewicz [this message]
2012-01-16 9:01 ` Mel Gorman
2012-01-16 12:48 ` Michal Nazarewicz
2012-01-17 21:54 ` [Linaro-mm-sig] " sandeep patil
2012-01-17 22:19 ` Michal Nazarewicz
2012-01-18 0:46 ` sandeep patil
2012-01-18 1:44 ` Michal Nazarewicz
2012-01-19 7:36 ` Marek Szyprowski
2011-12-29 12:39 ` [PATCH 05/11] mm: mmzone: MIGRATE_CMA migration type added Marek Szyprowski
2012-01-10 14:38 ` Mel Gorman
2012-01-10 15:04 ` Michal Nazarewicz
2011-12-29 12:39 ` [PATCH 06/11] mm: page_isolation: MIGRATE_CMA isolation functions added Marek Szyprowski
2011-12-29 12:39 ` [PATCH 07/11] mm: add optional memory reclaim in split_free_page() Marek Szyprowski
2012-01-10 14:45 ` Mel Gorman
2011-12-29 12:39 ` [PATCH 08/11] drivers: add Contiguous Memory Allocator Marek Szyprowski
2011-12-29 12:39 ` [PATCH 09/11] X86: integrate CMA with DMA-mapping subsystem Marek Szyprowski
2011-12-29 12:39 ` [PATCH 10/11] ARM: " Marek Szyprowski
2011-12-29 12:39 ` [PATCH 11/11] ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device Marek Szyprowski
2012-01-10 8:42 ` [PATCHv18 0/11] Contiguous Memory Allocator Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.v71gpt1b3l0zgt@mpn-glaptop \
--to=mina86@mina86.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=chunsang.jeong@linaro.org \
--cc=corbet@lwn.net \
--cc=dave@linux.vnet.ibm.com \
--cc=dwalker@codeaurora.org \
--cc=jesse.barker@linaro.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mel@csn.ul.ie \
--cc=shariq.hasnain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).