From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892Ab2A3Mm5 (ORCPT ); Mon, 30 Jan 2012 07:42:57 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:47106 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752835Ab2A3Mmy convert rfc822-to-8bit (ORCPT ); Mon, 30 Jan 2012 07:42:54 -0500 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Marek Szyprowski" , "Mel Gorman" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, "Kyungmin Park" , "Russell King" , "Andrew Morton" , "KAMEZAWA Hiroyuki" , "Daniel Walker" , "Arnd Bergmann" , "Jesse Barker" , "Jonathan Corbet" , "Shariq Hasnain" , "Chunsang Jeong" , "Dave Hansen" , "Benjamin Gaignard" Subject: Re: [PATCH 03/15] mm: compaction: introduce isolate_migratepages_range(). References: <1327568457-27734-1-git-send-email-m.szyprowski@samsung.com> <1327568457-27734-4-git-send-email-m.szyprowski@samsung.com> <20120130112428.GF25268@csn.ul.ie> Date: Mon, 30 Jan 2012 13:42:50 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT From: "Michal Nazarewicz" Message-ID: In-Reply-To: <20120130112428.GF25268@csn.ul.ie> User-Agent: Opera Mail/11.61 (Linux) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Thu, Jan 26, 2012 at 10:00:45AM +0100, Marek Szyprowski wrote: >> From: Michal Nazarewicz >> @@ -313,7 +316,7 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone, >> } else if (!locked) >> spin_lock_irq(&zone->lru_lock); >> >> - if (!pfn_valid_within(low_pfn)) >> + if (!pfn_valid(low_pfn)) >> continue; >> nr_scanned++; >> On Mon, 30 Jan 2012 12:24:28 +0100, Mel Gorman wrote: > This chunk looks unrelated to the rest of the patch. > > I think what you are doing is patching around a bug that CMA exposed > which is very similar to the bug report at > http://www.spinics.net/lists/linux-mm/msg29260.html . Is this true? > > If so, I posted a fix that only calls pfn_valid() when necessary. Can > you check if that works for you and if so, drop this hunk please? If > the patch does not work for you, then this hunk still needs to be > in a separate patch and handled separately as it would also be a fix > for -stable. I'll actually never encountered this bug myself and CMA is unlikely to expose it, since it always operates on continuous memory regions with no holes. I've made this change because looking at the code it seemed like this may cause problems in some cases. The crash that you linked to looks like the kind of problem I was thinking about. I'll drop this hunk and let you resolve this independently of CMA. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +------------------ooO--(_)--Ooo--