From: Andi Kleen <ak@suse.de>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 10/10] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to x86_64
Date: 12 Feb 2007 12:35:47 +0100 [thread overview]
Message-ID: <p737iunhalo.fsf@bingen.suse.de> (raw)
In-Reply-To: <11712214703522-git-send-email-mathieu.desnoyers@polymtl.ca>
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> writes:
>
> /**
> @@ -402,7 +405,7 @@ static __inline__ long atomic64_sub_return(long i, atomic64_t *v)
> */
> #define atomic_add_unless(v, a, u) \
> ({ \
> - int c, old; \
> + __typeof__((v)->counter) c, old; \
This change seems useless. Please drop.
In general you should enforce atomic_t vs atomic64_t types on x86, otherwise
people will write code that won't compile on other architectures
that have truly different implementations.
I would suggest using inlines.
-Andi
next prev parent reply other threads:[~2007-02-12 10:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-11 19:17 [PATCH 00/10] atomic.h : standardizing atomic primitives Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 01/10] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to alpha Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 02/10] atomic.h : Complete atomic_long operations in asm-generic Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 03/10] atomic.h : i386 type safety fix Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 04/10] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to ia64 Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 05/10] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to mips Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 06/10] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to parisc Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 07/10] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to powerpc Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 08/10] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to sparc64 Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 09/10] atomic.h : Add atomic64_xchg to s390 Mathieu Desnoyers
2007-02-11 19:17 ` [PATCH 10/10] atomic.h : Add atomic64 cmpxchg, xchg and add_unless to x86_64 Mathieu Desnoyers
2007-02-12 11:35 ` Andi Kleen [this message]
2007-02-12 16:43 ` Mathieu Desnoyers
2007-02-12 16:49 ` [PATCH] atomic.h : atomic_add_unless as inline. Remove system.h atomic.h circular dependency Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p737iunhalo.fsf@bingen.suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).