From: Andi Kleen <ak@suse.de>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Put modules into linear mapping
Date: 27 Sep 2002 17:36:35 +0200 [thread overview]
Message-ID: <p73d6qzsav0.fsf@oldwotan.suse.de> (raw)
In-Reply-To: Roman Zippel's message of "27 Sep 2002 16:49:12 +0200"
Roman Zippel <zippel@linux-m68k.org> writes:
> Why is i386 only? This is generic code and other archs will benefit from
> it as well (or at least it won't hurt).
Because some arcitectures have a different module_map() (e.g. x86-64 or
sparc64) and because the VMALLOC_START/END trick doesn't work on all.
> > +
> > +void *alloc_exact(unsigned int size)
> > +{
> > + struct page *p, *w;
> > + int order = get_order(size);
> > +
> > + p = alloc_pages(GFP_KERNEL, order);
>
> Wouldn't it be better to add a gfp argument?
I don't see a need for it. GFP_ATOMIC doesn't make sense for > order 0,
and > order 0 is the only case that is interesting for alloc_exact.
GFP_DMA is not needed here, and GFP_HIGHUSER neither supports > order 0
properly (because of kmap)
-Andi
next parent reply other threads:[~2002-09-27 15:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020927140930.GA12610@averell.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.44.0209271618360.8911-100000@serv.suse.lists.linux.kernel>
2002-09-27 15:36 ` Andi Kleen [this message]
2002-09-27 15:55 ` [PATCH] Put modules into linear mapping Roman Zippel
2002-09-27 16:14 ` Andi Kleen
2002-09-27 16:52 ` Roman Zippel
2002-09-27 16:59 ` Andi Kleen
2002-09-27 17:09 ` Roman Zippel
2002-09-27 14:09 Andi Kleen
2002-09-27 14:43 ` Roman Zippel
2002-09-27 15:05 ` Christoph Hellwig
2002-09-28 13:47 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73d6qzsav0.fsf@oldwotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).