* [PATCH] h8300: Remove unused variable
@ 2021-06-02 18:54 Souptick Joarder
2021-06-02 19:04 ` Mike Rapoport
2021-06-06 14:27 ` Yoshinori Sato
0 siblings, 2 replies; 3+ messages in thread
From: Souptick Joarder @ 2021-06-02 18:54 UTC (permalink / raw)
To: ysato, akpm, rppt, sboyd, geert+renesas
Cc: uclinux-h8-devel, linux-kernel, Souptick Joarder, kernel test robot
Kernel test robot throws below warning ->
>> arch/h8300/kernel/setup.c:72:26:
warning: Unused variable: region [unusedVariable]
struct memblock_region *region;
Fixed it by removing unused variable.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
arch/h8300/kernel/setup.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
index 15280af7251c..5745a763dc78 100644
--- a/arch/h8300/kernel/setup.c
+++ b/arch/h8300/kernel/setup.c
@@ -69,8 +69,6 @@ void __init h8300_fdt_init(void *fdt, char *bootargs)
static void __init bootmem_init(void)
{
- struct memblock_region *region;
-
memory_end = memory_start = 0;
/* Find main memory where is the kernel */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] h8300: Remove unused variable
2021-06-02 18:54 [PATCH] h8300: Remove unused variable Souptick Joarder
@ 2021-06-02 19:04 ` Mike Rapoport
2021-06-06 14:27 ` Yoshinori Sato
1 sibling, 0 replies; 3+ messages in thread
From: Mike Rapoport @ 2021-06-02 19:04 UTC (permalink / raw)
To: Souptick Joarder
Cc: ysato, akpm, sboyd, geert+renesas, uclinux-h8-devel,
linux-kernel, kernel test robot
On Thu, Jun 03, 2021 at 12:24:31AM +0530, Souptick Joarder wrote:
> Kernel test robot throws below warning ->
>
> >> arch/h8300/kernel/setup.c:72:26:
> warning: Unused variable: region [unusedVariable]
> struct memblock_region *region;
>
> Fixed it by removing unused variable.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
I believe a Fixes: tag would be appropriate here. Otherwise
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/h8300/kernel/setup.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index 15280af7251c..5745a763dc78 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -69,8 +69,6 @@ void __init h8300_fdt_init(void *fdt, char *bootargs)
>
> static void __init bootmem_init(void)
> {
> - struct memblock_region *region;
> -
> memory_end = memory_start = 0;
>
> /* Find main memory where is the kernel */
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] h8300: Remove unused variable
2021-06-02 18:54 [PATCH] h8300: Remove unused variable Souptick Joarder
2021-06-02 19:04 ` Mike Rapoport
@ 2021-06-06 14:27 ` Yoshinori Sato
1 sibling, 0 replies; 3+ messages in thread
From: Yoshinori Sato @ 2021-06-06 14:27 UTC (permalink / raw)
To: Souptick Joarder
Cc: akpm, rppt, sboyd, geert+renesas, uclinux-h8-devel, linux-kernel,
kernel test robot
On Thu, 03 Jun 2021 03:54:31 +0900,
Souptick Joarder wrote:
>
> Kernel test robot throws below warning ->
>
> >> arch/h8300/kernel/setup.c:72:26:
> warning: Unused variable: region [unusedVariable]
> struct memblock_region *region;
>
> Fixed it by removing unused variable.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> arch/h8300/kernel/setup.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index 15280af7251c..5745a763dc78 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -69,8 +69,6 @@ void __init h8300_fdt_init(void *fdt, char *bootargs)
>
> static void __init bootmem_init(void)
> {
> - struct memblock_region *region;
> -
> memory_end = memory_start = 0;
>
> /* Find main memory where is the kernel */
> --
> 2.25.1
>
Acked-by: Yoshinori Sato <ysato@users.sourceforge.jp>
--
Yoshinori Sato
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-06 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 18:54 [PATCH] h8300: Remove unused variable Souptick Joarder
2021-06-02 19:04 ` Mike Rapoport
2021-06-06 14:27 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).