From: Takashi Iwai <tiwai@suse.de>
To: "Andy Shevchenko" <andy.shevchenko@gmail.com>
Cc: "Ayman Bagabas" <ayman.bagabas@gmail.com>,
"ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
"Hui Wang" <hui.wang@canonical.com>,
"Andy Shevchenko" <andy@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Kailang Yang" <kailang@realtek.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v10 3/3] ALSA: hda: add support for Huawei WMI micmute LED
Date: Tue, 11 Dec 2018 11:27:56 +0100 [thread overview]
Message-ID: <s5h1s6omk7n.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAHp75VeLKGA0jwe9eqfSAisrQZB65Yvt3Kse1Cy7=Zkqqp02hQ@mail.gmail.com>
On Tue, 11 Dec 2018 11:09:59 +0100,
Andy Shevchenko wrote:
>
> On Tue, Dec 11, 2018 at 8:02 AM Ayman Bagabas <ayman.bagabas@gmail.com> wrote:
> >
> > Some of Huawei laptops come with a LED in the micmute key. This patch
> > enables the use of micmute LED for these devices:
> > 1. Matebook X (19e5:3200), (19e5:3201)
> > 2. Matebook X Pro (19e5:3204)
> >
> > Reviewed-by: Takashi Iwai <tiwai@suse.de>
> > Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
> > ---
> > sound/pci/hda/patch_realtek.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 1326f32f4574..9766fd249bdf 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -5776,7 +5776,9 @@ static const struct hda_fixup alc269_fixups[] = {
> > {0x1e, 0x411111f0},
> > {0x21, 0x04211020},
> > { }
>
> > - }
> > + },
>
> This is not related change, but we may fix it when applying.
>
> > + .chained = true,
> > + .chain_id = ALC255_FIXUP_MIC_MUTE_LED
The comma is needed only because you add more fields. So this isn't
wrong, per se.
OTOH, you can avoid this extra change if you already had a comma in
the first patch, yeah.
thanks,
Takashi
prev parent reply other threads:[~2018-12-11 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 6:01 [PATCH v10 0/3] Huawei laptops Ayman Bagabas
2018-12-11 6:01 ` [PATCH v10 1/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas
2018-12-11 6:01 ` [PATCH v10 2/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
2018-12-11 10:14 ` Andy Shevchenko
2018-12-11 20:10 ` ayman.bagabas
2018-12-12 6:56 ` Takashi Iwai
2018-12-12 13:48 ` Andy Shevchenko
2018-12-12 13:49 ` Andy Shevchenko
2018-12-11 6:01 ` [PATCH v10 3/3] ALSA: hda: add support for Huawei WMI micmute LED Ayman Bagabas
2018-12-11 10:09 ` Andy Shevchenko
2018-12-11 10:27 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1s6omk7n.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=ayman.bagabas@gmail.com \
--cc=dvhart@infradead.org \
--cc=hui.wang@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).