From: Takashi Iwai <tiwai@suse.de>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Connor McAdams" <conmanx360@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
<alsa-devel@alsa-project.org>,
"Alastair Bridgewater" <alastair.bridgewater@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda/ca0132 - make pci_iounmap() call conditional
Date: Tue, 11 Dec 2018 09:14:39 +0100 [thread overview]
Message-ID: <s5h1s6owkcw.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181210205445.2913413-1-arnd@arndb.de>
On Mon, 10 Dec 2018 21:54:25 +0100,
Arnd Bergmann wrote:
>
> When building without CONFIG_PCI, we can (depending on the architecture)
> get a link failure:
>
> ERROR: "pci_iounmap" [sound/pci/hda/snd-hda-codec-ca0132.ko] undefined!
>
> Adding a compile-time check for PCI gets it to work correctly on
> 32-bit ARM.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
The proper "fix" would be to make this working for SH no matter which
config is... But pci_iomap and pci_iounmap() are such a mess, and no
one really cares about SH nowadays, so I'd take this easier way.
thanks,
Takashi
> ---
> sound/pci/hda/patch_ca0132.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
> index c40cb6336017..e5bdbc245682 100644
> --- a/sound/pci/hda/patch_ca0132.c
> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -8451,7 +8451,7 @@ static void ca0132_free(struct hda_codec *codec)
> ca0132_exit_chip(codec);
>
> snd_hda_power_down(codec);
> - if (spec->mem_base)
> + if (IS_ENABLED(CONFIG_PCI) && spec->mem_base)
> pci_iounmap(codec->bus->pci, spec->mem_base);
> kfree(spec->spec_init_verbs);
> kfree(codec->spec);
> --
> 2.20.0
>
>
prev parent reply other threads:[~2018-12-11 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 20:54 [PATCH] ALSA: hda/ca0132 - make pci_iounmap() call conditional Arnd Bergmann
2018-12-11 8:14 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1s6owkcw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alastair.bridgewater@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=conmanx360@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).