From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=dFdc=BX=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2D1EAC433E1
	for <linux-kernel@archiver.kernel.org>; Thu, 13 Aug 2020 09:22:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 0FF8820781
	for <linux-kernel@archiver.kernel.org>; Thu, 13 Aug 2020 09:22:26 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726531AbgHMJWY (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 13 Aug 2020 05:22:24 -0400
Received: from mx2.suse.de ([195.135.220.15]:58758 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726174AbgHMJWV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Aug 2020 05:22:21 -0400
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id D2549AE7D;
        Thu, 13 Aug 2020 09:22:41 +0000 (UTC)
Date:   Thu, 13 Aug 2020 11:22:17 +0200
Message-ID: <s5h364qx5me.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc:     kjlu@umn.edu, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Mark Hills <mark@xwax.org>,
        Takashi Sakamoto <o-takashi@sakamocchi.jp>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        YueHaibing <yuehaibing@huawei.com>,
        Giuliano Pochini <pochini@shiny.it>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] ALSA: echoaudio: Fix potential Oops in snd_echo_resume()
In-Reply-To: <20200813074632.17022-1-dinghao.liu@zju.edu.cn>
References: <20200813074632.17022-1-dinghao.liu@zju.edu.cn>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 13 Aug 2020 09:46:30 +0200,
Dinghao Liu wrote:
> 
> Freeing chip on error may lead to an Oops at the next time
> the system goes to resume. Fix this by removing all
> snd_echo_free() calls on error.
> 
> Fixes: 47b5d028fdce8 ("ALSA: Echoaudio - Add suspend support #2")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>

Applied, thanks.


Takashi