From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbaIVHKG (ORCPT ); Mon, 22 Sep 2014 03:10:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55930 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbaIVHKE (ORCPT ); Mon, 22 Sep 2014 03:10:04 -0400 Date: Mon, 22 Sep 2014 09:10:03 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] sound: pci: ctxfi: cthw20k2.c: sparse warning of incorrect type In-Reply-To: <1411315421-24138-4-git-send-email-sudipm.mukherjee@gmail.com> References: <1411315421-24138-1-git-send-email-sudipm.mukherjee@gmail.com> <1411315421-24138-4-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 21 Sep 2014 21:33:40 +0530, Sudip Mukherjee wrote: > > fixed sparse warning of incorrect type (different address spaces) Better to rather fix the type of hw.base_mem field. Last but not least, try to align the subject line with other commits to this driver. See git log and compare with yours. thanks, Takashi > > Signed-off-by: Sudip Mukherjee > --- > sound/pci/ctxfi/cthw20k2.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/pci/ctxfi/cthw20k2.c b/sound/pci/ctxfi/cthw20k2.c > index 665eeb2..25ef60b 100644 > --- a/sound/pci/ctxfi/cthw20k2.c > +++ b/sound/pci/ctxfi/cthw20k2.c > @@ -2112,7 +2112,7 @@ static int hw_card_shutdown(struct hw *hw) > hw->irq = -1; > > if (hw->mem_base) > - iounmap((void *)hw->mem_base); > + iounmap((void __iomem *)hw->mem_base); > > hw->mem_base = (unsigned long)NULL; > > @@ -2234,12 +2234,12 @@ static int hw_resume(struct hw *hw, struct card_conf *info) > > static u32 hw_read_20kx(struct hw *hw, u32 reg) > { > - return readl((void *)(hw->mem_base + reg)); > + return readl((void __iomem *)(hw->mem_base + reg)); > } > > static void hw_write_20kx(struct hw *hw, u32 reg, u32 data) > { > - writel(data, (void *)(hw->mem_base + reg)); > + writel(data, (void __iomem *)(hw->mem_base + reg)); > } > > static struct hw ct20k2_preset = { > -- > 1.8.1.2 >