From: Takashi Iwai <tiwai@suse.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Chuck Lever <chuck.lever@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Anna Schumaker <Anna.Schumaker@Netapp.com>,
Trond Myklebust <trondmy@gmail.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the nfs-anna tree
Date: Wed, 16 Jan 2019 07:32:18 +0100 [thread overview]
Message-ID: <s5h4la9f6z1.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190115233811.GD26416@windriver.com>
On Wed, 16 Jan 2019 00:38:11 +0100,
Paul Gortmaker wrote:
>
> [Re: linux-next: Fixes tag needs some work in the nfs-anna tree] On 15/01/2019 (Tue 23:12) Takashi Iwai wrote:
>
> > On Tue, 15 Jan 2019 22:41:21 +0100,
> > Chuck Lever wrote:
> > >
> > > Hi Stephen-
> > >
> > > On Jan 15, 2019, at 4:38 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > > [I am experimenting with checking the Fixes tags in commits in linux-next.
> > > > Please let me know if you think I am being too strict.]
> > > >
> > > > Hi all,
> > > >
> > > > Commit
> > > >
> > > > deaa5c96c2f7 ("SUNRPC: Address Kerberos performance/behavior regression")
> > > >
> > > > has problem with this Fixes tag:
> > > >
> > > > Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")
> > > >
> > > > The subject should match the subject of the fixed commit.
> > > >
> > > > --
> > > > Cheers,
> > > > Stephen Rothwell
> > >
> > > I shortened the commit title so that the Fixes: line is shorter than 68
> > > characters. I can leave these titles alone if that's preferred.
> >
> > I've sometimes shorted the subject like the above, too, as I find a
> > too long text annoying. Maybe the partial string matching should
> > suffice, especially when it ends with "..." ?
>
> The problem is consistency. Perhaps you shorten at four words. A
> person searches with five words or 70 chars - they never see your commit.
What's the reason to search for words instead of commit ID?
> The idea of consistency across the "Fixes:" tags is to allow a level of
> automated processing so that the creators of the stable releases can do
> a lot less manual hands-on processing. They have enough work to do.
Yes, I know, but the important point for stable pick-up is the
correctness of the commit ID, no?
I can understand the need for validity check of the Fixes tag,
especially to check whether the given commit ID is really correct, in
linux-next stage. But this can be verified even with a partial string
match.
thanks,
Takashi
next prev parent reply other threads:[~2019-01-16 6:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 21:38 linux-next: Fixes tag needs some work in the nfs-anna tree Stephen Rothwell
2019-01-15 21:41 ` Chuck Lever
2019-01-15 22:12 ` Takashi Iwai
2019-01-15 23:38 ` Paul Gortmaker
2019-01-16 6:32 ` Takashi Iwai [this message]
2019-01-16 15:24 ` Chuck Lever
2019-05-30 21:58 Stephen Rothwell
2019-10-21 20:48 Stephen Rothwell
2020-05-19 18:30 Stephen Rothwell
2020-06-26 23:01 Stephen Rothwell
2022-02-06 20:56 Stephen Rothwell
2022-10-03 21:21 Stephen Rothwell
2023-09-12 22:05 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4la9f6z1.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Anna.Schumaker@Netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sfr@canb.auug.org.au \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).