From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: Arnd Bergmann <arnd@arndb.de>,
alsa-devel@alsa-project.org, Clemens Ladisch <clemens@ladisch.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused
Date: Thu, 20 Apr 2017 15:01:31 +0200 [thread overview]
Message-ID: <s5h4lxjnsgk.wl-tiwai@suse.de> (raw)
In-Reply-To: <f6d6ac28-12ad-1845-6fac-7b5f7de6da39@sakamocchi.jp>
On Thu, 20 Apr 2017 14:52:13 +0200,
Takashi Sakamoto wrote:
>
> Hi,
>
> On 2017年04月20日 19:51, Takashi Iwai wrote:
> > On Wed, 19 Apr 2017 19:51:29 +0200,
> > Arnd Bergmann wrote:
> >>
> >> Two functions were introduced for the purpose of tracing but cause warnings
> >> when tracing is disabled:
> >>
> >> sound/firewire/motu/amdtp-motu.c:284:13: error: 'copy_message' defined but not used [-Werror=unused-function]
> >> static void copy_message(u64 *frames, __be32 *buffer, unsigned int data_blocks,
> >> sound/firewire/motu/amdtp-motu.c:271:13: error: 'copy_sph' defined but not used [-Werror=unused-function]
> >> static void copy_sph(u32 *frames, __be32 *buffer, unsigned int data_blocks,
> >>
> >> Marking them as __maybe_unused will do the right thing here.
> >>
> >> Fixes: 17909c1b3058 ("ALSA: firewire-motu: add tracepoints for SPH in IEC 61883-1 fashion")
> >> Fixes: c6b0b9e65f09 ("ALSA: firewire-motu: add tracepoints for messages for unique protocol")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Applied, thanks.
>
> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
>
> I note that Documentation/process/coding-style.rst describes:
> 'If you have a function or variable which may potentially go unused in a
> particular configuration, and the compiler would warn about its
> definition going unused, mark the definition as __maybe_unused rather
> than wrapping it in a preprocessor conditional.'
>
> Iwa-san, could I request you to apply below patch in the last week of
> this development period?
> http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/119806.html
Merged now, sorry for overlooking it.
thanks,
Takashi
prev parent reply other threads:[~2017-04-20 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 17:51 [PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused Arnd Bergmann
2017-04-20 10:51 ` Takashi Iwai
[not found] ` <f6d6ac28-12ad-1845-6fac-7b5f7de6da39@sakamocchi.jp>
2017-04-20 13:01 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4lxjnsgk.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=clemens@ladisch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).