From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752871AbaIVHII (ORCPT ); Mon, 22 Sep 2014 03:08:08 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55916 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbaIVHIH (ORCPT ); Mon, 22 Sep 2014 03:08:07 -0400 Date: Mon, 22 Sep 2014 09:08:05 +0200 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/5] sound: pci: ctxfi: pr_* replaced with dev_* In-Reply-To: <1411315421-24138-3-git-send-email-sudipm.mukherjee@gmail.com> References: <1411315421-24138-1-git-send-email-sudipm.mukherjee@gmail.com> <1411315421-24138-3-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 21 Sep 2014 21:33:39 +0530, Sudip Mukherjee wrote: > > pr_* macros replaced with dev_* as they are more preffered over pr_*. In this patch, it's not trivial conversion, so it's not bad to spend more words to explain how you did it. Nevertheless... (snip) > diff --git a/sound/pci/ctxfi/ctamixer.c b/sound/pci/ctxfi/ctamixer.c > index fed6e6a..955b2af 100644 > --- a/sound/pci/ctxfi/ctamixer.c > +++ b/sound/pci/ctxfi/ctamixer.c > @@ -258,7 +258,8 @@ static int get_amixer_rsc(struct amixer_mgr *mgr, > } > spin_unlock_irqrestore(&mgr->mgr_lock, flags); > if (err) { > - pr_err("ctxfi: Can't meet AMIXER resource request!\n"); > + dev_err(((struct hw *)(mgr->mgr.hw))->card->dev, > + "Can't meet AMIXER resource request!\n"); Do we agree that such a change is too ugly, right? And... > diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c > index 3e29e13..6c185d0 100644 > --- a/sound/pci/ctxfi/ctatc.c > +++ b/sound/pci/ctxfi/ctatc.c > @@ -186,7 +186,7 @@ static unsigned int convert_format(snd_pcm_format_t snd_format, > case SNDRV_PCM_FORMAT_FLOAT_LE: > return SRC_SF_F32; > default: > - pr_err("ctxfi: not recognized snd format is %d\n", > + dev_err(card->dev, "ctxfi: not recognized snd format is %d\n", > snd_format); You forgot to strip the superfluous prefix in many places. Takashi