From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 568F7C07E9C for ; Wed, 14 Jul 2021 07:01:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FBB86120A for ; Wed, 14 Jul 2021 07:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238167AbhGNHDt (ORCPT ); Wed, 14 Jul 2021 03:03:49 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:35846 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237948AbhGNHDs (ORCPT ); Wed, 14 Jul 2021 03:03:48 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id CC48022972; Wed, 14 Jul 2021 07:00:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626246056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXfpwgyw6CEUgPbLD+Wqw0C3z2Gmg8ChSjydaanPZOE=; b=rrDxyqTV2y0wteEKoNbf+YgaWZCrkZ+vkW9mZuQ88l0MoLfNEw9ty+wLHbO0sKrmZKKIcm aYj3nJdczOheNVNbexcp5bOKWeDp/AgwAMukp/ylVs2f6h4UWgW0GOTEd9BWFTtAM5NB+N 0Z2IygPIm8DlbMnnWsA1S8iHqByePLc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626246056; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXfpwgyw6CEUgPbLD+Wqw0C3z2Gmg8ChSjydaanPZOE=; b=3JkZRU0+vbZiu+W8SQNirvJpbyjvzA12tZlYKU7ppclFCmAUJGnfKwT2BBKr3F3WVYfsW4 HVcou7voXM41G7Ag== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 2833DA3B88; Wed, 14 Jul 2021 07:00:55 +0000 (UTC) Date: Wed, 14 Jul 2021 09:00:55 +0200 Message-ID: From: Takashi Iwai To: Pavel Machek Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, "Geoffrey D. Bennett" , Takashi Iwai Subject: Re: [PATCH 5.10 007/593] ALSA: usb-audio: scarlett2: Fix wrong resume call In-Reply-To: <20210713204643.GA21897@amd> References: <20210712060843.180606720@linuxfoundation.org> <20210712060843.978749134@linuxfoundation.org> <20210713204643.GA21897@amd> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Jul 2021 22:46:43 +0200, Pavel Machek wrote: > > Hi! > > > This patch corrects those issues. It introduces a new value type, > > USB_MIXER_BESPOKEN, which indicates a non-standard mixer element, and > > use this type for all scarlett2 mixer elements, as well as > > initializing the fixed unit id 0 for avoiding the overflow. > > New mixer value is introduced, but printing code in mixer.c is not > updated. > > Is something like this needed? Currently BESPOKEN type doesn't use the standard dump callback, hence this won't hit, but such a change wouldn't hurt. thanks, Takashi > > > > +++ b/sound/usb/mixer.h > > @@ -55,6 +55,7 @@ enum { > > USB_MIXER_U16, > > USB_MIXER_S32, > > USB_MIXER_U32, > > + USB_MIXER_BESPOKEN, /* non-standard type */ > > }; > > > > Best regards, > Pavel > > diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c > index 2b5281ef8fca..83d5e4d19128 100644 > --- a/sound/usb/mixer.c > +++ b/sound/usb/mixer.c > @@ -3294,7 +3294,7 @@ static void snd_usb_mixer_dump_cval(struct snd_info_buffer *buffer, > { > struct usb_mixer_elem_info *cval = mixer_elem_list_to_info(list); > static const char * const val_types[] = { > - "BOOLEAN", "INV_BOOLEAN", "S8", "U8", "S16", "U16", "S32", "U32", > + "BOOLEAN", "INV_BOOLEAN", "S8", "U8", "S16", "U16", "S32", "U32", "BESPOKEN", > }; > > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > [2 Digital signature ] >