From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F48C433ED for ; Wed, 21 Apr 2021 16:30:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5DB76141C for ; Wed, 21 Apr 2021 16:30:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235464AbhDUQbO (ORCPT ); Wed, 21 Apr 2021 12:31:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:53090 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235858AbhDUQal (ORCPT ); Wed, 21 Apr 2021 12:30:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AFAC2B4F5; Wed, 21 Apr 2021 16:30:07 +0000 (UTC) Date: Wed, 21 Apr 2021 18:30:07 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Wenwen Wang , stable@vger.kernel.org Subject: Re: [PATCH 187/190] Revert "ALSA: control: fix a redundant-copy issue" In-Reply-To: <20210421130105.1226686-188-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-188-gregkh@linuxfoundation.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Apr 2021 15:01:02 +0200, Greg Kroah-Hartman wrote: > > This reverts commit 3f12888dfae2a48741c4caa9214885b3aaf350f9. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Wenwen Wang > Cc: > Cc: Takashi Iwai > Signed-off-by: Greg Kroah-Hartman This one is, unlike other patches I've been involved with, about the ALSA core code, and this change is likely worth to keep. The code change is correct, and even though it's really a minor issue, an optimization is right. thanks, Takashi > --- > sound/core/control_compat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sound/core/control_compat.c b/sound/core/control_compat.c > index 1d708aab9c98..857acf83ae47 100644 > --- a/sound/core/control_compat.c > +++ b/sound/core/control_compat.c > @@ -381,7 +381,8 @@ static int snd_ctl_elem_add_compat(struct snd_ctl_file *file, > if (copy_from_user(&data->id, &data32->id, sizeof(data->id)) || > copy_from_user(&data->type, &data32->type, 3 * sizeof(u32))) > goto error; > - if (get_user(data->owner, &data32->owner)) > + if (get_user(data->owner, &data32->owner) || > + get_user(data->type, &data32->type)) > goto error; > switch (data->type) { > case SNDRV_CTL_ELEM_TYPE_BOOLEAN: > -- > 2.31.1 >