From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83594C2BBCA for ; Wed, 16 Dec 2020 15:42:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48D0A233E2 for ; Wed, 16 Dec 2020 15:42:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726507AbgLPPmL (ORCPT ); Wed, 16 Dec 2020 10:42:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:34038 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbgLPPmL (ORCPT ); Wed, 16 Dec 2020 10:42:11 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 57395AD6B; Wed, 16 Dec 2020 15:41:29 +0000 (UTC) Date: Wed, 16 Dec 2020 16:41:29 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: tiwai@suse.com, Jaroslav Kysela , Kai Vehmanen , Pierre-Louis Bossart , Alex Deucher , Mike Rapoport , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails In-Reply-To: <20201216124726.2842197-1-kai.heng.feng@canonical.com> References: <20201214060621.1102931-1-kai.heng.feng@canonical.com> <20201216124726.2842197-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Dec 2020 13:47:24 +0100, Kai-Heng Feng wrote: > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller > initialization even if no codecs found"), when codec probe fails, it > doesn't enable runtime suspend, and can prevent graphics card from > getting powered down: > [ 4.280991] snd_hda_intel 0000:01:00.1: no codecs initialized > > $ cat /sys/bus/pci/devices/0000:01:00.1/power/runtime_status > active > > So mark there's no codec and continue probing to let runtime PM to work. > > BugLink: https://bugs.launchpad.net/bugs/1907212 > Signed-off-by: Kai-Heng Feng Hm, but if the probe fails, doesn't it mean something really wrong? IOW, how does this situation happen? The usual no-codec state is for the devices that have a bogus HD-audio bus remaining while codecs aren't hooked or disabled by BIOS. For that, it makes to leave the controller driver and let it idle. But if you get really an error, it's something to fix there, not to just ignore in general. thanks, Takashi > --- > sound/pci/hda/hda_intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c > index 6852668f1bcb..872a703dee43 100644 > --- a/sound/pci/hda/hda_intel.c > +++ b/sound/pci/hda/hda_intel.c > @@ -2328,7 +2328,7 @@ static int azx_probe_continue(struct azx *chip) > if (bus->codec_mask) { > err = azx_probe_codecs(chip, azx_max_codecs[chip->driver_type]); > if (err < 0) > - goto out_free; > + bus->codec_mask = 0; > } > > #ifdef CONFIG_SND_HDA_PATCH_LOADER > -- > 2.29.2 >