From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1ED6C433DF for ; Sat, 22 Aug 2020 16:12:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D65C020738 for ; Sat, 22 Aug 2020 16:12:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728374AbgHVQMF (ORCPT ); Sat, 22 Aug 2020 12:12:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:56470 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgHVQME (ORCPT ); Sat, 22 Aug 2020 12:12:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3F9E1B746; Sat, 22 Aug 2020 16:12:31 +0000 (UTC) Date: Sat, 22 Aug 2020 18:12:02 +0200 Message-ID: From: Takashi Iwai To: Connor McAdams Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/20] ALSA: hda/ca0132 - Add surround channel config control. In-Reply-To: <20200821185239.26133-4-conmanx360@gmail.com> References: <20200821185239.26133-1-conmanx360@gmail.com> <20200821185239.26133-4-conmanx360@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Aug 2020 20:52:20 +0200, Connor McAdams wrote: > > +static int ca0132_alt_add_speaker_channel_cfg_enum(struct hda_codec *codec) > +{ > + struct snd_kcontrol_new knew = > + HDA_CODEC_MUTE_MONO("Output: Channels", > + SPEAKER_CHANNEL_CFG_ENUM, 1, 0, HDA_OUTPUT); This isn't good as a control element name. It's not only specific about the purpose, also the use of a letter like ':' may confuse the user-space tools. Please choose a different name like "Surround Channel Mode", "Surround Channel Config" or such one. thanks, Takashi