LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] GPF in snd_hda_intel
Date: Tue, 13 Oct 2009 08:12:50 +0200
Message-ID: <s5h63ajx1nh.wl%tiwai@suse.de> (raw)
In-Reply-To: <68676e00910121239qd2d87cbnbdab32efe041a65d@mail.gmail.com>

At Mon, 12 Oct 2009 21:39:21 +0200,
Luca Tettamanti wrote:
> 
> On Mon, Oct 12, 2009 at 7:58 AM, Takashi Iwai <tiwai@suse.de> wrote:
> > At Sat, 10 Oct 2009 15:01:10 +0200,
> > Luca Tettamanti wrote:
> >>
> >> Hello,
> >> with current git kernel (bd381934) I see a GPF when the snd_hda_intel driver is
> >> loaded; the regression is recent, 0eca52a works fine.
> >> The machine is an ASUS laptop (F3Sa), this is the sound card:
> >
> > Could you load the snd-hda-intel module with probe_only=1 option,
> > and give the output of "alsa-info.sh --no-upload" ?
> >
> > If 0eca52a worked, there are only a few changes regarding hda-intel.
> >
> > f8f25ba3563dab14b1c3ea4d829642b8a61ca5d7
> >    ALSA: hda - Add a workaround for ASUS A7K
> 
> This is probably related; I haven't actually tested yet, but I have
> one more information: I had "model=lenovo" in modprobe configuration.

Ah, this is it.  I can reproduce the problem with my emulator now.
The patch below fixes the issue.

> This was necessary because otherwise the driver applied the quirk for
> Asus G1, resulting in no sound (see bug
> https://bugtrack.alsa-project.org/alsa-bug/view.php?id=3513).
> The driver works fine without "model" parameter (possibly due to the
> removal of the quirk entry for the the G1); I get a warning about a
> timeout when MSI is not enabled though:
> 
> HDA Intel 0000:00:1b.0: PCI INT A disabled
> HDA Intel 0000:00:1b.0: PCI INT A -> GSI 22 (level, low) -> IRQ 22
> HDA Intel 0000:00:1b.0: setting latency timer to 64
> hda_codec: ALC660-VD: BIOS auto-probing.
> input: HDA Digital PCBeep as /devices/pci0000:00/0000:00:1b.0/input/input9
> hda-intel: azx_get_response timeout, switching to polling mode: last
> cmd=0x018f0900

It's no critical error, but if enable_msi=1 helps, just keep the option.
In 2.6.33, MSI will be enabled as default.


thanks,

Takashi

---
>From 2d9c648295d7bc376305337d29f540a5e411f632 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Tue, 13 Oct 2009 08:06:55 +0200
Subject: [PATCH] ALSA: hda - Fix overflow of spec->init_verbs in patch_realtek.c

ALC861-VD lenovo model causes overflow of spec->init_verbs entries due to
the recent changes.  Simply increase the array size to avoid the overflow.

Reported-by: Luca Tettamanti <kronos.it@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/patch_realtek.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 470fd74..c08ca66 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -275,7 +275,7 @@ struct alc_spec {
 	struct snd_kcontrol_new *cap_mixer;	/* capture mixer */
 	unsigned int beep_amp;	/* beep amp value, set via set_beep_amp() */
 
-	const struct hda_verb *init_verbs[5];	/* initialization verbs
+	const struct hda_verb *init_verbs[10];	/* initialization verbs
 						 * don't forget NULL
 						 * termination!
 						 */
-- 
1.6.4.2


  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-10 13:01 Luca Tettamanti
2009-10-12  5:58 ` Takashi Iwai
2009-10-12 19:39   ` Luca Tettamanti
2009-10-13  6:12     ` Takashi Iwai [this message]
2009-10-13 12:54       ` Luca Tettamanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h63ajx1nh.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kronos.it@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git