From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933874AbXF2R02 (ORCPT ); Fri, 29 Jun 2007 13:26:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758787AbXF2R0V (ORCPT ); Fri, 29 Jun 2007 13:26:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43175 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbXF2R0U (ORCPT ); Fri, 29 Jun 2007 13:26:20 -0400 Date: Fri, 29 Jun 2007 19:26:19 +0200 Message-ID: From: Takashi Iwai To: Andrew Morton Cc: Randy Dunlap , lkml , perex@suse.cz Subject: Re: [PATCH] ALSA: more section mismatches In-Reply-To: <20070628153949.8582d3a4.akpm@linux-foundation.org> References: <20070628150515.0d819891.randy.dunlap@oracle.com> <20070628153949.8582d3a4.akpm@linux-foundation.org> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta27) (fiddleheads) (+CVS-20060704) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 28 Jun 2007 15:39:49 -0700, Andrew Morton wrote: > > On Thu, 28 Jun 2007 15:05:15 -0700 > Randy Dunlap wrote: > > > From: Randy Dunlap > > > > Fix section mismatch warnings: > > > > WARNING: sound/built-in.o(.exit.text+0x3ad): Section mismatch: reference to .init.text: (between 'sb_exit' and 'unload_uart6850') > > WARNING: sound/built-in.o(.exit.text+0x753): Section mismatch: reference to .init.text: (between 'snd_mts64_module_exit' and 'snd_portman_module_exit') > > > > Signed-off-by: Randy Dunlap > > --- > > sound/drivers/mts64.c | 2 +- > > sound/oss/sb_card.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > --- linux-2622-rc6.orig/sound/drivers/mts64.c > > +++ linux-2622-rc6/sound/drivers/mts64.c > > @@ -1048,7 +1048,7 @@ static struct platform_driver snd_mts64_ > > /********************************************************************* > > * module init stuff > > *********************************************************************/ > > -static void __init_or_module snd_mts64_unregister_all(void) > > +static void snd_mts64_unregister_all(void) > > Well this is called from __exit, so __init_or_module isn't right. But we > don't have an __exit_or_module. Well, the name is a bit confusing. As Adrian pointed, it's called _only_ from init or module. > > > { > > int i; > > > > --- linux-2622-rc6.orig/sound/oss/sb_card.c > > +++ linux-2622-rc6/sound/oss/sb_card.c > > @@ -290,7 +290,7 @@ static struct pnp_card_driver sb_pnp_dri > > MODULE_DEVICE_TABLE(pnp_card, sb_pnp_card_table); > > #endif /* CONFIG_PNP */ > > > > -static void __init_or_module sb_unregister_all(void) > > +static void sb_unregister_all(void) > > { > > #ifdef CONFIG_PNP > > if (pnp_registered) > > One of these is alsa and the other isn't. > > But what the heck: obviously safe, I'll slam it all in. Yes, I'll merge them to ALSA tree, too. A few bytes of diet won't be a big win in comparison with annoyance by compiler warnings. ... Or, fix the tool! Takashi