* [PATCH 2.6.20] sound/pci/ca0106: add device attribute to ca0106 devices
@ 2007-02-09 16:52 Wouter Paesen
2007-02-12 13:45 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Wouter Paesen @ 2007-02-09 16:52 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: linux-kernel
The ca0106 driver does not install a reference to the pci
device in it's __devinit function. This will result in a
missing "device" attribute on the sound devices associated with
this card, which makes hal/libhal ignore the card.
Signed-off-by: Wouter Paesen <wouter@kangaroot.net>
--
--- linux-2.6.20/sound/pci/ca0106/ca0106_main.c.orig 2007-02-04 19:44:54.000000000 +0100
+++ linux-2.6.20/sound/pci/ca0106/ca0106_main.c 2007-02-09 17:20:37.000000000 +0100
@@ -1455,6 +1455,8 @@ static int __devinit snd_ca0106_create(i
snd_ca0106_free(chip);
return err;
}
+
+ snd_card_set_dev(card, &pci->dev);
*rchip = chip;
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.20] sound/pci/ca0106: add device attribute to ca0106 devices
2007-02-09 16:52 [PATCH 2.6.20] sound/pci/ca0106: add device attribute to ca0106 devices Wouter Paesen
@ 2007-02-12 13:45 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2007-02-12 13:45 UTC (permalink / raw)
To: Wouter Paesen; +Cc: Jaroslav Kysela, linux-kernel
At Fri, 9 Feb 2007 17:52:11 +0100,
Wouter Paesen wrote:
>
>
> The ca0106 driver does not install a reference to the pci
> device in it's __devinit function. This will result in a
> missing "device" attribute on the sound devices associated with
> this card, which makes hal/libhal ignore the card.
>
> Signed-off-by: Wouter Paesen <wouter@kangaroot.net>
Thanks, it's already fixed in the latest git tree.
Takashi
> --
>
> --- linux-2.6.20/sound/pci/ca0106/ca0106_main.c.orig 2007-02-04 19:44:54.000000000 +0100
> +++ linux-2.6.20/sound/pci/ca0106/ca0106_main.c 2007-02-09 17:20:37.000000000 +0100
> @@ -1455,6 +1455,8 @@ static int __devinit snd_ca0106_create(i
> snd_ca0106_free(chip);
> return err;
> }
> +
> + snd_card_set_dev(card, &pci->dev);
> *rchip = chip;
> return 0;
> }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-02-12 13:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-09 16:52 [PATCH 2.6.20] sound/pci/ca0106: add device attribute to ca0106 devices Wouter Paesen
2007-02-12 13:45 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).