From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7E2C4338F for ; Wed, 28 Jul 2021 17:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C3AA6101B for ; Wed, 28 Jul 2021 17:02:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbhG1RC4 (ORCPT ); Wed, 28 Jul 2021 13:02:56 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:49234 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbhG1RCy (ORCPT ); Wed, 28 Jul 2021 13:02:54 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 34A641FFD5; Wed, 28 Jul 2021 17:02:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627491772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4QcA1ooDxwwNFuX8+dVEvEspFGMcPAidGM3W6dbV2E4=; b=JMbfmhJoE6gBX0kxF0oMg90xIg55UAl+kkl8+R6BD+vhNfYfEzSFtaS8I5SlhdDt0ZdiVM xLqN+nV1xuFg3Ecxv6Nabc7gKMba/bBZarW0JMw9tqfg/Mg34qP0gH6nQ+LEHFiIbP6MNb ATfoaUkpKykkAtNiVFQNmJKnWwx7j3c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627491772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4QcA1ooDxwwNFuX8+dVEvEspFGMcPAidGM3W6dbV2E4=; b=LlDdUEIvOi+R3izif9mgh+OlAKA0mdC59EPd/dQc9vj1KiBaIgMEaemOUp/PqvJbgLkIGT 34Lqj/d761QdbCAw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 992D5A3B84; Wed, 28 Jul 2021 17:02:51 +0000 (UTC) Date: Wed, 28 Jul 2021 19:02:51 +0200 Message-ID: From: Takashi Iwai To: Alexander Monakov Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Hui Wang , Kailang Yang , Jeremy Szu , Jian-Hong Pan , Chris Chiu , PeiSen Hou , alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: hda/realtek: add mic quirk for Acer SF314-42 In-Reply-To: <20210721170141.24807-1-amonakov@ispras.ru> References: <20210721170141.24807-1-amonakov@ispras.ru> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Jul 2021 19:01:41 +0200, Alexander Monakov wrote: > > The Acer Swift SF314-42 laptop is using Realtek ALC255 codec. Add a > quirk so microphone in a headset connected via the right-hand side jack > is usable. > > Signed-off-by: Alexander Monakov > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Hui Wang > Cc: Kailang Yang > Cc: Jeremy Szu > Cc: Jian-Hong Pan > Cc: Chris Chiu > Cc: PeiSen Hou > Cc: alsa-devel@alsa-project.org > --- > Hello, > > Acer Swift SF314-42 laptop is using AMD Ryzen SoC audio with Realtek > ALC255 codec. The are three ALSA cards: HDMI audio, AMD ACP card, and > AMD HDA card. There is an internal stereo microphone connected to the > ACP card, and a mini-jack connected to the Realtek codec. There are no > LEDs. > > I'd like to be able to use a mic+headphones headset. Unfortunately, out > of the box ALSA does not correctly detect the microphone input of the > Realtek codec. The suggested patch fixes that, though I cannot be sure > it's 100% correct. > > With the patch, the experience is unfortunately still not ideal. I have > noticed a couple of issues: > > 1) at high enough gain, recording the microphone is picking up what is > being played via the headphones; maybe it's supposed to be like that, > but it surprised me; Hrm, that doesn't sound right. Some internal loopback in the codec? Dunno. It doesn't pick up the sound physically, right? > 2) there is a very noticeable "pop" when plugging the headset in/out, > accompanied by > > pcieport 0000:00:08.1: PME: Spurious native interrupt! > pcieport 0000:00:08.1: PME: Spurious native interrupt! > > in dmesg. I'd appreciate info and any help about this issue. The pop noise is often a thing with the codec and there are a bunch of different workarounds found in the driver. But the spurious interrupt is more worrisome. Is the PCI slot corresponding to the HD-audio controller? As of now, I'm inclined to take your patch as is, at least as a first-aid workaround. Let's see whether we get a better development soonish. thanks, Takashi > > Thanks. > Alexander > > sound/pci/hda/patch_realtek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index ab5113cccffa..87ad8469dbc5 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -8191,6 +8191,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1025, 0x1308, "Acer Aspire Z24-890", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > SND_PCI_QUIRK(0x1025, 0x132a, "Acer TravelMate B114-21", ALC233_FIXUP_ACER_HEADSET_MIC), > SND_PCI_QUIRK(0x1025, 0x1330, "Acer TravelMate X514-51T", ALC255_FIXUP_ACER_HEADSET_MIC), > + SND_PCI_QUIRK(0x1025, 0x142b, "Acer Swift SF314-42", ALC255_FIXUP_ACER_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1025, 0x1430, "Acer TravelMate B311R-31", ALC256_FIXUP_ACER_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1025, 0x1466, "Acer Aspire A515-56", ALC255_FIXUP_ACER_HEADPHONE_AND_MIC), > SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z), > > base-commit: 62fb9874f5da54fdb243003b386128037319b219 > -- > 2.31.1 >