From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 043FDC282E9 for ; Mon, 21 Jan 2019 08:13:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D202F20855 for ; Mon, 21 Jan 2019 08:13:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729228AbfAUINn (ORCPT ); Mon, 21 Jan 2019 03:13:43 -0500 Received: from mx2.suse.de ([195.135.220.15]:37932 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727980AbfAUINm (ORCPT ); Mon, 21 Jan 2019 03:13:42 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4E3B3ACD9; Mon, 21 Jan 2019 08:13:41 +0000 (UTC) Date: Mon, 21 Jan 2019 09:13:39 +0100 Message-ID: From: Takashi Iwai To: Stephen Rothwell Cc: Linux Next Mailing List , Linux Kernel Mailing List , Jaroslav Kysela Subject: Re: linux-next: build warning after merge of the sound tree In-Reply-To: <20190121112148.591aa586@canb.auug.org.au> References: <20190121112148.591aa586@canb.auug.org.au> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Jan 2019 01:21:48 +0100, Stephen Rothwell wrote: On Mon, 21 Jan 2019 01:21:48 +0100, Stephen Rothwell wrote: > > Hi Takashi, > > After merging the sound tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend': > sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm' [-Wunused-variable] > struct hda_pcm *pcm; > ^~~ > > Introduced by commit > > 17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls") Thanks, fixed now with the patch below. Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] ALSA: hda - Fix unused variable warning The unused variable was forgotten to be removed and now we get a compiler warning: sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend': sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm' Fixes: 17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls") Reported-by: Stephen Rothwell Signed-off-by: Takashi Iwai --- sound/pci/hda/hda_codec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index ff6dbed4d3cd..e4704f5729d3 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c @@ -2923,7 +2923,6 @@ static void hda_call_codec_resume(struct hda_codec *codec) static int hda_codec_runtime_suspend(struct device *dev) { struct hda_codec *codec = dev_to_hda_codec(dev); - struct hda_pcm *pcm; unsigned int state; cancel_delayed_work_sync(&codec->jackpoll_work); -- 2.16.4