From: Takashi Iwai <tiwai@suse.de>
To: "Colin King" <colin.king@canonical.com>
Cc: <alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][V2] sound/core/pcm_timer.c: include pcm_local.h and remove some extraneous tabs
Date: Tue, 30 May 2017 18:05:37 +0200 [thread overview]
Message-ID: <s5h7f0y2uum.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170530103945.32538-1-colin.king@canonical.com>
On Tue, 30 May 2017 12:39:45 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> We need to include pcm_local.h to clean up some smatch warnings:
>
> symbol 'snd_pcm_timer_done' was not declared. Should it be static?
> symbol 'snd_pcm_timer_init' was not declared. Should it be static?
> symbol 'snd_pcm_timer_resolution_change' was not declared. Should
> it be static?
>
> Also remove some extraneous tabs on empty lines and replace space
> intentation with a tab.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
Takashi
prev parent reply other threads:[~2017-05-30 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 10:39 [PATCH][V2] sound/core/pcm_timer.c: include pcm_local.h and remove some extraneous tabs Colin King
2017-05-30 16:05 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h7f0y2uum.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).