From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756004AbcBCOmB (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Feb 2016 09:42:01 -0500
Received: from mx2.suse.de ([195.135.220.15]:48035 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755849AbcBCOl7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Feb 2016 09:41:59 -0500
Date: Wed, 03 Feb 2016 15:41:58 +0100
Message-ID: <s5h8u31hn49.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: alsa-devel@alsa-project.org, Jie Yang <yang.jie@intel.com>,
        Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        LKML <linux-kernel@vger.kernel.org>,
        Alexander Potapenko <glider@google.com>,
        Kostya Serebryany <kcc@google.com>,
        syzkaller <syzkaller@googlegroups.com>,
        Sasha Levin <sasha.levin@oracle.com>
Subject: Re: sound: deadlock between snd_rawmidi_kernel_open/snd_seq_port_connect
In-Reply-To: <CACT4Y+adjCo6gTn2FBAsKnYkHoJMAkL99=YFFkHXTizvK7oJxg@mail.gmail.com>
References: <CACT4Y+aKQXV7xkBW9hpQbzaDO7LrUvohxWh-UwMxXjDy-yBD=A@mail.gmail.com>
	<s5hwpqy9brq.wl-tiwai@suse.de>
	<CACT4Y+Z0KA9bD5Q6K=+zBuxVbToEVYQng-uXOV+z=0_y9RYyfQ@mail.gmail.com>
	<s5hfuxa44m0.wl-tiwai@suse.de>
	<CACT4Y+adjCo6gTn2FBAsKnYkHoJMAkL99=YFFkHXTizvK7oJxg@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 03 Feb 2016 14:22:18 +0100,
Dmitry Vyukov wrote:
> 
> On Wed, Feb 3, 2016 at 8:47 AM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > This looks like a false-positive report to me.  Of course, we should
> >> > annotate the mutex there for nested locks, though.
> >>
> >>
> >> Takashi, can you please annotate it for lockdep? I hit it on every run.
> >
> > The lock had an annotation but alas it didn't seem enough.
> > In anyway, it's not good to have double locks if it's avoidable.  So I
> > worked on it now, and below is the current result of the hack.
> >
> > The change became a bit more intrusive than wished, but it should be
> > still simple enough.  I put this on top of topic/core-fixes branch.
> 
> 
> I don't see the deadlock reports now. Thanks!

Good to hear, now queued for the next pull request.
Thanks for quick tests!


Takashi