From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C9E3C04ABB for ; Tue, 11 Sep 2018 06:17:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C4DC4206BB for ; Tue, 11 Sep 2018 06:17:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4DC4206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726601AbeIKLOt (ORCPT ); Tue, 11 Sep 2018 07:14:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:60444 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726332AbeIKLOt (ORCPT ); Tue, 11 Sep 2018 07:14:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B67F4ACB1; Tue, 11 Sep 2018 06:17:05 +0000 (UTC) Date: Tue, 11 Sep 2018 08:17:05 +0200 Message-ID: From: Takashi Iwai To: "Yu Zhao" Cc: "Mark Brown" , , "Guneshwor Singh" , "Naveen Manohar" , "Pankaj Bharadiya" , "Rakesh Ughreja" , "Sanyog Kale" , "Sriram Periyasamy" , "Vinod Koul" , "Liam Girdwood" , "Pierre-Louis Bossart" , "Jie Yang" , "Jaroslav Kysela" , Subject: Re: [PATCH 3/3] sound: don't call skl_init_chip() to reset intel skl soc In-Reply-To: <20180910212358.203050-1-yuzhao@google.com> References: <20180910212150.202655-1-yuzhao@google.com> <20180910212358.203050-1-yuzhao@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Sep 2018 23:23:58 +0200, Yu Zhao wrote: > > Internally, skl_init_chip() calls snd_hdac_bus_init_chip() which > 1) sets bus->chip_init to prevent multiple entrances before device > is stopped; 2) enables interrupt. > > We shouldn't use it for the purpose of resetting device only because > 1) when we really want to initialize device, we won't be able to do > so; 2) we are ready to handle interrupt yet, and kernel crashes when > interrupt comes in. > > Rename azx_reset() to snd_hdac_bus_reset_link(), and use it to reset > device properly. > > Fixes: 60767abcea3d ("ASoC: Intel: Skylake: Reset the controller in probe") > Signed-off-by: Yu Zhao That makes sense. And I noticed that the legacy HD-audio driver potentially needs the same reset (although we haven't heard of any problem for years). So now I wonder whether this requirement of reset is really mandatory for the real hardware, or just theoretical... In anyway, Reviewed-by: Takashi Iwai thanks, Takashi