From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D70BC4321E for ; Sat, 8 Sep 2018 17:17:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E035B2086B for ; Sat, 8 Sep 2018 17:16:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E035B2086B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727638AbeIHWDZ (ORCPT ); Sat, 8 Sep 2018 18:03:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:39752 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726765AbeIHWDZ (ORCPT ); Sat, 8 Sep 2018 18:03:25 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E1348AD5E; Sat, 8 Sep 2018 17:16:55 +0000 (UTC) Date: Sat, 08 Sep 2018 19:16:55 +0200 Message-ID: From: Takashi Iwai To: Stefan Wahren Cc: Eric Anholt , linux-rpi-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/29] staging: bcm2835-audio: Cleanups and fixes In-Reply-To: <1199025412.60278.1536426034839@email.1und1.de> References: <20180904155858.8001-1-tiwai@suse.de> <2050605805.39126.1536412690563@email.1und1.de> <1199025412.60278.1536426034839@email.1und1.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 08 Sep 2018 19:00:34 +0200, Stefan Wahren wrote: > > Hi, > > > Takashi Iwai hat am 8. September 2018 um 18:21 geschrieben: > > > > > > On Sat, 08 Sep 2018 15:18:10 +0200, > > Stefan Wahren wrote: > > > > > > Hi Takashi, > > > > > > > Takashi Iwai hat am 4. September 2018 um 17:58 geschrieben: > > > > > > > > > > > > Hi, > > > > > > > > since I had an opportunity to play with RPi3B+ recently, I took a look > > > > at the existing bcm2835-audio driver code and was amused very much :) > > > > > > > > So here is the result, a cleanup and fix patch series. > > > > > > > > Most of the patches are trivial cleanups, just brushing up, removing > > > > many redundant and buggy codes, as well as code simplifications. > > > > > > > > A big functional change is that now it uses non-atomic PCM ops, so > > > > that we can kill the ugly workqueue usages. Also, the resource > > > > management was simplified. > > > > > > first of all, thank you very much for this series. > > > > > > Eric has no time as maintainer, so i will try to give you some feedback (beware of very little audio driver knowledge). > > > > > > I functionally tested your patch series on a Raspberry Pi 1 B (bcm2835_defconfig), so this whole series is at least: > > > > > > Tested-by: Stefan Wahren > > > > OK, thanks, I'll put to my series in case of resubmission. > > Meanwhile I'll keep the series in topic/vc04 branch of sound.git > > tree. > > does it mean this series should go through your tree instead of Greg's? I don't mind either way. I just wanted to expose the latest patchset in git tree in case anyone needing more reviews. The merge route can be decided later. > > > Unfortunately there is still an corruption issue with underlying vchiq and multi_v7_defconfig, so no wider tests. > > > > What is this corruption issue? > > Actual there are two of them. > > First one are incompatibilities of older VC4 firmware with commit 14dd37fc7b65 ("staging: vc04_services: Remove cache-line-size property (v3)"). There is a pull request for the Foundation kernel which hasn't been upstreamed yet [1]. > > The second is documented here [2]. > > [1] - https://github.com/raspberrypi/linux/pull/2666 > [2] - https://github.com/lategoodbye/rpi-zero/issues/23 OK, thanks. > > > I don't know if you tested this series on a Raspberry Pi. Maybe you have some specific scenarios, which should be tested. > > > > I have only a RPi3B+, and that's all what I've tested. > > Great, just of curiosity which config did you use? It's SLE / openSUSE. The kernel is almost vanilla 4.18.5 with my patches. > > It'd be great if the patch series could be tested in a wider range of > > models, of course. > > > > The patches are only about cleanups. They corrected the bad usages of > > audio APIs and its design, but basically I haven't touched the basic > > functionality intentionally at all. So the behavior should be kept as > > before. > > > > (Actually it'd be better to revisit the design later, especially about > > the multi-cards option and the PCM route mixer control, but I left as > > is for compatibility reason for now.) > > > > > As a reviewer i have some suggestions, but only trivia. I don't know if it's a problem that this series hasn't been send to devel@driverdev.osuosl.org > > > > No, it's just because that address isn't found in MAINTAINERS file. > > If it should go through it, please correct the entry at first :) > > No, this is the mailing list for all staging driver. It is reported by get_maintainers.pl Ah, I see. thanks, Takashi