From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DDDECDFB8 for ; Wed, 18 Jul 2018 15:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 819FC20856 for ; Wed, 18 Jul 2018 15:39:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 819FC20856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731391AbeGRQRm (ORCPT ); Wed, 18 Jul 2018 12:17:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:35400 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726409AbeGRQRl (ORCPT ); Wed, 18 Jul 2018 12:17:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4AE2CAFB0; Wed, 18 Jul 2018 15:39:12 +0000 (UTC) Date: Wed, 18 Jul 2018 17:39:11 +0200 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Jerome Brunet , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Kevin Hilman , Liam Girdwood , linux-kernel@vger.kernel.org, Carlo Caione , linux-amlogic@lists.infradead.org Subject: Re: [alsa-devel] [PATCH RESEND 02/15] ASoC: meson: add axg fifo base driver In-Reply-To: <20180718115054.GI5700@sirena.org.uk> References: <20180717154304.9973-1-jbrunet@baylibre.com> <20180717154304.9973-3-jbrunet@baylibre.com> <20180718115054.GI5700@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Jul 2018 13:50:54 +0200, Mark Brown wrote: > > On Tue, Jul 17, 2018 at 05:42:51PM +0200, Jerome Brunet wrote: > > > + return !status ? IRQ_NONE : IRQ_HANDLED; > > Please just write normal conditional statements, it makes things a lot > easier to read (the ! isn't helping either here). ... and there is the standard IRQ_RETVAL() macro for this purpose. Takashi