From: Takashi Iwai <tiwai@suse.de>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Fix quirk for TongFang PHxTxX1
Date: Thu, 02 Dec 2021 17:19:25 +0100 [thread overview]
Message-ID: <s5hbl1zt1wy.wl-tiwai@suse.de> (raw)
In-Reply-To: <aceae41d-eeaa-9f13-2e37-9fce08e693c6@tuxedocomputers.com>
On Thu, 02 Dec 2021 17:02:51 +0100,
Werner Sembach wrote:
>
> Am 02.12.21 um 16:35 schrieb Takashi Iwai:
> > On Thu, 02 Dec 2021 16:28:43 +0100,
> > Werner Sembach wrote:
> >> This fixes the SND_PCI_QUIRK(...) of the TongFang PHxTxX1 barebone. This
> >> fixes the issue of sound not working after s3 suspend.
> >>
> >> When waking up from s3 suspend the Coef 0x10 is set to 0x0220 instead of
> >> 0x0020. Setting the value manually makes the sound work again. This patch
> >> does this automatically.
> >>
> >> While being on it, I also fixed the comment formatting of the quirk.
> >>
> >> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> >> Cc: <stable@vger.kernel.org>
> > Please try to put Fixes tag as this is a fix for the existing change.
> Sorry, wasn't aware of this. I guess it's [PATCH Fixes] as the beginning of the subject line?
No, the Fixes tag is another line you add around your Signed-off-by
line for indicating that that the patch is for fixing the given
commit. In your case, it'll be like
Fixes: dd6dd6e3c791 ("ALSA: hda/realtek: Add quirk for TongFang PHxTxX1")
HTH,
Takashi
next prev parent reply other threads:[~2021-12-02 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 15:28 [PATCH] ALSA: hda/realtek: Fix quirk for TongFang PHxTxX1 Werner Sembach
2021-12-02 15:35 ` Werner Sembach
2021-12-02 15:39 ` Takashi Iwai
2021-12-02 15:35 ` Takashi Iwai
2021-12-02 16:02 ` Werner Sembach
2021-12-02 16:19 ` Takashi Iwai [this message]
2021-12-02 17:18 ` Werner Sembach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbl1zt1wy.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).