From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA2AEC433ED for ; Wed, 21 Apr 2021 16:21:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80AD861168 for ; Wed, 21 Apr 2021 16:21:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244365AbhDUQWR (ORCPT ); Wed, 21 Apr 2021 12:22:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:34988 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241016AbhDUQWA (ORCPT ); Wed, 21 Apr 2021 12:22:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 1FB4CAFD8; Wed, 21 Apr 2021 16:21:26 +0000 (UTC) Date: Wed, 21 Apr 2021 18:21:26 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Kangjie Lu Subject: Re: [PATCH 127/190] Revert "ALSA: sb8: add a check for request_region" In-Reply-To: <20210421130105.1226686-128-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-128-gregkh@linuxfoundation.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Apr 2021 15:00:02 +0200, Greg Kroah-Hartman wrote: > > This reverts commit dcd0feac9bab901d5739de51b3f69840851f8919. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Kangjie Lu > Cc: Takashi Iwai > Signed-off-by: Greg Kroah-Hartman This code change itself looks OK, OTOH, the original commit message is slightly wrong: the code path can never result in NULL deference in this case, as it's just an optional resource reservation. So, it's safe to revert this. thanks, Takashi > --- > sound/isa/sb/sb8.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c > index 6c9d534ce8b6..95290ffe5c6e 100644 > --- a/sound/isa/sb/sb8.c > +++ b/sound/isa/sb/sb8.c > @@ -95,10 +95,6 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev) > > /* block the 0x388 port to avoid PnP conflicts */ > acard->fm_res = request_region(0x388, 4, "SoundBlaster FM"); > - if (!acard->fm_res) { > - err = -EBUSY; > - goto _err; > - } > > if (port[dev] != SNDRV_AUTO_PORT) { > if ((err = snd_sbdsp_create(card, port[dev], irq[dev], > -- > 2.31.1 >