From: Takashi Iwai <tiwai@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Ayman Bagabas <ayman.bagabas@gmail.com>,
alsa-devel@alsa-project.org, Hui Wang <hui.wang@canonical.com>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Jaroslav Kysela <perex@perex.cz>,
Kailang Yang <kailang@realtek.com>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED
Date: Tue, 20 Nov 2018 10:23:25 +0100 [thread overview]
Message-ID: <s5hbm6kf6gi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181120091039.GA16916@amd>
On Tue, 20 Nov 2018 10:10:39 +0100,
Pavel Machek wrote:
>
> On Tue 2018-11-20 08:07:09, Takashi Iwai wrote:
> > On Tue, 20 Nov 2018 00:57:13 +0100,
> > Pavel Machek wrote:
> > >
> > > > +#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP)
> > > > +#include <linux/platform_data/x86/huawei_wmi.h>
> > > > +
> > > > +static int (*huawei_wmi_micmute_led_set_func)(bool);
> > > > +
> > >
> > > So we should not be doing this.
> > >
> > > Thinkpad ACPI module exports its LEDs there, for example.
> >
> > Both thinkpad_acpi and dell_laptop provide the interface to HD-audio
> > in the very same way like this.
>
> Not good :-(. Please don't add new ones, general purpose LEDs should
> really use LED subsystem.
What's the problem with this approach?
Takashi
next prev parent reply other threads:[~2018-11-20 9:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 17:16 [PATCH v3 0/3] Huawei laptops Ayman Bagabas
2018-11-08 17:16 ` [PATCH v3 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
2018-11-08 19:58 ` Andy Shevchenko
2018-11-09 3:52 ` ayman.bagabas
2018-11-09 10:40 ` Andy Shevchenko
2018-11-08 17:16 ` [PATCH v3 2/3] ALSA: hda: fix front speakers on Huawei MBXP Ayman Bagabas
2018-11-09 8:55 ` Takashi Iwai
2018-11-08 17:16 ` [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED Ayman Bagabas
2018-11-09 9:01 ` Takashi Iwai
[not found] ` <CAB3uXr7-YW+yND1EC_wt8ptgnhUZLaYsoxJbs-vcWvOeEy6+Zw@mail.gmail.com>
2018-11-09 13:28 ` Takashi Iwai
2018-11-19 23:57 ` Pavel Machek
2018-11-20 7:07 ` Takashi Iwai
2018-11-20 9:10 ` Pavel Machek
2018-11-20 9:23 ` Takashi Iwai [this message]
2018-11-20 9:36 ` Pavel Machek
2018-11-20 9:49 ` Takashi Iwai
2018-11-20 11:51 ` Pavel Machek
2018-11-20 12:19 ` Takashi Iwai
2018-11-22 11:36 ` Andy Shevchenko
2018-11-22 13:18 ` Pavel Machek
2018-11-22 13:43 ` Takashi Iwai
2018-11-23 22:05 ` Pavel Machek
2018-11-23 23:33 ` Pavel Machek
2018-11-24 8:10 ` Takashi Iwai
2018-11-24 10:41 ` Pavel Machek
2018-11-22 13:12 ` Pavel Machek
2018-11-22 13:14 ` Takashi Iwai
2018-11-08 19:59 ` [PATCH v3 0/3] Huawei laptops Andy Shevchenko
2018-11-09 3:38 ` ayman.bagabas
2018-11-09 7:41 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbm6kf6gi.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andy@infradead.org \
--cc=ayman.bagabas@gmail.com \
--cc=dvhart@infradead.org \
--cc=hui.wang@canonical.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).